MC-15742: Hard Coded 35px Margin Bottom On Slider on Storefront

- fix existing test to adjust for new slider height
- add test coverage for slider height no dots

Author: anthoula

app/code/Magento/PageBuilder/Test/Mftf/Data/SliderData.xml

@@ -107,7 +107,7 @@
     </entity>
     <!-- Container Height -->
     <entity name="PageBuilderEmptySliderContainerHeight" type="pagebuilder_slider_height_property">
-        <data key="value">368</data>
+        <data key="value">360</data>
     </entity>
     <!-- CSS Classes -->
     <entity name="PageBuilderSliderAdvancedCssClasses_Default" type="pagebuilder_advanced_css_classes_property">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSliderCommonTests.xml

@@ -616,6 +616,68 @@
             <argument name="padding" value="PageBuilderPaddingProperty10"/>
         </actionGroup>
     </test>
+    <test name="SliderWithNoDotsEqualToMinHeight" extends="RowWithBordersAndPaddingEqualToMinHeight">
+        <annotations>
+            <features value="PageBuilder"/>
+            <stories value="Slider"/>
+            <title value="Slider with no dots is equal to min height"/>
+            <description value="A user can see Slider height with no dots is equal to min height"/>
+            <severity value="AVERAGE"/>
+            <useCaseId value="MC-15742"/>
+            <testCaseId value="MC-18088"/>
+            <group value="pagebuilder"/>
+            <group value="pagebuilder-slide"/>
+            <group value="pagebuilder-sliderCommon"/>
+        </annotations>
+        <actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
+            <argument name="contentType" value="PageBuilderSliderContentType"/>
+        </actionGroup>
+        <actionGroup ref="expandPageBuilderPanelMenuSection" after="enterPageTitle" stepKey="expandMenuSection">
+            <argument name="contentType" value="PageBuilderSliderContentType"/>
+        </actionGroup>
+        <actionGroup ref="dragContentTypeToStage" after="commentConfigureContentType" stepKey="dragContentTypeToStage">
+            <argument name="contentType" value="PageBuilderSliderContentType"/>
+        </actionGroup>
+        <click selector="{{PageBuilderPanel.searchPanel}}" after="dragContentTypeToStage" stepKey="unFocusSlide"/>
+        <actionGroup ref="openPageBuilderEditPanel" stepKey="openEditPanel">
+            <argument name="contentType" value="PageBuilderSliderContentType"/>
+        </actionGroup>
+        <actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinHeightProperty">
+            <argument name="property" value="PageBuilderSliderMinHeight_Default"/>
+        </actionGroup>
+        <actionGroup ref="conditionalClickSlideOutPanelFieldGeneral" after="enterMinHeightProperty" stepKey="enterShowDotsDisabled">
+            <argument name="property" value="PageBuilderSliderShowDots_Disabled"/>
+        </actionGroup>
+        <comment userInput="keyForRemoval" stepKey="enterBorder"/>
+        <comment userInput="keyForRemoval" stepKey="enterBorderColor"/>
+        <comment userInput="keyForRemoval" stepKey="enterBorderWidth"/>
+        <comment userInput="keyForRemoval" stepKey="enterPadding"/>
+        <actionGroup ref="openPageBuilderEditPanelSmallByIndex" after="saveEditPanelSettings" stepKey="openSlideItemEditPanel">
+            <argument name="section" value="SlideOnBackend"/>
+        </actionGroup>
+        <actionGroup ref="fillSlideOutPanelFieldGeneral" after="openSlideItemEditPanel" stepKey="enterMinHeightPropertySlideItem">
+            <argument name="property" value="PageBuilderSlideItemMinimumHeight_300"/>
+        </actionGroup>
+        <actionGroup ref="fillSlideOutPanelField" after="enterMinHeightPropertySlideItem" stepKey="enterBackgroundColor">
+            <argument name="property" value="PageBuilderBackgroundColor_Hex_Grey"/>
+        </actionGroup>
+        <actionGroup ref="saveEditPanelSettings" after="enterBackgroundColor" stepKey="saveEditPanelSettings2"/>
+        <actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightBeforeSave">
+            <argument name="content" value="{{SliderOnStage.containerCSS}}"/>
+            <argument name="height" value="PageBuilderSliderMinHeight_Default"/>
+        </actionGroup>
+        <actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightAfterSave">
+            <argument name="content" value="{{SliderOnStage.containerCSS}}"/>
+            <argument name="height" value="PageBuilderSliderMinHeight_Default"/>
+        </actionGroup>
+        <actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
+            <argument name="contentType" value="PageBuilderSliderContentType"/>
+        </actionGroup>
+        <actionGroup ref="validateContentTypeHeightEqualToMinHeight" stepKey="validateContentTypeHeightStorefront">
+            <argument name="content" value="{{SliderOnFrontend.all}}"/>
+            <argument name="height" value="PageBuilderSliderMinHeight_Default"/>
+        </actionGroup>
+    </test>
     <test name="SliderMoveSlider">
         <annotations>
             <features value="PageBuilder"/>