Skip to content

Commit 4557c8c

Browse files
committed
MC-5423: Scheduled Update slide out issues
- Fix “Edit with PageBuilder” button
1 parent f8cf236 commit 4557c8c

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/form/element/wysiwyg.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ define([
115115
* Toggle Page Builder full screen mode
116116
*/
117117
toggleFullScreen: function () {
118-
events.trigger('stage:' + this.pageBuilder.id + ':toggleFullscreen', {});
118+
events.trigger('stage:' + this.pageBuilder.id + ':toggleFullscreen', {animate: false});
119119
},
120120

121121
/**

app/code/Magento/PageBuilder/view/adminhtml/web/js/page-builder.js

Lines changed: 7 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/page-builder.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,19 @@ export default class PageBuilder implements PageBuilderInterface {
4141
* Init listeners.
4242
*/
4343
public initListeners() {
44-
events.on(`stage:${ this.id }:toggleFullscreen`, () => this.toggleFullScreen());
44+
events.on(`stage:${ this.id }:toggleFullscreen`, this.toggleFullScreen.bind(this));
4545
this.isFullScreen.subscribe(() => this.onFullScreenChange());
4646
}
4747

4848
/**
4949
* Tells the stage wrapper to expand to fullScreen
5050
*/
51-
public toggleFullScreen(): void {
51+
public toggleFullScreen(args): void {
52+
if (typeof args.animate !== "undefined" && args.animate === false) {
53+
this.isFullScreen(!this.isFullScreen());
54+
return;
55+
}
56+
5257
const stageWrapper = $("#" + this.stage.id).parent();
5358
const pageBuilderWrapper = stageWrapper.parents(".pagebuilder-wysiwyg-wrapper");
5459
const panel = stageWrapper.find(".pagebuilder-panel");

0 commit comments

Comments
 (0)