MC-17823: Access Images/Widgets/Variable from HTML content type

- add translations
- remove disable ESLint rules
- improve method params

Author: anthoula

app/code/Magento/PageBuilder/Component/Form/HtmlCode.php

@@ -17,7 +17,7 @@
  */
 class HtmlCode extends \Magento\Ui\Component\Form\Field
 {
-    const HTML_ID = 'HTML_ID';
+    const HTML_ID_PLACEHOLDER = 'HTML_ID_PLACEHOLDER';
 
     /**
      * @var BackendUrlInterface
@@ -75,15 +75,19 @@ public function __construct(
     public function prepare()
     {
         $config = $this->getData('config');
-        $config['widgetUrl'] = $this->backendUrl->getUrl('adminhtml/widget/index')
-            . 'widget_target_id/' . self::HTML_ID . '/';
-
-        $fileBrowserUrlParams = [
-            'current_tree_path' => $this->imagesHelper->idEncode($this->currentTreePath),
-        ];
-
-        $config['imageUrl'] = $this->backendUrl->getUrl('cms/wysiwyg_images/index', $fileBrowserUrlParams)
-            . 'target_element_id/' . self::HTML_ID . '/';
+        $config['widgetUrl'] = $this->backendUrl->getUrl(
+            'adminhtml/widget/index',
+            [
+                'widget_target_id' => self::HTML_ID_PLACEHOLDER
+            ]
+        );
+        $config['imageUrl'] = $this->backendUrl->getUrl(
+            'cms/wysiwyg_images/index',
+            [
+                'current_tree_path' => $this->imagesHelper->idEncode($this->currentTreePath),
+                'target_element_id' => self::HTML_ID_PLACEHOLDER
+            ]
+        );
         $config['variableUrl'] = $this->variableConfig->getVariablesWysiwygActionUrl();
         $this->setData('config', $config);
         parent::prepare();

app/code/Magento/PageBuilder/i18n/en_US.csv

@@ -290,4 +290,7 @@ OK,OK
 "We are unable to support links within the content field whilst having a link set on the content type. Please remove the content type link if you'd like to set a link within the content. We will automatically remove the links within the content field.","We are unable to support links within the content field whilst having a link set on the content type. Please remove the content type link if you'd like to set a link within the content. We will automatically remove the links within the content field."
 "Nested links are not allowed","Nested links are not allowed"
 "Close Full Screen","Close Full Screen"
-"Open in Full Screen","Open in Full Screen"
+"Open in Full Screen","Open in Full Screen"
+"Insert Widget...","Insert Widget..."
+"Insert Image...","Insert Image..."
+"Insert Variable...","Insert Variable..."

app/code/Magento/PageBuilder/view/adminhtml/web/js/form/element/html-code.js

@@ -3,26 +3,25 @@
  * See COPYING.txt for license details.
  */
 
-/*eslint-disable vars-on-top, strict */
-
 define([
     'Magento_Ui/js/form/element/textarea',
-    'mage/adminhtml/wysiwyg/widget',
+    'mage/adminhtml/wysiwyg/widget'
 ], function (Textarea) {
     'use strict';
 
+    const HTML_ID_PLACEHOLDER = 'HTML_ID_PLACEHOLDER';
+
     return Textarea.extend({
         defaults: {
-            elementTmpl: 'Magento_PageBuilder/form/element/html-code',
-            htmlId: 'HTML_ID'
+            elementTmpl: 'Magento_PageBuilder/form/element/html-code'
         },
 
         /**
          * Click event for Insert Widget Button
          */
         clickInsertWidget: function () {
             return widgetTools.openDialog(
-                this.widgetUrl.replace(this.htmlId, this.uid)
+                this.widgetUrl.replace(HTML_ID_PLACEHOLDER, this.uid)
             );
         },
 
@@ -31,7 +30,7 @@ define([
          */
         clickInsertImage: function () {
             return MediabrowserUtility.openDialog(
-                this.imageUrl.replace(this.htmlId, this.uid)
+                this.imageUrl.replace(HTML_ID_PLACEHOLDER, this.uid)
             );
         },
 
@@ -40,7 +39,8 @@ define([
          */
         clickInsertVariable: function () {
             return MagentovariablePlugin.loadChooser(
-                this.variableUrl, this.uid
+                this.variableUrl,
+                this.uid
             );
         },
     });

app/code/Magento/PageBuilder/view/adminhtml/web/template/form/element/html-code.html

@@ -12,7 +12,7 @@
                 click="clickInsertWidget">
             <span>
                 <span>
-                    <span>Insert Widget...</span>
+                    <span translate="'Insert Widget...'"/>
                 </span>
             </span>
         </button>
@@ -21,7 +21,7 @@
                 click="clickInsertImage">
             <span>
                 <span>
-                    <span>Insert Image...</span>
+                    <span translate="'Insert Image...'"/>
                 </span>
             </span>
         </button>
@@ -30,7 +30,7 @@
                 click="clickInsertVariable">
             <span>
                 <span>
-                    <span>Insert Variable...</span>
+                    <span translate="'Insert Variable...'"/>
                 </span>
             </span>
         </button>