Skip to content

Commit 4249566

Browse files
committed
MC-4217: Performance of show/hide Slider on stage is very slow
- Fix issue with slider setPosition inside of tab
1 parent 5be7853 commit 4249566

File tree

2 files changed

+6
-6
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml/web

2 files changed

+6
-6
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slider/preview.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slider/preview.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,11 @@ export default class Preview extends PreviewCollection {
102102
this.buildSlick();
103103

104104
// Redraw slide after content type gets redrawn
105-
events.on("contentType:redrawAfter", function(args: ContentTypeAfterRenderEventParamsInterface) {
106-
if ($.contains(args.element, this.element)) {
105+
events.on("contentType:redrawAfter", (args: ContentTypeAfterRenderEventParamsInterface) => {
106+
if (args.element && this.element && $.contains(args.element, this.element)) {
107107
$(this.element).slick("setPosition");
108108
}
109-
}.bind(this));
109+
});
110110

111111
// Set the stage to interacting when a slide is focused
112112
this.focusedSlide.subscribe((value: number) => {

0 commit comments

Comments
 (0)