Skip to content

Commit 41e6086

Browse files
author
joiecaquicla
committed
#636: Responsive breakpoint switcher - move switcher to another template
1 parent 25556c2 commit 41e6086

File tree

4 files changed

+29
-11
lines changed

4 files changed

+29
-11
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/page-builder.js

Lines changed: 8 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/template/page-builder.html

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,7 @@
1212
<div class="admin__field pagebuilder-header"
1313
css="visible: panel.isVisible(), 'transition-out': isSnapshotTransition()"
1414
if="!isSnapshot()">
15-
<each args="data: Object.keys(viewports), as: 'name'">
16-
<span class="tooltip">
17-
<button type="button" translate="$parent.viewports[name].label" disable="name === $parent.viewport()" click="$parent.toggleViewport.bind($parent, name)"/>
18-
<span class="tooltip-content">
19-
<span class="tooltip-label" translate="$parent.viewports[name].label"/><br/>
20-
<span translate="'View your content for '"/><text args="name"/><br/>
21-
<span translate="'Width'"/>: <text args="Object.values($parent.viewports[name].conditions)[0]"/>
22-
</span>
23-
</span>
24-
</each>
15+
<!-- ko template: viewportTemplate --><!-- /ko -->
2516
<button type="button" translate="'Apply Template'" if="isAllowedTemplateApply" click="toggleTemplateManger"/>
2617
<button type="button" translate="'Save as Template'" if="isAllowedTemplateSave" click="saveAsTemplate"/>
2718
<i click="toggleFullScreen.bind($data, {animate:true})"
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
<!--
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
-->
7+
<each args="data: Object.keys(viewports), as: 'name'">
8+
<span class="tooltip">
9+
<button type="button" translate="$parent.viewports[name].label" disable="name === $parent.viewport()" click="$parent.toggleViewport.bind($parent, name)"/>
10+
<span class="tooltip-content">
11+
<span class="tooltip-label" translate="$parent.viewports[name].label"/><br/>
12+
<span translate="'View your content for '"/><text args="name"/><br/>
13+
<span translate="'Width'"/>: <text args="Object.values($parent.viewports[name].conditions)[0]"/>
14+
</span>
15+
</span>
16+
</each>

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/page-builder.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,10 @@ export default class PageBuilder implements PageBuilderInterface {
223223
return this.template;
224224
}
225225

226+
get viewportTemplate(): string {
227+
return "Magento_PageBuilder/viewport/switcher";
228+
}
229+
226230
/**
227231
* Toggle template manager
228232
*/

0 commit comments

Comments
 (0)