Skip to content

Commit 41ce916

Browse files
committed
Merge remote-tracking branch 'origin/MC-1438' into MC-1438
2 parents c365a11 + 55d246a commit 41ce916

File tree

2 files changed

+16
-12
lines changed

2 files changed

+16
-12
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/TextData.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,5 +56,9 @@
5656
<entity name="PageBuilderTextArea_WidgetCMSPageLink" type="pagebuilder_text_widget_property">
5757
<data key="widgetType">Magento\Cms\Block\Widget\Page\Link</data>
5858
<data key="editPanelValue">{{widget type=&quot;Magento\\Cms\\Block\\Widget\\Page\\Link&quot; template=&quot;widget/link/link_block.phtml&quot; page_id=</data>
59-
</entity>
59+
</entity>
60+
<entity name="PageBuilderTextArea_WidgetCMSHomepageLink" type="pagebuilder_text_widget_property">
61+
<data key="widgetType">Magento\Cms\Block\Widget\Page\Link</data>
62+
<data key="editPanelValue">{{widget type="Magento\Cms\Block\Widget\Page\Link" template="widget/link/link_block.phtml" page_id="2" type_name="CMS Page Link"}}</data>
63+
</entity>
6064
</entities>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -43,21 +43,21 @@
4343
<seeElement selector="{{TextOnStage.textareaPlaceholder('1')}}" stepKey="seeTextareaPlaceholder"/>
4444
<!--Check min height of textarea-->
4545
<comment userInput="Check min height of textarea" stepKey="comment2"/>
46-
47-
48-
49-
46+
<executeJS function="return jQuery('.inline-wysiwyg-textarea').css('min-height');" stepKey="height"/>
47+
<assertEquals stepKey="assertMinHeight">
48+
<actualResult type="variable">height</actualResult>
49+
<expectedResult type="string">50px</expectedResult>
50+
</assertEquals>
5051
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage2"/>
5152
<!--Verify empty content type on storefront-->
5253
<comment userInput="Verify empty content type on storefront" stepKey="commentVerifyEmptyBlock"/>
5354
<amOnPage url="$$createCMSPage.identifier$$" stepKey="amOnPageTestPage"/>
55+
<waitForPageLoad stepKey="waitForPageLoad" />
5456
<seeElementInDOM selector="{{TextOnStorefront.empty('1')}}" stepKey="seeEmptyTextContentType"/>
5557
<dontSeeElement selector="{{TextOnStorefront.empty('1')}}" stepKey="dontSeeEmptyTextContentTypeOnStorefront"/>
5658
<!--Check min height of textarea on Storefront-->
5759
<comment userInput="Check min height of textarea on Storefront" stepKey="comment3"/>
58-
59-
60-
60+
<seeElementInDOM selector="{{TextOnStorefront.noCssClasses('1')}}" stepKey="dontSeeCSSClassOnEmptyTextarea"/>
6161
</test>
6262
<test name="TextVerifyTextAreaOnTextContentType">
6363
<annotations>
@@ -167,17 +167,17 @@
167167
<!-- Verify inputed text is carried out to slideout -->
168168
<comment userInput="Verify inputed text is carried out to slideout" stepKey="comment1"/>
169169
<waitForElementVisible selector="{{TextOnConfiguration.textInIFrame(PageBuilderTextProperty.value)}}" stepKey="waitForText"/>
170+
<switchToIFrame stepKey="exitIFrame1"/>
170171
<!-- Add variable to tinymce3 -->
171172
<comment userInput="Add variable to tinymce3" stepKey="comment2"/>
172-
<executeJS function="tinymce.get('pagebuilder_text_form_content').setContent({{PageBuilderTextArea_VariableBaseURL.editPanelValue}});" stepKey="addVariable"/>
173+
<executeJS function="tinymce.get('pagebuilder_text_form_content').setContent('{{PageBuilderTextArea_VariableBaseURL.editPanelValue}}');" stepKey="addVariable"/>
173174
<!-- Add widget to tinymce3 -->
174175
<comment userInput="Add widget to tinymce3" stepKey="comment3"/>
175-
<executeJS function="tinymce.get('pagebuilder_text_form_content').setContent({{PageBuilderTextArea_WidgetCMSPageLink.editPanelValue}});" stepKey="addWidget"/>
176-
<switchToIFrame stepKey="exitIFrame1"/>
176+
<executeJS function="tinymce.get('pagebuilder_text_form_content').setContent('{{PageBuilderTextArea_WidgetCMSHomepageLink.editPanelValue}}');" stepKey="addWidget"/>
177177
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings"/>
178178
<!-- Validate Stage After Save -->
179179
<comment userInput="Validate Stage After Save" stepKey="commentValidateStage2"/>
180-
<waitForElementVisible selector="{{TextOnStage.textAreaTextContains('1', PageBuilderTextArea_WidgetCMSPageLink.editPanelValue)}}" stepKey="waitForWidgetOnStage"/>
180+
<waitForElementVisible selector="{{TextOnStage.textAreaTextContains('1', PageBuilderTextArea_WidgetCMSHomepageLink.editPanelValue)}}" stepKey="waitForWidgetOnStage"/>
181181
<waitForElementVisible selector="{{TextOnStage.textAreaTextContains('1', PageBuilderTextArea_VariableBaseURL.editPanelValue)}}" stepKey="waitForVariableOnStage"/>
182182
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage2"/>
183183
<amOnPage url="" stepKey="goToBaseURL"/>

0 commit comments

Comments
 (0)