Skip to content

Commit 4040a9a

Browse files
committed
MC-3398: Create/update MFTF tests for vertical alignment in tab item
- remove stray group - add selector for no min height - add semicolons
1 parent e255c3f commit 4040a9a

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/LayoutConfigurationActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<argument name="verticalAlignContainer" defaultValue="PageBuilderVerticalAlignmentPropertyTop"/>
1616
</arguments>
1717
<waitForElement selector="{{page.container(index)}}" stepKey="waitForVerticalAlignContainer"/>
18-
<dontSeeElement selector="{{page.containerStyle(index, PageBuilderMinHeightProperty_Empty.style)}}" stepKey="dontSeeStyle"/>
18+
<seeElement selector="{{page.noMinHeight(index)}}" stepKey="dontSeeStyle"/>
1919
<seeElement selector="{{page.containerStyle(index, verticalAlignContainer.style)}}" stepKey="seeVerticalAlignmentStyle"/>
2020
</actionGroup>
2121
<!-- Validate All Layout Styles -->

app/code/Magento/PageBuilder/Test/Mftf/Data/CommonContentTypeData.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
<data key="section">layout</data>
1515
<data key="fieldName">min_height</data>
1616
<data key="value"/>
17-
<data key="style">min-height</data>
1817
</entity>
1918
<entity name="PageBuilderMinHeightProperty_500" type="pagebuilder_min_height_property">
2019
<data key="name">Minimum Height</data>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderTabsSection.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@
5959
<element name="tabContentPadding" type="button" selector="//*[@role='tabpanel'][{{arg1}}]//div[contains(@class, 'pagebuilder-tab-item')][contains(@style, 'padding: {{arg2}}')]" parameterized="true"/>
6060
<element name="container" type="button" selector="(//*[@role='tabpanel'])[{{arg1}}]//div[contains(@class, 'pagebuilder-tab-item')]//div[contains(@class, 'tab-item-container')]" parameterized="true"/>
6161
<element name="containerStyle" type="button" selector="(//*[@role='tabpanel'])[{{arg1}}]//div[contains(@class, 'pagebuilder-tab-item')]//div[contains(@class, 'tab-item-container')][contains(@style,'{{arg2}}')]" parameterized="true"/>
62+
<element name="noMinHeight" type="button" selector="(//*[@role='tabpanel'])[{{arg1}}]//div[contains(@class, 'pagebuilder-tab-item')][not(contains(@style,'min-height:'))]" parameterized="true"/>
6263
<element name="minHeight" type="button" selector="(//*[@role='tabpanel'])[{{arg1}}]//div[contains(@class, 'pagebuilder-tab-item')][contains(@style,'min-height: {{arg2}}px;')]" parameterized="true"/>
6364
<element name="verticalAlignContainer" type="button" selector="(//*[@role='tabpanel'])[{{arg1}}]//div[contains(@class, 'pagebuilder-tab-item')]//div[contains(@class, 'tab-item-container')][contains(@style,'justify-content: {{arg2}};')]" parameterized="true"/>
6465
<element name="tabTextContent" type="button" selector="//div[@class='pagebuilder-text']"/>
@@ -71,8 +72,9 @@
7172
<element name="tabPanel" type="button" selector="(//div[@class='tabs-content']//div[@role='tabpanel'])[{{arg1}}]" parameterized="true"/>
7273
<element name="container" type="button" selector="(//div[@class='tabs-content']//div[@data-role='tab-item'])[{{arg1}}]" parameterized="true"/>
7374
<element name="containerStyle" type="button" selector="(//div[@class='tabs-content']//div[@data-role='tab-item'])[{{arg1}}][contains(@style,'{{arg2}}')]" parameterized="true"/>
74-
<element name="minHeight" type="button" selector="(//div[@class='tabs-content']//div[@data-role='tab-item'])[{{arg1}}][contains(@style,'min-height: {{arg2}}px')]" parameterized="true"/>
75-
<element name="verticalAlignContainer" type="button" selector="(//div[@class='tabs-content']//div[@data-role='tab-item'])[{{arg1}}][contains(@style,'justify-content: {{arg2}}')]" parameterized="true"/>
75+
<element name="noMinHeight" type="button" selector="(//div[@class='tabs-content']//div[@data-role='tab-item'])[{{arg1}}][not(contains(@style,'min-height:'))]" parameterized="true"/>
76+
<element name="minHeight" type="button" selector="(//div[@class='tabs-content']//div[@data-role='tab-item'])[{{arg1}}][contains(@style,'min-height: {{arg2}}px;')]" parameterized="true"/>
77+
<element name="verticalAlignContainer" type="button" selector="(//div[@class='tabs-content']//div[@data-role='tab-item'])[{{arg1}}][contains(@style,'justify-content: {{arg2}};')]" parameterized="true"/>
7678
<element name="tabContentAdvancedStyles" type="button" selector="(//div[@class='tabs-content']//div[@data-role='tab-item'])[{{arg1}}][@style='border-radius: 0px 12px 12px; border: 10px solid rgb(0, 0, 0);']" parameterized="true"/>
7779
<element name="tabContentMinimumHeight" type="button" selector="(//div[@class='tabs-content']//div[@data-role='tab-item'])[{{arg1}}][contains(@style, 'min-height: {{arg2}}px')]" parameterized="true"/>
7880
<element name="tabContentBackgroundColor" type="button" selector="(//div[@class='tabs-content']//div[@data-role='tab-item'])[{{arg1}}][contains(@style, 'background-color: {{arg2}}')]" parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabItemLayoutTest.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,6 @@
178178
<useCaseId value="MC-931"/>
179179
<testCaseId value="MC-3437"/>
180180
<group value="pagebuilder"/>
181-
<group value="pagebuilder-me"/>
182181
<group value="pagebuilder-tabs"/>
183182
<group value="pagebuilder-tabsLayout"/>
184183
</annotations>

0 commit comments

Comments
 (0)