Skip to content

Commit 3d4e9c1

Browse files
cspruiellcspruiell
committed
MC-3406: Explicit Background Attributes for Tab
 - stabilize tests
1 parent 4a8127a commit 3d4e9c1

File tree

1 file changed

+17
-32
lines changed

1 file changed

+17
-32
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabItemConfigurationTests.xml

Lines changed: 17 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,10 @@
6161
<actionGroup ref="addTab" stepKey="addTab"/>
6262
<waitForElementVisible selector="{{TabOnStage.tabHeader('2')}}" stepKey="seeTabHeader2"/>
6363
<see selector="{{TabOnStage.tabHeader('2')}}" userInput="Tab 2" stepKey="seeTab2DefaultTitleAdmin"/>
64-
<seeElement selector="{{TabOnStage.tabContentBackgroundPosition('2', PageBuilderBackgroundPosition_Default.styleValue)}}" stepKey="seeTabBackgroundPositionAdmin2"/>
65-
<seeElement selector="{{TabOnStage.tabContentBackgroundSize('2', PageBuilderBackgroundSize_Default.value)}}" stepKey="seeTabBackgroundSizeAdmin2"/>
66-
<seeElement selector="{{TabOnStage.tabContentBackgroundAttachment('2', PageBuilderBackgroundAttachment_Default.value)}}" stepKey="seeTabBackgroundAttachmentAdmin2"/>
67-
<seeElement selector="{{TabOnStage.tabContentBackgroundRepeat('2', PageBuilderBackgroundRepeat_Disabled.styleValue)}}" stepKey="seeTab2StageBackgroundRepeatNo"/>
64+
<actionGroup ref="validateBackgroundAttributesWithNoImageOrColor" stepKey="validateTab2BackgroundAttributesWithNoImageOrColor">
65+
<argument name="section" value="TabOnStage"/>
66+
<argument name="index" value="2"/>
67+
</actionGroup>
6868
<actionGroup ref="switchTabs" stepKey="switchTabsAdmin">
6969
<argument name="section" value="TabOnStage"/>
7070
<argument name="from" value="2"/>
@@ -73,25 +73,9 @@
7373
<!-- View default Tabs with empty first Tab on stage -->
7474
<comment userInput="View default Tabs with empty first Tab on stage" stepKey="AC7"/>
7575
<see selector="{{TabOnStage.tabHeader('1')}}" userInput="{{PageBuilderTabName1Default.value}}" stepKey="seeTab1TitleAdmin1"/>
76-
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="validateBackgroundColor">
77-
<argument name="property" value="PageBuilderBackgroundColor_Default"/>
78-
</actionGroup>
79-
<actionGroup ref="seeNoColorInColorSwatch" stepKey="validateColorSwatch">
80-
<argument name="property" value="PageBuilderBackgroundColor_Default"/>
81-
</actionGroup>
82-
<actionGroup ref="validateSlideOutPanelFieldPlaceholderText" stepKey="validateBackgroundColorPlaceholderText">
83-
<argument name="property" value="PageBuilderBackgroundColor_Default"/>
84-
</actionGroup>
85-
<actionGroup ref="seeNoImageUploadedOnSlideOut" stepKey="validateNoBackgroundImage">
86-
<argument name="property" value="PageBuilderBackgroundImage_Default"/>
87-
</actionGroup>
88-
<actionGroup ref="seeNoImageUploadedOnSlideOut" stepKey="validateNoBackgroundMobileImage">
89-
<argument name="property" value="PageBuilderBackgroundMobileImage_Default"/>
76+
<actionGroup ref="validateBackgroundAttributesWithNoImageOrColor" stepKey="validateTab1BackgroundAttributesWithNoImageOrColor">
77+
<argument name="section" value="TabOnStage"/>
9078
</actionGroup>
91-
<seeElement selector="{{TabOnStage.tabContentBackgroundPosition('1', PageBuilderBackgroundPosition_Default.styleValue)}}" stepKey="seeTabBackgroundPositionAdmin1"/>
92-
<seeElement selector="{{TabOnStage.tabContentBackgroundSize('1', PageBuilderBackgroundSize_Default.value)}}" stepKey="seeTabBackgroundSizeAdmin1"/>
93-
<seeElement selector="{{TabOnStage.tabContentBackgroundAttachment('1', PageBuilderBackgroundAttachment_Default.value)}}" stepKey="seeTabBackgroundAttachmentAdmin1"/>
94-
<seeElement selector="{{TabOnStage.tabContentBackgroundRepeat('1', PageBuilderBackgroundRepeat_Disabled.styleValue)}}" stepKey="seeTab1StageBackgroundRepeatNo"/>
9579
<!-- User sees tab default min height to be 300 px on stage -->
9680
<comment userInput="User sees tab default min height to be 300 px on stage" stepKey="AC8"/>
9781
<seeElement selector="{{TabsOnStage.tabsContentMinHeight(PageBuilderTabsDefaultMinHeight.value)}}" stepKey="seeTabMinHeightAdmin1"/>
@@ -1019,7 +1003,7 @@
10191003
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundPosition1">
10201004
<argument name="property" value="PageBuilderBackgroundPosition_Center"/>
10211005
</actionGroup>
1022-
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundSize1">
1006+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectBackgroundSize1">
10231007
<argument name="property" value="PageBuilderBackgroundSize_Auto"/>
10241008
</actionGroup>
10251009
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateBackgroundAttachmentScroll">
@@ -1045,7 +1029,7 @@
10451029
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundPosition2">
10461030
<argument name="property" value="PageBuilderBackgroundPosition_Center"/>
10471031
</actionGroup>
1048-
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundSize2">
1032+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectBackgroundSize2">
10491033
<argument name="property" value="PageBuilderBackgroundSize_Contain"/>
10501034
</actionGroup>
10511035
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundAttachment2">
@@ -1397,7 +1381,7 @@
13971381
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundPosition1">
13981382
<argument name="property" value="PageBuilderBackgroundPosition_BottomLeft"/>
13991383
</actionGroup>
1400-
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundSize1">
1384+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectBackgroundSize1">
14011385
<argument name="property" value="PageBuilderBackgroundSize_Auto"/>
14021386
</actionGroup>
14031387
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateBackgroundAttachmentScroll">
@@ -1423,7 +1407,7 @@
14231407
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundPosition2">
14241408
<argument name="property" value="PageBuilderBackgroundPosition_BottomLeft"/>
14251409
</actionGroup>
1426-
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundSize2">
1410+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectBackgroundSize2">
14271411
<argument name="property" value="PageBuilderBackgroundSize_Contain"/>
14281412
</actionGroup>
14291413
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundAttachment2">
@@ -1543,7 +1527,7 @@
15431527
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundPosition1">
15441528
<argument name="property" value="PageBuilderBackgroundPosition_Center"/>
15451529
</actionGroup>
1546-
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundSize1">
1530+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectBackgroundSize1">
15471531
<argument name="property" value="PageBuilderBackgroundSize_Auto"/>
15481532
</actionGroup>
15491533
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundAttachment1">
@@ -1569,7 +1553,7 @@
15691553
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundPosition2">
15701554
<argument name="property" value="PageBuilderBackgroundPosition_Center"/>
15711555
</actionGroup>
1572-
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundSize2">
1556+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectBackgroundSize2">
15731557
<argument name="property" value="PageBuilderBackgroundSize_Contain"/>
15741558
</actionGroup>
15751559
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundAttachment2">
@@ -1677,7 +1661,7 @@
16771661
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateBackgroundAttachmentScroll">
16781662
<argument name="property" value="PageBuilderBackgroundAttachment_Scroll"/>
16791663
</actionGroup>
1680-
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundSize1">
1664+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectBackgroundSize1">
16811665
<argument name="property" value="PageBuilderBackgroundSize_Contain"/>
16821666
</actionGroup>
16831667
<actionGroup ref="seeOptionIsNotCheckedSlideOutProperty" stepKey="seeDefaultBackgroundRepeatProperty1">
@@ -1703,7 +1687,7 @@
17031687
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundAttachment2">
17041688
<argument name="property" value="PageBuilderBackgroundAttachment_Fixed"/>
17051689
</actionGroup>
1706-
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundSize2">
1690+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectBackgroundSize2">
17071691
<argument name="property" value="PageBuilderBackgroundSize_Auto"/>
17081692
</actionGroup>
17091693
<actionGroup ref="seeOptionIsNotCheckedSlideOutProperty" stepKey="seeDefaultBackgroundRepeatProperty2">
@@ -1822,7 +1806,7 @@
18221806
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateBackgroundAttachment1">
18231807
<argument name="property" value="PageBuilderBackgroundAttachment_Scroll"/>
18241808
</actionGroup>
1825-
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundSize1">
1809+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectBackgroundSize1">
18261810
<argument name="property" value="PageBuilderBackgroundSize_Contain"/>
18271811
</actionGroup>
18281812
<actionGroup ref="clickSlideOutPanelFieldGeneral" stepKey="clickBackgroundRepeatYes1">
@@ -1848,7 +1832,7 @@
18481832
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundAttachment2">
18491833
<argument name="property" value="PageBuilderBackgroundAttachment_Fixed"/>
18501834
</actionGroup>
1851-
<actionGroup ref="selectSlideOutPanelField" stepKey="selectBackgroundSize2">
1835+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectBackgroundSize2">
18521836
<argument name="property" value="PageBuilderBackgroundSize_Auto"/>
18531837
</actionGroup>
18541838
<actionGroup ref="clickSlideOutPanelFieldGeneral" stepKey="clickBackgroundRepeatYes2">
@@ -2146,6 +2130,7 @@
21462130
</actionGroup>
21472131
<actionGroup ref="validateBackgroundImage" stepKey="validateBackgroundImageStorefront">
21482132
<argument name="section" value="TabOnStorefront"/>
2133+
<argument name="pageNamePrefix" value="tab"/>
21492134
<argument name="backgroundImage" value="PageBuilderBackgroundImage_JPG"/>
21502135
</actionGroup>
21512136
<actionGroup ref="validateBackgroundAttributes" stepKey="validateStorefront">

0 commit comments

Comments
 (0)