Skip to content

Commit 3c31f96

Browse files
author
Michael Yu
committed
MC-407: Empty banner displays on store front as big empty area
- Fixed return typing on display converters
1 parent b85a6bc commit 3c31f96

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/banner/converter/style/display.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/banner/converter/style/preview/display.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/banner/converter/style/display.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ export default class Display implements ConverterInterface {
1111
* Convert value to internal format
1212
*
1313
* @param value string
14-
* @returns {string | object}
14+
* @returns {void}
1515
*/
16-
public fromDom(value: string): string | object {
16+
public fromDom(value: string): void {
1717
return;
1818
}
1919

@@ -22,9 +22,9 @@ export default class Display implements ConverterInterface {
2222
*
2323
* @param name string
2424
* @param data Object
25-
* @returns {string | DataObject}
25+
* @returns {string | void}
2626
*/
27-
public toDom(name: string, data: DataObject): string | object {
27+
public toDom(name: string, data: DataObject): string | void {
2828
if (
2929
data.background_color === ""
3030
&& data.background_image.length === 0

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/banner/converter/style/preview/display.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ export default class Display implements ConverterInterface {
1111
* Convert value to internal format
1212
*
1313
* @param value string
14-
* @returns {string | object}
14+
* @returns {void}
1515
*/
16-
public fromDom(value: string): string | object {
16+
public fromDom(value: string): void {
1717
return;
1818
}
1919

@@ -22,9 +22,9 @@ export default class Display implements ConverterInterface {
2222
*
2323
* @param name string
2424
* @param data DataObject
25-
* @returns {string | object}
25+
* @returns {void}
2626
*/
27-
public toDom(name: string, data: DataObject): string | object {
27+
public toDom(name: string, data: DataObject): void {
2828
return;
2929
}
3030
}

0 commit comments

Comments
 (0)