Skip to content

Commit 3bb2fbd

Browse files
committed
MC-3315: Banner/Slider: Image still display on Banner/Slider slide-out after deleted
- Partial fix
1 parent 7e7637f commit 3bb2fbd

File tree

3 files changed

+6
-22
lines changed

3 files changed

+6
-22
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/image/preview.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/form/element/image-uploader.js

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ define([
5858
this._super();
5959

6060
events.on('image:' + this.id +':assignAfter', this.onAssignedFile.bind(this));
61-
$(window).on('fileDeleted.mediabrowser', this.onDeleteFile.bind(this));
6261

6362
// bind dropzone highlighting using event delegation only once
6463
if (!initializedOnce) {
@@ -155,18 +154,12 @@ define([
155154

156155
/**
157156
* Trigger image:deleteFileAfter event to be handled by PageBuilder image component
158-
*
159-
* @param {jQuery.event} e
160-
* @param {Object} data
161-
* @returns {Object} Chainable
157+
* {inheritDoc}
162158
*/
163-
onDeleteFile: function (e, data) {
164-
var fileId = this.getFileId(),
165-
deletedFileIds = data.ids;
159+
clear: function () {
160+
this._super();
166161

167-
if (fileId && $.inArray(fileId, deletedFileIds) > -1) {
168-
events.trigger('image:' + this.id + ':deleteFileAfter');
169-
}
162+
events.trigger('image:' + this.id + ':deleteFileAfter');
170163

171164
return this;
172165
},
@@ -222,15 +215,6 @@ define([
222215
hasData: function() {
223216
// Some of the components automatically add an empty object if the value is unset.
224217
return this._super() && !$.isEmptyObject(this.value()[0]);
225-
},
226-
227-
/**
228-
* Gets the ID of the file used if set
229-
*
230-
* @return {string|null} ID
231-
*/
232-
getFileId: function() {
233-
return this.hasData() ? this.value()[0].id : null;
234218
}
235219
});
236220
});

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/image/preview.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export default class Preview extends BasePreview {
4646
// Create uploader
4747
this.uploader = new Uploader(
4848
this.parent.id,
49-
"imageuploader_" + this.parent.id,
49+
"myimageuploader_" + this.parent.id,
5050
Object.assign({}, this.config.additional_data.uploaderConfig, {
5151
value: initialImageValue,
5252
}),

0 commit comments

Comments
 (0)