Skip to content

Commit 3ad4f53

Browse files
committed
Merge remote-tracking branch 'origin/MC-1420' into MC-1420
2 parents 0a3be24 + 3744ff3 commit 3ad4f53

File tree

3 files changed

+17
-14
lines changed

3 files changed

+17
-14
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderBlockSection.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
1010
xsi:noNamespaceSchemaLocation="../../../../../../../dev/tests/acceptance/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Page/etc/SectionObject.xsd">
1111
<section name="BlockOnStage">
12-
<element name="html" type="text" selector="(//div[contains(@class,'pagebuilder-block')]//div[contains(@data-bind,'html: data.main.html')])[{{arg1}}]{{arg2}}" parameterized="true"/>
12+
<element name="html" type="text" selector="(//div[contains(@class,'pagebuilder-block')]//div[contains(@data-bind,'html: data.main.html')])[{{arg1}}]//a[contains(@class,'pagebuilder-button-primary')]" parameterized="true"/>
1313
<element name="status" type="text" selector="(//div[contains(@class,'pagebuilder-block')]//span[contains(@class,'placeholder') and text()='{{arg}}'])" parameterized="true"/>
1414
<element name="deleted" type="text" selector="(//div[contains(@class,'pagebuilder-block')]//span[contains(@class,'placeholder') and contains(text(),'Block with ID: {{arg}} doesn')])" parameterized="true"/>
1515
<element name="title" type="text" selector="(//div[contains(@class,'pagebuilder-block')])[1]//div[contains(@class,'pagebuilder-options-wrapper')]//div[contains(@class,'option-title') and text()='{{arg}}']" parameterized="true"/>
@@ -40,7 +40,7 @@
4040
<element name="title" type="text" selector="(//div[contains(@class,'pagebuilder-block')]//div[contains(@class,'block-title') and text()='{{arg1}}'])" parameterized="true"/>
4141
</section>
4242
<section name="BlockOnStorefront">
43-
<element name="html" type="text" selector="(//div[@data-role='block'])[{{arg1}}]{{arg2}}" parameterized="true"/>
43+
<element name="html" type="text" selector="(//div[@data-role='html'])[{{arg1}}]//a[contains(@class,'pagebuilder-button-primary')]" parameterized="true"/>
4444
<element name="base" type="text" selector="(//div[@data-role='row']/div)[{{arg1}}]" parameterized="true"/>
4545
<element name="hr" type="button" selector="(//div[@data-role='row']/div)[{{arg1}}]/hr" parameterized="true"/>
4646
<!-- Advanced Configuration -->

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockTest.xml

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
xsi:noNamespaceSchemaLocation="../../../../../../../dev/tests/acceptance/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Test/etc/testSchema.xsd">
1111
<test name="InitialStatusBlock">
1212
<annotations>
13-
<features value="Pagebuilder: Block"/>
14-
<stories value="MC-1420: Static Block"/>
13+
<features value="Pagebuilder"/>
14+
<stories value="Block"/>
1515
<title value="Block - Initial Status"/>
1616
<description value="Verify that Static Block is refactor and new Block preview is applied."/>
1717
<severity value="CRITICAL"/>
@@ -43,8 +43,8 @@
4343
</test>
4444
<test name="AddBlockToCmsPage">
4545
<annotations>
46-
<features value="Pagebuilder: Block"/>
47-
<stories value="MC-1420: Static Block"/>
46+
<features value="Pagebuilder"/>
47+
<stories value="Block"/>
4848
<title value="Add Block to CMS Page"/>
4949
<description value="Verify that admin are able to add a block instance to Block Content Block and see it on frontend"/>
5050
<severity value="CRITICAL"/>
@@ -97,7 +97,7 @@
9797
<test name="BlockGetUpdated">
9898
<annotations>
9999
<features value="Pagebuilder"/>
100-
<stories value="MC-1420: (Magento) Block Configuration"/>
100+
<stories value="Block"/>
101101
<title value="Block Content Block get updated"/>
102102
<description value="Verify that Block Content Block get updated from Block entities"/>
103103
<severity value="CRITICAL"/>
@@ -151,7 +151,7 @@
151151
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage2">
152152
<argument name="contentType" value="PageBuilderHtmlContentType"/>
153153
</actionGroup>
154-
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterHtmlContent">
154+
<actionGroup ref="fillSlideOutPanelTextArea" stepKey="enterHtmlContent">
155155
<argument name="property" value="PageBuilderHtmlPropertyButton"/>
156156
</actionGroup>
157157
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings2"/>
@@ -163,22 +163,23 @@
163163
<comment userInput="Validate stage after updating block" stepKey="validateStage2" />
164164
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
165165
<waitForElementVisible selector="{{HtmlOnStage.base('1')}}" stepKey="waitForHtmlBaseStage1"/>
166-
<waitForElementVisible selector="{{BlockOnStage.html('1', PageBuilderHtmlPropertyButton.selector)}}" stepKey="waitForHtmlStage1"/>
166+
<waitForElementVisible selector="{{BlockOnStage.html('1')}}" stepKey="waitForHtmlStage1"/>
167167
<actionGroup ref="ClearCacheActionGroup" stepKey="clearMagentoCache"/>
168168
<!-- Validate Storefront -->
169169
<comment userInput="Validate storefront after updating block" stepKey="validateStorefront2" />
170170
<amOnPage url="$$createCMSPage.identifier$$" stepKey="amOnPageTestPage"/>
171171
<waitForElementVisible selector="{{HtmlOnStorefront.base('1')}}" stepKey="waitForHtmlBaseStorefront"/>
172-
<waitForElementVisible selector="{{HtmlOnStorefront.html('1', PageBuilderHtmlPropertyButton.selector)}}" stepKey="waitForHtmlStorefront"/>
172+
<waitForElementVisible selector="{{BlockOnStorefront.html('1')}}" stepKey="waitForHtmlStorefront"/>
173173
</test>
174174
<test name="VerifyBlockDisabled">
175175
<annotations>
176-
<features value="Pagebuilder: Block"/>
177-
<stories value="MC-1420: Static Block"/>
176+
<features value="Pagebuilder"/>
177+
<stories value="Block"/>
178178
<title value="Block - Verify disabled block does not show on the stage or on storefront" />
179179
<description value="Verify that disabled block instance is not rendered on the stage or on the storefront" />
180180
<severity value="CRITICAL" />
181181
<testCaseId value="MC-2288" />
182+
<useCaseId value="MC-1420"/>
182183
<group value="pagebuilder" />
183184
<group value="pagebuilder-block" />
184185
</annotations>
@@ -234,11 +235,12 @@
234235
<test name="BlockDelete">
235236
<annotations>
236237
<features value="Pagebuilder"/>
237-
<stories value="MAGETWO-83941: Static Block"/>
238+
<stories value="Block"/>
238239
<title value="Block - Delete Block"/>
239240
<description value="A user should be able to delete an Block content type. Verify on Stage amd Storefront."/>
240241
<severity value="CRITICAL"/>
241242
<testCaseId value="MC-2848"/>
243+
<useCaseId value="MC-1420"/>
242244
<group value="pagebuilder"/>
243245
<group value="pagebuilder-block"/>
244246
<group value="pagebuilder-customBeforeAfter"/>
@@ -272,7 +274,7 @@
272274
<test name="DisplayingDeletedBlockOnStage">
273275
<annotations>
274276
<features value="Pagebuilder"/>
275-
<stories value="Static Block"/>
277+
<stories value="Block"/>
276278
<title value="Block - Displaying deleted block on Stage"/>
277279
<description value="A user should be able to see that block is deleted on Stage."/>
278280
<severity value="CRITICAL"/>

dev/tests/integration/_files/Magento/TestModulePageBuilderExtensionPoints/registration.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
declare(strict_types=1);
67

78
use Magento\Framework\Component\ComponentRegistrar;
89

0 commit comments

Comments
 (0)