Skip to content

Commit 3a59a57

Browse files
committed
MC-3398: Create/update MFTF tests for vertical alignment in tab item
- rename action group - fix index - add work-around for mftf hyphen bug
1 parent 7616227 commit 3a59a57

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/LayoutConfigurationActionGroup.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,15 @@
88

99
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
1010
xsi:noNamespaceSchemaLocation="../../../../../../../dev/tests/acceptance/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Test/etc/actionGroupSchema.xsd">
11-
<actionGroup name="validateLayoutStylesDefault">
11+
<actionGroup name="validateLayoutStylesNoHeight">
1212
<arguments>
1313
<argument name="page"/>
1414
<argument name="index" defaultValue="1" type="string"/>
15-
<argument name="style"/>
1615
<argument name="verticalAlignContainer" defaultValue="PageBuilderVerticalAlignmentPropertyTop"/>
1716
</arguments>
1817
<waitForElement selector="{{page.container(index)}}" stepKey="waitForVerticalAlignContainer"/>
19-
<dontSeeElement selector="{{page.containerStyle('1', style)}}" stepKey="dontSeeStyle"/>
20-
<seeElement selector="{{page.containerStyle('1', verticalAlignContainer.style)}}" stepKey="seeVerticalAlignmentStyle"/>
18+
<dontSeeElement selector="{{page.containerStyle(index, PageBuilderMinHeightProperty_Empty.style)}}" stepKey="dontSeeStyle"/>
19+
<seeElement selector="{{page.containerStyle(index, verticalAlignContainer.style)}}" stepKey="seeVerticalAlignmentStyle"/>
2120
</actionGroup>
2221
<!-- Validate All Layout Styles -->
2322
<actionGroup name="validateLayoutStylesWithAllUpdated">

app/code/Magento/PageBuilder/Test/Mftf/Data/CommonContentTypeData.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
<data key="section">layout</data>
1515
<data key="fieldName">min_height</data>
1616
<data key="value"/>
17+
<data key="style">min-height</data>
1718
</entity>
1819
<entity name="PageBuilderMinHeightProperty_500" type="pagebuilder_min_height_property">
1920
<data key="name">Minimum Height</data>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabLayoutTest.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,20 +60,18 @@
6060
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettingsThirdColumn"/>
6161
<!-- Verify Min Height Not Used and Vertical Alignment On Stage - Before Save -->
6262
<comment userInput="Verify min height not used and vertical alignment on stage before save" stepKey="commentVerifyMinHeightAndVerticalAlignmentOnStageBeforeSave"/>
63-
<actionGroup ref="validateLayoutStylesDefault" stepKey="validateLayoutStylesBeforeSave">
63+
<actionGroup ref="validateLayoutStylesNoHeight" stepKey="validateLayoutStylesBeforeSave">
6464
<argument name="page" value="TabOnStage"/>
6565
<argument name="index" value="1"/>
66-
<argument name="style" value="min-height"/>
6766
<argument name="verticalAlignContainer" value="PageBuilderVerticalAlignmentPropertyTop"/>
6867
</actionGroup>
6968
<!-- Verify Min Height Not Used and Vertical Alignment On Stage - After Save -->
7069
<comment userInput="Verify min height not used and vertical alignment on stage after save" stepKey="commentVerifyMinHeightAndVerticalAlignmentOnStageAfterSave"/>
7170
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
7271
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
73-
<actionGroup ref="validateLayoutStylesDefault" stepKey="validateLayoutStylesAfterSave">
72+
<actionGroup ref="validateLayoutStylesNoHeight" stepKey="validateLayoutStylesAfterSave">
7473
<argument name="page" value="TabOnStage"/>
7574
<argument name="index" value="1"/>
76-
<argument name="style" value="min-height"/>
7775
<argument name="verticalAlignContainer" value="PageBuilderVerticalAlignmentPropertyTop"/>
7876
</actionGroup>
7977
<!-- Verify Min Height Not Used and Vertical Alignment In Form - After Save -->

0 commit comments

Comments
 (0)