Skip to content

Commit 3919a97

Browse files
committed
Merge branch 'MC-5423-staging-issues' of github.com:magento-obsessive-owls/magento2-page-builder into cms-team-1-delivery
2 parents 9f18da0 + fed5e88 commit 3919a97

29 files changed

+396
-1814
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderStageSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<section name="PageBuilderStage">
1212
<element name="imageSource" type="text" selector="//img[contains(@src,'{{var1}}')]" parameterized="true"/>
1313
<element name="openFullScreen" type="button" selector="//i[@class='icon-pagebuilder-fullscreen']"/>
14-
<element name="exitFullScreen" type="button" selector=".pagebuilder-header .action-close"/>
14+
<element name="exitFullScreen" type="button" selector=".pagebuilder-header .icon-pagebuilder-fullscreen-exit"/>
1515
<element name="stageLoading" type="button" selector="div.pagebuilder-stage-loading"/>
1616
<element name="stageWrapper" type="button" selector="//div[@class='pagebuilder-stage-wrapper']"/>
1717
<element name="enabled" type="button" selector="//div[not(contains(@class, '_disabled'))]/div[contains(@class, 'pagebuilder-wysiwyg-wrapper')]/div[@class='pagebuilder-stage-wrapper']"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderPanelTest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -437,6 +437,7 @@
437437
<argument name="contentType" value="PageBuilderRowContentType"/>
438438
</actionGroup>
439439
<click selector="{{PageBuilderStage.openFullScreen}}" stepKey="enterFullScreen"/>
440+
<waitForElementVisible selector="{{PageBuilderStage.exitFullScreen}}" stepKey="waitForExitVisible"/>
440441
<scrollTo selector="{{RowOnStage.base('6')}}" stepKey="scrollToBottom"/>
441442
<seeElement selector="{{PageBuilderStage.exitFullScreen}}" stepKey="verifyHeader"/>
442443
</test>

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/_page-builder.less

Lines changed: 30 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
@border-size: 2px;
77

88
.pagebuilder-header {
9+
margin-bottom: 15px;
910
text-align: right;
1011

1112
> .icon-pagebuilder-fullscreen {
@@ -23,14 +24,20 @@
2324
}
2425

2526
.pagebuilder-stage-wrapper {
27+
-moz-transition: .35s ease-in-out;
28+
-webkit-transition: .35s ease-in-out;
29+
background: @color-white;
2630
position: relative;
31+
transition: .35s ease-in-out;
2732

2833
._disabled & {
2934
opacity: .5;
3035
pointer-events: none;
3136
}
3237

3338
&.stage-full-screen {
39+
-moz-transform: translateZ(0);
40+
-webkit-transform: translateZ(0);
3441
background: @color-white;
3542
height: 100%;
3643
left: 0;
@@ -39,10 +46,12 @@
3946
padding: 0;
4047
position: fixed;
4148
top: 0;
49+
transform: translateZ(0);
4250
width: 100%;
4351
z-index: 800;
4452

4553
.pagebuilder-header {
54+
float: right;
4655
height: 0;
4756
padding: 0;
4857
position: fixed;
@@ -53,11 +62,12 @@
5362
width: auto;
5463
z-index: 101;
5564

56-
.action-close {
65+
.icon-pagebuilder-fullscreen-exit {
5766
background: rgba(255,255,255,.8);
5867
border: none;
5968
border-radius: 0;
6069
box-shadow: none;
70+
cursor: pointer;
6171
display: inline-block;
6272
margin: 0;
6373
padding: 15px 20px;
@@ -113,8 +123,8 @@
113123
.pagebuilder-header {
114124
.pagebuilder-stage-wrapper.stage-full-screen.pagebuilder-header;
115125

116-
.action-close {
117-
.pagebuilder-stage-wrapper.stage-full-screen.pagebuilder-header.action-close;
126+
.icon-pagebuilder-fullscreen-exit {
127+
.pagebuilder-stage-wrapper.stage-full-screen.pagebuilder-header.icon-pagebuilder-fullscreen-exit;
118128
}
119129
}
120130
}
@@ -124,53 +134,30 @@
124134
-moz-transition: .175s ease-in-out;
125135
-webkit-transition: .175s ease-in-out;
126136
opacity: 0;
127-
transform: scale(.8);
137+
transform: scale(.8) translateZ(0);
128138
transition: .175s ease-in-out;
129139
visibility: hidden;
130140
}
131141

132142
&.trigger-transition .pagebuilder-stage-wrapper {
133143
opacity: 1;
134-
transform: scale(1);
144+
transform: scale(1) translateZ(0);
135145
visibility: visible;
136146
}
137147
}
138148

139-
.pagebuilder-add-row-wrapper {
140-
float: left;
141-
text-align: center;
142-
width: 100%;
143-
144-
.pagebuilder-add-row {
145-
-moz-border-radius: 5px;
146-
-webkit-border-radius: 5px;
147-
148-
background: @row-color;
149-
border-radius: 5px;
150-
color: @color-white;
151-
display: inline-block;
152-
font-size: 26px;
153-
height: 50px;
154-
line-height: 50px;
155-
width: 50px;
156-
157-
&:hover {
158-
background: darken(@row-color, 15%);
159-
}
160-
}
161-
}
162-
163149
.pagebuilder-stage {
164-
-moz-user-select: none; /* Firefox */
165-
-ms-user-select: none; /* IE10+ */
166-
/* Rules below not implemented in browsers yet */
150+
-moz-transition: margin-left .35s ease-in-out;
151+
-moz-user-select: none;
152+
-ms-user-select: none;
167153
-o-user-select: none;
168-
-webkit-user-select: none; /* Chrome/Safari */
169-
154+
-webkit-transition: margin-left .35s ease-in-out;
155+
-webkit-user-select: none;
170156
font-size: 0;
171-
margin-left: 170px; // temp
157+
margin-left: 170px;
172158
min-height: 200px;
173-
padding: 0 0 60px; // 60px to include the add row button
159+
padding: 0;
160+
transition: margin-left .35s ease-in-out;
174161
user-select: none;
175162

176163
&.stage-full-screen {
@@ -179,12 +166,10 @@
179166

180167
&.pagebuilder-no-user-select {
181168
* {
182-
-moz-user-select: none !important; /* Firefox */
183-
-ms-user-select: none !important; /* IE10+ */
184-
185-
/* Rules below not implemented in browsers yet */
169+
-moz-user-select: none !important;
170+
-ms-user-select: none !important;
186171
-o-user-select: none !important;
187-
-webkit-user-select: none !important; /* Chrome/Safari */
172+
-webkit-user-select: none !important;
188173
user-select: none !important;
189174
}
190175
}
@@ -205,11 +190,11 @@
205190
}
206191

207192
.pagebuilder-canvas {
208-
-moz-transition: opacity .75s ease-in-out, visibility .75s ease-in-out;
209-
-webkit-transition: opacity .75s ease-in-out, visibility .75s ease-in-out;
193+
-moz-transition: opacity .75s ease-in-out, visibility .75s ease-in-out, padding-top .35s ease-in-out;
194+
-webkit-transition: opacity .75s ease-in-out, visibility .75s ease-in-out, padding-top .35s ease-in-out;
210195
opacity: 0;
211-
padding-bottom: 60px;
212-
transition: opacity .75s ease-in-out, visibility .75s ease-in-out;
196+
padding-bottom: 120px;
197+
transition: opacity .75s ease-in-out, visibility .75s ease-in-out, padding-top .35s ease-in-out;
213198
visibility: hidden;
214199

215200
&.active {

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/_panel.less

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,17 @@
5252
float: left;
5353
opacity: 0;
5454
position: relative;
55+
position: -webkit-sticky;
56+
position: sticky;
57+
top: 87px;
5558
transition: opacity .75s ease-in-out, visibility .75s ease-in-out;
5659
visibility: hidden;
5760
width: 150px;
5861

62+
&.no-position-sticky {
63+
top: 0;
64+
}
65+
5966
&.visible {
6067
opacity: 1;
6168
visibility: visible;
@@ -103,15 +110,14 @@
103110
}
104111

105112
.pagebuilder-panel {
106-
-moz-transition: .4s;
107-
-moz-user-select: none; /* Firefox */
108-
-ms-user-select: none; /* IE10+ */
109-
/* Rules below not implemented in browsers yet */
113+
-moz-transition: .35s ease-in-out opacity, .35s ease-in-out visibility, .35s ease-in-out height;
114+
-moz-user-select: none;
115+
-ms-user-select: none;
110116
-o-user-select: none;
111-
-webkit-transition: .4s;
112-
-webkit-user-select: none; /* Chrome/Safari */
117+
-webkit-transition: .35s ease-in-out opacity, .35s ease-in-out visibility, .35s ease-in-out height;
118+
-webkit-user-select: none;
113119
background: @color-very-dark-grayish-orange;
114-
transition: .4s;
120+
transition: .35s ease-in-out opacity, .35s ease-in-out visibility, .35s ease-in-out height;
115121
user-select: none;
116122

117123
.search-results-empty {
@@ -210,18 +216,6 @@
210216
speak: none;
211217
}
212218
}
213-
&.full-screen {
214-
cursor: pointer;
215-
float: right;
216-
margin-right: 4px;
217-
218-
&:before {
219-
content: @icon-pagebuilder-fullscreen__content;
220-
font-family: @icon_font;
221-
line-height: 1;
222-
speak: none;
223-
}
224-
}
225219
}
226220
}
227221
}
@@ -312,3 +306,7 @@
312306
}
313307
}
314308
}
309+
310+
.modal-slide .modal-content .pagebuilder-panel-wrapper {
311+
top: 10px;
312+
}

app/code/Magento/PageBuilder/view/adminhtml/web/fonts/pagebuilder-icons/pagebuilder-icons.svg

Lines changed: 2 additions & 2 deletions
Loading

0 commit comments

Comments
 (0)