#557: User Access Row Action Panel with 2+ Level Nesting

- Code Review Feedback/Amends

Author: bluemwhitew

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeContainerActionGroup/VerifyAffordanceSizeActionGroup.xml

@@ -11,13 +11,13 @@
             <description>Verifies the size of the affordance on Container content types.</description>
         </annotations>
         <arguments>
-            <argument name="affordanceSize" defaultValue="{{PageBuilderRowAffordanceWidth.borderWidth}}" type="string"/>
+            <argument name="expectedAffordanceSize" defaultValue="{{PageBuilderRowAffordanceWidth.borderWidth}}" type="string"/>
             <argument name="index" defaultValue="1" type="string"/>
             <argument name="section" defaultValue="RowOnStage"/>
         </arguments>
-        <waitForElementVisible selector="{{section.affordance(index)}}" stepKey="waitForElementVisible"/>
-        <executeJS function="return parseInt(window.getComputedStyle({{section.affordanceJS(index)}}).borderWidth, 10)" stepKey="executeJS"/>
-        <assertEquals stepKey="assertEquals">
+        <waitForElementVisible selector="{{section.affordance(index)}}" stepKey="waitForAffordanceVisible"/>
+        <executeJS function="return parseInt(window.getComputedStyle({{section.affordanceJS(index)}}).borderWidth, 10)" stepKey="actualAffordanceSize"/>
+        <assertEquals stepKey="assertActualAffordanceSizeEqualsExpected">
             <expectedResult type="int">{{affordanceSize}}</expectedResult>
             <actualResult type="variable">executeJS</actualResult>
         </assertEquals>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderRowSection/RowOnStorefrontSection.xml

@@ -11,8 +11,6 @@
         <element name="base" type="text" selector="(//div[@data-content-type=&quot;row&quot;])[{{arg1}}]/div" parameterized="true"/>
         <element name="baseCSS" type="text" selector="[data-content-type=row]"/>
         <element name="baseJS" type="text" selector="(document.querySelectorAll('[data-content-type=row]')[{{arg1}} - 1]).querySelector('div')" parameterized="true"/>
-        <element name="affordance" type="text" selector="(//div[contains(@class,'pagebuilder-affordance-row') and contains(@class,'pagebuilder-content-type')])[{{arg1}}]" parameterized="true"/>
-        <element name="affordanceCSS" type="text" selector="div.pagebuilder-affordance-row.pagebuilder-content-type"/>
         <element name="elementChildren" type="text" selector="(//div[@data-content-type=&quot;row&quot;])[{{arg1}}]/div" parameterized="true"/>
         <element name="innerCSS" type="text" selector="[data-content-type=row] [data-element=inner]"/>
         <element name="inner" type="text" selector="(//div[@data-content-type=&quot;row&quot;])[{{arg1}}]//div[@data-element=&quot;inner&quot;]" parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderContainerTest/PageBuilderVerifyContainerAffordanceTest.xml

@@ -31,6 +31,7 @@
             <deleteData createDataKey="createCMSPage" stepKey="deleteCMSPage"/>
             <actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
         </after>
+        <!-- Configure CMS Block -->
         <actionGroup ref="expandPageBuilderPanelMenuSection" stepKey="expandPageBuilderPanelMenuSection">
             <argument name="contentType" value="PageBuilderColumnContentType"/>
         </actionGroup>
@@ -70,6 +71,7 @@
         <seeNumberOfElements selector="{{RowOnStage.affordanceCSS}}" userInput="3" stepKey="seeNumberOfAffordance"/>
         <actionGroup ref="exitPageBuilderFullScreen" stepKey="exitPageBuilderFullScreen"/>
         <actionGroup ref="SaveCMSBlockActionGroup" stepKey="saveCMSBlock"/>
+        <!-- Configure CMS Page -->
         <actionGroup ref="NavigateToCreatedCMSPageActionGroup" stepKey="navigateToCreatedCMSPage">
             <argument name="CMSPage" value="$$createCMSPage$$"/>
         </actionGroup>
@@ -96,6 +98,6 @@
         <actionGroup ref="NavigateToStorefrontForCreatedPageActionGroup" stepKey="navigateToStorefrontForCreatedPage">
             <argument name="page" value="$$createCMSPage.identifier$$"/>
         </actionGroup>
-        <dontSeeElementInDOM selector="{{RowOnStorefront.affordanceCSS}}" stepKey="dontSeeAffordanceInDOM"/>
+        <dontSeeElementInDOM selector="{{RowOnStage.affordanceCSS}}" stepKey="dontSeeAffordanceInDOM"/>
     </test>
 </tests>