Skip to content

Commit 385997f

Browse files
committed
MC-4294: Cannot Activate Tab Item After Moving Tabs or Slider to New Parent Container
Remove one-off variable naming
1 parent ba6d8af commit 385997f

File tree

2 files changed

+3
-6
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml/web

2 files changed

+3
-6
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slider/preview.js

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slider/preview.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -176,10 +176,8 @@ export default class Preview extends PreviewCollection {
176176
public afterChildrenRender(element: HTMLElement): void {
177177
this.element = element;
178178

179-
const isARerenderingOfSlider = this.ready;
180-
181179
// if slider has been re-rendered previously on this element, re-build
182-
if (isARerenderingOfSlider) {
180+
if (this.ready) {
183181
this.buildSlick();
184182
}
185183

0 commit comments

Comments
 (0)