Merge pull request #315 from adobe-commerce-tier-4/PR-03-12-2024-anna

[Support Tier-4 abukatar] 03-12-2024 Regular delivery of bugfixes and improvements

Author: internal-magento-queue-manager[bot]

app/code/Magento/PageBuilder/view/adminhtml/web/js/form/element/html.js

@@ -59,24 +59,28 @@ define([
                 name;
 
             this.elements.forEach(function (item) {
+                if (!$.contains(document.documentElement, item)) {
+                    // item was removed
+                    return;
+                }
                 switch (item.type) {
-                    case 'checkbox':
-                        result[item.name] = +!!item.checked;
-                        break;
+                case 'checkbox':
+                    result[item.name] = +!!item.checked;
+                    break;
 
-                    case 'radio':
-                        if (item.checked) {
-                            result[item.name] = item.value;
-                        }
-                        break;
+                case 'radio':
+                    if (item.checked) {
+                        result[item.name] = item.value;
+                    }
+                    break;
 
-                    case 'select-multiple':
-                        name = item.name.substring(0, item.name.length - 2); //remove [] from the name ending
-                        result[name] = _.pluck(item.selectedOptions, 'value');
-                        break;
+                case 'select-multiple':
+                    name = item.name.substring(0, item.name.length - 2); //remove [] from the name ending
+                    result[name] = _.pluck(item.selectedOptions, 'value');
+                    break;
 
-                    default:
-                        result[item.name] = item.value;
+                default:
+                    result[item.name] = item.value;
                 }
             });
 

dev/tests/js/jasmine/tests/app/code/Magento/PageBuilder/adminhtml/web/js/form/element/html.test.js

@@ -0,0 +1,75 @@
+/************************************************************************
+ *
+ * Copyright 2024 Adobe
+ * All Rights Reserved.
+ *
+ * NOTICE: All information contained herein is, and remains
+ * the property of Adobe and its suppliers, if any. The intellectual
+ * and technical concepts contained herein are proprietary to Adobe
+ * and its suppliers and are protected by all applicable intellectual
+ * property laws, including trade secret and copyright laws.
+ * Dissemination of this information or reproduction of this material
+ * is strictly forbidden unless prior written permission is obtained
+ * from Adobe.
+ * ************************************************************************
+ */
+
+/* eslint-disable max-nested-callbacks */
+define([
+    'Magento_PageBuilder/js/form/element/html',
+], function (HtmlUiElement) {
+    'use strict';
+
+    describe('Magento_PageBuilder/js/form/element/html', function () {
+        var model,
+            htmlContainer,
+            formId = 'form-' + Date.now();
+
+        function addNewElement(name, value) {
+            var newElement = document.createElement('li'),
+                inputElement = document.createElement('input');
+
+            inputElement.setAttribute('name', name);
+            inputElement.setAttribute('type', 'hidden');
+            inputElement.setAttribute('data-form-part', formId);
+            inputElement.value = value;
+            newElement.appendChild(inputElement);
+            htmlContainer.appendChild(newElement);
+            model.elements.push(inputElement);
+            return inputElement;
+        }
+
+        beforeEach(function () {
+            model = new HtmlUiElement({inputSelector: '[data-form-part=' + formId + ']'});
+            htmlContainer = document.createElement('ul');
+            document.body.appendChild(htmlContainer);
+        });
+
+        afterEach(function () {
+            document.body.removeChild(htmlContainer);
+            model = null;
+            htmlContainer = null;
+        });
+
+        describe('"updateValue" method', function () {
+            it('Should collect all inputs values', function () {
+                var param1, param2;
+
+                model.updateValue();
+                expect(model.value()).toEqual({});
+                param1 = addNewElement('param1', 'value1');
+                model.updateValue();
+                expect(model.value()).toEqual({param1: 'value1'});
+                param2 = addNewElement('param2', 'value2');
+                model.updateValue();
+                expect(model.value()).toEqual({param1: 'value1', param2: 'value2'});
+                param2.value = 'value22';
+                model.updateValue();
+                expect(model.value()).toEqual({param1: 'value1', param2: 'value22'});
+                param1.remove();
+                model.updateValue();
+                expect(model.value()).toEqual({param2: 'value22'});
+            });
+        });
+    });
+});