Skip to content

Commit 369bd00

Browse files
author
Hwashiang Yu
committed
MC-4959: Need to remove is_hideable option from content type configuration
- Resolved minor typescript formatting issue - Updated button item test
1 parent 669900a commit 369bd00

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderButtonItemTests.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1254,7 +1254,7 @@
12541254
<description value="Validate button item has no hide / show capabilities"/>
12551255
<severity value="CRITICAL"/>
12561256
<useCaseId value="MC-4959"/>
1257-
<testCaseId value="MC-5780"/>
1257+
<testCaseId value="MC-3547"/>
12581258
<group value="pagebuilder"/>
12591259
<group value="pagebuilder-buttons"/>
12601260
<group value="pagebuilder-buttonItem"/>
@@ -1274,7 +1274,8 @@
12741274
<actionGroup ref="dragContentTypeToStage" stepKey="dragButtonsIntoStage">
12751275
<argument name="contentType" value="PageBuilderButtonsContentType"/>
12761276
</actionGroup>
1277-
<click selector="{{ButtonItemOnStage.base('1')}}" stepKey="clickButtonItem"/>
1277+
<click selector="ButtonItemOnStage.openOptionsMenu('1')" stepKey="clickButtonItem"/>
1278+
<waitForPageLoad stepKey="waitForPageLoad"/>
12781279
<waitForElementVisible selector="{{ButtonItemOnStage.optionsMenu('1')}}" stepKey="waitForButtonItemOptionsMenuVisible"/>
12791280
<dontSeeElementInDOM selector="{{PageBuilderContentTypeOptionsMenu.contentTypeHide(PageBuilderButtonItemContentType.role, '1')}}" stepKey="dontSeeDomHideOption" />
12801281
</test>

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/banner/preview.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ export default class Preview extends BasePreview {
5656

5757
return options;
5858
}
59+
5960
/**
6061
* Get registry callback reference to uploader UI component
6162
*

0 commit comments

Comments
 (0)