Skip to content

Commit 3673ee7

Browse files
cspruiellcspruiell
committed
MC-4254: Text Height Inconsistency On Stage & Storefront
 - add tests for text height in block & dynamic block
1 parent 2a044ee commit 3673ee7

File tree

2 files changed

+86
-1
lines changed

2 files changed

+86
-1
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderBlockSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,5 +64,6 @@
6464
<element name="noCssClasses" type="text" selector="(//div[@data-role='row'])[{{arg1}}]/div[not(@class)]" parameterized="true"/>
6565
<element name="margins" type="text" selector="(//div[@data-role='block'])[{{arg1}}][contains(@style,'margin: {{arg2}}px;')]" parameterized="true"/>
6666
<element name="padding" type="text" selector="(//div[@data-role='block'])[{{arg1}}][contains(@style,'padding: {{arg2}}px;')]" parameterized="true"/>
67+
<element name="text" type="text" selector="(//div[@data-role='block'])[{{arg1}}]//div[@data-role='text'][{{arg2}}]" parameterized="true"/>
6768
</section>
6869
</sections>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml

Lines changed: 85 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2664,7 +2664,7 @@
26642664
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup1">
26652665
<argument name="group" value="PageBuilderTextContentType"/>
26662666
</actionGroup>
2667-
<actionGroup ref="dragContentTypeToStage" stepKey="dragButtonsOntoStage">
2667+
<actionGroup ref="dragContentTypeToStage" stepKey="dragTextOntoStage">
26682668
<argument name="contentType" value="PageBuilderTextContentType"/>
26692669
</actionGroup>
26702670
<!--Input text into stage-->
@@ -2687,4 +2687,88 @@
26872687
<actualResult type="variable">getStageAndStorefrontHeightDifference</actualResult>
26882688
</assertLessThanOrEqual>
26892689
</test>
2690+
<test name="TextHeightConsistencyBetweenContentTypeAndBlockOnStorefront">
2691+
<annotations>
2692+
<features value="PageBuilder"/>
2693+
<stories value="Text"/>
2694+
<title value="Height consistency of text in PageBuilder storefront"/>
2695+
<description value="Verify text height consistent whether in text content type or text content type inside block"/>
2696+
<severity value="AVERAGE"/>
2697+
<useCaseId value="MC-4254"/>
2698+
<testCaseId value="MC-13792"/>
2699+
<group value="pagebuilder"/>
2700+
<group value="pagebuilder-text"/>
2701+
<group value="pagebuilder-block"/>
2702+
</annotations>
2703+
<before>
2704+
<createData entity="_defaultBlock" stepKey="createPreReqBlock" />
2705+
<createData entity="_defaultCmsPage" stepKey="createCMSPage" />
2706+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2707+
</before>
2708+
<after>
2709+
<deleteData createDataKey="createPreReqBlock" stepKey="deletePreReqBlock" />
2710+
<deleteData createDataKey="createCMSPage" stepKey="deletePreReqCMSPage" />
2711+
<actionGroup ref="logout" stepKey="logout"/>
2712+
</after>
2713+
<actionGroup ref="navigateToCreatedCMSBlockPage" stepKey="navigateToCreatedCmsBlock">
2714+
<argument name="CMSBlockPage" value="$$createPreReqBlock$$"/>
2715+
</actionGroup>
2716+
<!-- Update block with text -->
2717+
<comment userInput="Update block with text" stepKey="commentUpdateBlockWithText"/>
2718+
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandGroupForText1">
2719+
<argument name="group" value="PageBuilderTextContentType"/>
2720+
</actionGroup>
2721+
<actionGroup ref="dragContentTypeToStage" stepKey="dragTextOntoBlockStage">
2722+
<argument name="contentType" value="PageBuilderTextContentType"/>
2723+
</actionGroup>
2724+
<actionGroup ref="inlineEditWYSIWYGFromStage" stepKey="inlineEditBlockText">
2725+
<argument name="contentType" value="PageBuilderTextContentType"/>
2726+
<argument name="content" value="{{PageBuilderTextProperty.value}}"/>
2727+
</actionGroup>
2728+
<click selector="{{CmsNewBlockBlockActionsSection.savePage}}" stepKey="saveBlock"/>
2729+
<actionGroup ref="navigateToCreatedCMSPage" stepKey="navigateToCreatedCmsPage">
2730+
<argument name="CMSPage" value="$$createCMSPage$$"/>
2731+
</actionGroup>
2732+
<!-- Add text to page -->
2733+
<comment userInput="Add text to page" stepKey="addTextToPage"/>
2734+
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandGroupForText2">
2735+
<argument name="group" value="PageBuilderTextContentType"/>
2736+
</actionGroup>
2737+
<actionGroup ref="dragContentTypeToStage" stepKey="dragTextOntoPageStage">
2738+
<argument name="contentType" value="PageBuilderTextContentType"/>
2739+
</actionGroup>
2740+
<actionGroup ref="inlineEditWYSIWYGFromStage" stepKey="inlineEdit">
2741+
<argument name="contentType" value="PageBuilderTextContentType"/>
2742+
<argument name="content" value="{{PageBuilderTextProperty.value}}"/>
2743+
</actionGroup>
2744+
<!-- Add block to page -->
2745+
<comment userInput="Add block to page" stepKey="addBlockToPage"/>
2746+
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandGroupForBlock">
2747+
<argument name="group" value="PageBuilderBlockContentType"/>
2748+
</actionGroup>
2749+
<actionGroup ref="dragContentTypeToStage" stepKey="dragBlockOntoStage">
2750+
<argument name="contentType" value="PageBuilderBlockContentType"/>
2751+
</actionGroup>
2752+
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditAfterDrop">
2753+
<argument name="contentType" value="PageBuilderBlockContentType"/>
2754+
</actionGroup>
2755+
<actionGroup ref="searchBlockInGrid" stepKey="searchBlockInGrid">
2756+
<argument name="block" value="$$createPreReqBlock$$"/>
2757+
</actionGroup>
2758+
<waitForElementVisible selector="{{BlockOnForm.title('$$createPreReqBlock.title$$')}}" stepKey="waitToSeeBlockTitle"/>
2759+
<seeElement selector="{{BlockOnForm.title('$$createPreReqBlock.title$$')}}" stepKey="seeBlockTitleOnForm"/>
2760+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings2"/>
2761+
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
2762+
<!--Get storefront information-->
2763+
<comment userInput="Get storefront information" stepKey="commentGetStorefrontInformation"/>
2764+
<amOnPage url="$$createCMSPage.identifier$$" stepKey="amOnPageTestPage"/>
2765+
<waitForPageLoad stepKey="waitForStorefront"/>
2766+
<waitForElement selector="{{TextOnStorefront.base('1')}}" stepKey="waitForTextOnStorefront"/>
2767+
<executeJS function="return document.evaluate(&quot;{{TextOnStorefront.base('1'))}}&quot;, document.body).iterateNext().offsetHeight;" stepKey="getTextOnStorefrontHeight"/>
2768+
<executeJS function="return document.evaluate(&quot;{{BlockOnStorefront.text('1', '1'))}}&quot;, document.body).iterateNext().offsetHeight;" stepKey="getBlockTextOnStorefrontHeight"/>
2769+
<assertEquals stepKey="assertStageAndStorefrontHeightAreClose">
2770+
<expectedResult type="variable">getTextOnStorefrontHeight</expectedResult>
2771+
<actualResult type="variable">getBlockTextOnStorefrontHeight</actualResult>
2772+
</assertEquals>
2773+
</test>
26902774
</tests>

0 commit comments

Comments
 (0)