Skip to content

Commit 35bb923

Browse files
anthoulaanthoula
committed
MC-4280: Row Vertical Alignment Doesn't Work Inside Block & Dynamic Block
- add test to check alignment in Block
1 parent 945d0dd commit 35bb923

File tree

2 files changed

+75
-0
lines changed

2 files changed

+75
-0
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderBlockSection.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@
3131
<element name="margins" type="text" selector="(//div[contains(@class,'pagebuilder-block')])[{{arg1}}]//div[contains(@style,'margin: {{arg2}}px;')]" parameterized="true"/>
3232
<element name="padding" type="text" selector="(//div[contains(@class,'pagebuilder-block')])[{{arg1}}]//div[contains(@style,'padding: {{arg2}}px;')]" parameterized="true"/>
3333
<element name="overlay" type="text" selector="(//div[contains(@class,'pagebuilder-block') and contains(@class,'pagebuilder-block-overlay')])[{{arg1}}]" parameterized="true"/>
34+
<!-- Row -->
35+
<element name="rowInnerStyle" type="text" selector="(//div[contains(@class,'pagebuilder-block')])[{{arg1}}]//div[@data-role='row']//div[@data-element='inner'][contains(@style, '{{arg2}}')]" parameterized="true"/>
3436
</section>
3537
<section name="BlockOnGrid">
3638
<element name="searchBox" type="text" selector="//input[contains(@class,'data-grid-search-control')]"/>
@@ -61,5 +63,7 @@
6163
<element name="noCssClasses" type="text" selector="(//div[@data-role='row'])[{{arg1}}]/div[not(@class)]" parameterized="true"/>
6264
<element name="margins" type="text" selector="(//div[@data-role='block'])[{{arg1}}][contains(@style,'margin: {{arg2}}px;')]" parameterized="true"/>
6365
<element name="padding" type="text" selector="(//div[@data-role='block'])[{{arg1}}][contains(@style,'padding: {{arg2}}px;')]" parameterized="true"/>
66+
<!-- Row -->
67+
<element name="rowInnerStyle" type="text" selector="(//div[@data-role='block'])[{{arg1}}]//div[@data-role='row']//div[@data-element='inner'][contains(@style, '{{arg2}}')]" parameterized="true"/>
6468
</section>
6569
</sections>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockTest.xml

Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1107,4 +1107,75 @@
11071107
<dontSeeElementInDOM selector="{{BlockOnStorefront.hidden('1')}}" stepKey="dontSeeHiddenElement"/>
11081108
<seeElement selector="{{BlockOnStorefront.base('1')}}" stepKey="waitForContentTypeVisible" />
11091109
</test>
1110+
<test name="RowContentIsVerticallyAlignedInBlock">
1111+
<annotations>
1112+
<features value="PageBuilder"/>
1113+
<stories value="Block"/>
1114+
<title value="Row Content Can Be Vertically Aligned In Block"/>
1115+
<description value="A user can vertically align row contents in a Block"/>
1116+
<severity value="CRITICAL"/>
1117+
<useCaseId value="MC-914"/>
1118+
<testCaseId value="MC-5061"/>
1119+
<group value="pagebuilder"/>
1120+
<group value="pagebuilder-block"/>
1121+
</annotations>
1122+
<before>
1123+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin" />
1124+
<actionGroup ref="enablePageBuilderSetting" stepKey="enablePageBuilderSetting" />
1125+
<createData entity="_defaultBlock" stepKey="createPreReqBlock" />
1126+
</before>
1127+
<after>
1128+
<deleteData createDataKey="createPreReqBlock" stepKey="deletePreReqBlock" />
1129+
<actionGroup ref="DisabledWYSIWYG" stepKey="disableWYSIWYG"/>
1130+
<actionGroup ref="logout" stepKey="logout"/>
1131+
</after>
1132+
<actionGroup ref="navigateToCreatedCMSBlockPage" stepKey="navigateToCreatedCMSBlockPage">
1133+
<argument name="CMSBlockPage" value="$$createPreReqBlock$$" />
1134+
</actionGroup>
1135+
<!-- Configure First Row - Vertical Align Top -->
1136+
<comment userInput="Configure vertical align top" stepKey="commentConfigureVerticalAlignTop"/>
1137+
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
1138+
<argument name="contentType" value="PageBuilderRowContentType"/>
1139+
</actionGroup>
1140+
<actionGroup ref="fillSlideOutPanelField" stepKey="enterMinHeightProperty">
1141+
<argument name="property" value="PageBuilderMinHeightProperty_500"/>
1142+
</actionGroup>
1143+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterVerticalAlignmentTopProperty">
1144+
<argument name="property" value="PageBuilderVerticalAlignmentPropertyBottom"/>
1145+
</actionGroup>
1146+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettingsFirstRow"/>
1147+
<click selector="{{CmsNewBlockBlockActionsSection.savePage}}" stepKey="saveBlock" />
1148+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
1149+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
1150+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle1">
1151+
<argument name="contentType" value="PageBuilderBlockContentType"/>
1152+
</actionGroup>
1153+
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandGroupAddContent">
1154+
<argument name="group" value="PageBuilderBlockContentType"/>
1155+
</actionGroup>
1156+
<actionGroup ref="dragContentTypeToStageAndExpectEditPanel" stepKey="dragBlockIntoStage">
1157+
<argument name="contentType" value="PageBuilderBlockContentType"/>
1158+
</actionGroup>
1159+
<actionGroup ref="searchBlockInGrid" stepKey="searchBlockInGrid">
1160+
<argument name="block" value="$$createPreReqBlock$$"/>
1161+
</actionGroup>
1162+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
1163+
<!-- Verify Vertical Alignment On Stage - Before Save -->
1164+
<comment userInput="Verify min height and vertical alignment on stage before save" stepKey="commentVerifyMinHeightAndVerticalAlignmentOnStageBeforeSave"/>
1165+
<seeElement selector="{{BlockOnStage.rowInnerStyle('1', PageBuilderMinHeightProperty_500.value)}}" stepKey="seeRowMinHeightBeforeSave"/>
1166+
<seeElement selector="{{BlockOnStage.rowInnerStyle('1', PageBuilderVerticalAlignmentPropertyBottom.style)}}" stepKey="seeRowVerticalAlignmentBottomBeforeSave"/>
1167+
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
1168+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStageAfterSave"/>
1169+
<!-- Verify Vertical Alignment On Stage - After Save -->
1170+
<comment userInput="Verify min height and vertical alignment on stage after save" stepKey="commentVerifyMinHeightAndVerticalAlignmentOnStageAfterSave"/>
1171+
<seeElement selector="{{BlockOnStage.rowInnerStyle('1', PageBuilderMinHeightProperty_500.value)}}" stepKey="seeRowMinHeightAfterSave"/>
1172+
<seeElement selector="{{BlockOnStage.rowInnerStyle('1', PageBuilderVerticalAlignmentPropertyBottom.style)}}" stepKey="seeRowVerticalAlignmentBottomAfterSave"/>
1173+
<!-- Verify Min Height and Vertical Alignment In Storefront -->
1174+
<comment userInput="Verify min height and vertical alignment in storefront" stepKey="commentVerifyMinHeightAndVerticalAlignmentInStorefront"/>
1175+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
1176+
<argument name="contentType" value="PageBuilderBlockContentType"/>
1177+
</actionGroup>
1178+
<seeElement selector="{{BlockOnStorefront.rowInnerStyle('1', PageBuilderMinHeightProperty_500.value)}}" stepKey="seeRowMinHeightStorefront"/>
1179+
<seeElement selector="{{BlockOnStorefront.rowInnerStyle('1', PageBuilderVerticalAlignmentPropertyBottom.style)}}" stepKey="seeRowVerticalAlignmentBottomStorefront"/>
1180+
</test>
11101181
</tests>

0 commit comments

Comments
 (0)