Skip to content

Commit 3513dc9

Browse files
committed
MC-3065: Automate MFTF for MC-1364
1 parent d7f57d9 commit 3513dc9

File tree

3 files changed

+21
-14
lines changed

3 files changed

+21
-14
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdminActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
<dontSee userInput="Enable Advanced CMS" stepKey="dontSeeEnableAdvancedCMSBtn"/>
7272
<dontSee selector="{{PageBuilderPanel.generalGroup}}" stepKey="seePageBuilderVisible"/>
7373
</actionGroup>
74-
<actionGroup name="enablePageBuilderOnCatalog">
74+
<actionGroup name="openPageBuilderOnCatalog">
7575
<click selector="{{PageBuilderCatalog.openPageBuilder}}" stepKey="clickOnPageBuilderBtn" />
7676
<!--See PageBuilder fullsize-->
7777
<comment userInput="See PageBuilder fullsize" stepKey="commentSeePageBuilderFullsize"/>

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/UrlInputActionGroup.xml

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010
xsi:noNamespaceSchemaLocation="../../../../../../../dev/tests/acceptance/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Test/etc/actionGroupSchema.xsd">
1111
<actionGroup name="fillOutUrlInput">
1212
<arguments>
13-
<argument name="fieldName" defaultValue=""/>
14-
<argument name="linkName" defaultValue=""/>
15-
<argument name="searchString" defaultValue=""/>
13+
<argument name="fieldName"/>
14+
<argument name="linkName"/>
15+
<argument name="searchString"/>
1616
<argument name="searchResult"/>
1717
</arguments>
1818
<waitForElementVisible selector="{{PageBuilderSection.LinkSelect('fieldName')}}" stepKey="waitForButtonLinkSelect"/>
@@ -37,12 +37,14 @@
3737
</actionGroup>
3838
<actionGroup name="verifyCmsPageLinkOnFrontend">
3939
<arguments>
40-
<argument name="identifier"/>
40+
<argument name="CMSPage"/>
4141
<argument name="index"/>
42+
<argument name="section"/>
4243
</arguments>
43-
<scrollTo selector="{{ButtonItemOnStorefront.base('index')}}" stepKey="waitForButtonElementStorefront"/>
44-
<seeElement selector="{{PageBuilderPageOnStoreFrontSection.CMSPageLink(identifier)}}" stepKey="seePageLinkOnStoreFront" />
45-
<click selector="{{PageBuilderPageOnStoreFrontSection.CMSPageLink(identifier)}}" stepKey="clickButton"/>
44+
<scrollTo selector="{{section.base('index')}}" stepKey="waitForButtonElementStorefront"/>
45+
<seeElement selector="{{PageBuilderPageOnStoreFrontSection.CMSPageLink(CMSPage.identifier)}}" stepKey="seePageLinkOnStoreFront" />
46+
<click selector="{{PageBuilderPageOnStoreFrontSection.CMSPageLink(CMSPage.identifier)}}" stepKey="clickButton"/>
4647
<waitForPageLoad stepKey="waitForPageLoad"/>
48+
<see userInput="{{CMSPage.title}}" stepKey="seePageName" />
4749
</actionGroup>
4850
</actionGroups>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderCommonTest.xml

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1299,6 +1299,7 @@
12991299
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
13001300
</before>
13011301
<after>
1302+
<magentoCLI command="config:set general/store_information/country_id none" stepKey="setBackToDefaultValue"/>
13021303
<deleteData createDataKey="createPreReqCategory" stepKey="deletePreReqCategory" />
13031304
<deleteData createDataKey="createPreReqProduct" stepKey="deletePreReqProduct" />
13041305
<deleteData createDataKey="createCMSPageA" stepKey="deletePreReqCmsPageA" />
@@ -1312,8 +1313,9 @@
13121313
<click selector="{{AdminProductFormSection.contentTab}}" stepKey="clickContentTab"/>
13131314
<waitForElementVisible selector="{{PageBuilderCatalog.openPageBuilder}}" stepKey="waitForPageBuilderBtn" />
13141315
<see userInput="Edit with Page Builder" stepKey="seePageBuilderBtn"/>
1316+
<!--Click enable PageBuilder button-->
13151317
<comment userInput="Click enable PageBuilder button" stepKey="clickEnablePageBuilderBtn"/>
1316-
<actionGroup ref="enablePageBuilderOnCatalog" stepKey="enablePageBuilderOnCatalog"/>
1318+
<actionGroup ref="openPageBuilderOnCatalog" stepKey="enablePageBuilderOnCatalog"/>
13171319
<!--Add button into PageBuilder-->
13181320
<comment userInput="Add button into PageBuilder" stepKey="addButtonIntoPageBuilder"/>
13191321
<actionGroup ref="dragContentTypeToStage" stepKey="dragButtonIntoStage">
@@ -1375,10 +1377,10 @@
13751377
<see userInput="$$createCMSPageB.title$$" stepKey="verifyWidget" />
13761378
<waitForElementVisible selector="{{ImageOnStorefront.imageSourceByIndex('1', PageBuilderImageProperty_StageJPG.fileName)}}" stepKey="seeImage2SourceOnStorefront"/>
13771379
<actionGroup ref="verifyCmsPageLinkOnFrontend" stepKey="checkButtonOnStoreFront">
1378-
<argument name="identifier" value="$$createCMSPageA.identifier$$"/>
1380+
<argument name="CMSPage" value="$$createCMSPageA$$"/>
13791381
<argument name="index" value="1"/>
1382+
<argument name="section" value="ButtonItemOnStorefront"/>
13801383
</actionGroup>
1381-
<see userInput="$$createCMSPageA.title$$" stepKey="seePageName" />
13821384
</test>
13831385
<test name="AdminPageBuilderCategoryDirectivesTest">
13841386
<annotations>
@@ -1387,7 +1389,7 @@
13871389
<title value="Magento Directives - Always render Magento Directives on Magento Storefront for Category"/>
13881390
<description value="Admin are able to add CMS Page link, image, variable, widget into PageBuilder content and see it Category Page"/>
13891391
<severity value="CRITICAL"/>
1390-
<testCaseId value="MMC-3173"/>
1392+
<testCaseId value="MC-3173"/>
13911393
<useCaseId value="MC-1364"/>
13921394
<group value="pagebuilder"/>
13931395
<group value="pagebuilder-common"/>
@@ -1401,6 +1403,7 @@
14011403
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
14021404
</before>
14031405
<after>
1406+
<magentoCLI command="config:set general/store_information/country_id none" stepKey="setBackToDefaultValue"/>
14041407
<deleteData createDataKey="createPreReqCategory" stepKey="deletePreReqCategory" />
14051408
<deleteData createDataKey="createCMSPageA" stepKey="deletePreReqCmsPageA" />
14061409
<deleteData createDataKey="createCMSPageB" stepKey="deletePreReqCmsPageB" />
@@ -1413,8 +1416,9 @@
14131416
<click selector="{{AdminCategoryContentSection.sectionHeader}}" stepKey="clickContentTab"/>
14141417
<waitForElementVisible selector="{{PageBuilderCatalog.openPageBuilder}}" stepKey="waitForPageBuilderBtn" />
14151418
<see userInput="Edit with Page Builder" stepKey="seePageBuilderBtn"/>
1419+
<!--Click enable PageBuilder button-->
14161420
<comment userInput="Click enable PageBuilder button" stepKey="clickEnablePageBuilderBtn"/>
1417-
<actionGroup ref="enablePageBuilderOnCatalog" stepKey="enablePageBuilderOnCatalog"/>
1421+
<actionGroup ref="openPageBuilderOnCatalog" stepKey="enablePageBuilderOnCatalog"/>
14181422
<!--Add button to PageBuilder-->
14191423
<comment userInput="Add button to PageBuilder" stepKey="addButtonToPageBuilder"/>
14201424
<actionGroup ref="dragContentTypeToStage" stepKey="dragButtonIntoStage">
@@ -1476,8 +1480,9 @@
14761480
<see userInput="$$createCMSPageB.title$$" stepKey="verifyWidget" />
14771481
<waitForElementVisible selector="{{ImageOnStorefront.imageSourceByIndex('1', PageBuilderImageProperty_StageJPG.fileName)}}" stepKey="seeImage2SourceOnStorefront"/>
14781482
<actionGroup ref="verifyCmsPageLinkOnFrontend" stepKey="checkButtonOnStoreFront">
1479-
<argument name="identifier" value="$$createCMSPageA.identifier$$"/>
1483+
<argument name="CMSPage" value="$$createCMSPageA$$"/>
14801484
<argument name="index" value="1"/>
1485+
<argument name="section" value="ButtonItemOnStorefront"/>
14811486
</actionGroup>
14821487
<see userInput="$$createCMSPageA.title$$" stepKey="seePageName" />
14831488
</test>

0 commit comments

Comments
 (0)