MC-1413: (Magento) D y n a m i c Block Configuration

nathanjosiah · nathanjosiah · commit 33a92c1d1a5f · 2018-08-22T10:19:12.000-05:00
- Implemented CR feedback
diff --git a/app/code/Magento/PageBuilder/etc/di.xml b/app/code/Magento/PageBuilder/etc/di.xml
@@ -63,7 +63,6 @@
                 <item name="default" xsi:type="object">Magento\PageBuilder\Model\Stage\Renderer\Block</item>
                 <item name="products" xsi:type="object">Magento\PageBuilder\Model\Stage\Renderer\WidgetDirective</item>
                 <item name="block" xsi:type="object">Magento\PageBuilder\Model\Stage\Renderer\CmsStaticBlock</item>
-                <item name="dynamic_block" xsi:type="object">Magento\BannerPageBuilder\Model\Stage\Renderer\DynamicBlock</item>
             </argument>
         </arguments>
     </type>
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/block/preview.js b/app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/block/preview.js
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/block/preview.ts b/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/block/preview.ts
@@ -53,13 +53,13 @@ export default class Preview extends BasePreview {
     }
 
     /**
-     *
+     * Updates the view state using the data provided
      * @param {DataObject} data
      */
     public processBlockData(data: DataObject): void {
         // Only load if something changed
-        this.displayPreviewPlaceholder(data, "banner_ids");
-        this.processRequest(data, "banner_ids", "name");
+        this.displayPreviewPlaceholder(data, "block_id");
+        this.processRequest(data, "block_id", "title");
     }
 
     /**
@@ -91,7 +91,7 @@ export default class Preview extends BasePreview {
     }
 
     /**
-     * Displsay preview placeholder
+     * Display preview placeholder
      *
      * @param {DataObject} data
      * @param {string} identifierName

Original file line number	Diff line number	Diff line change
`@@ -53,13 +53,13 @@ export default class Preview extends BasePreview {`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`/**`
`56`		`- *`
	`56`	`+ * Updates the view state using the data provided`
`57`	`57`	`* @param {DataObject} data`
`58`	`58`	`*/`
`59`	`59`	`public processBlockData(data: DataObject): void {`
`60`	`60`	`// Only load if something changed`
`61`		`- this.displayPreviewPlaceholder(data, "banner_ids");`
`62`		`- this.processRequest(data, "banner_ids", "name");`
	`61`	`+ this.displayPreviewPlaceholder(data, "block_id");`
	`62`	`+ this.processRequest(data, "block_id", "title");`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`/**`
`@@ -91,7 +91,7 @@ export default class Preview extends BasePreview {`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`/**`
`94`		`- * Displsay preview placeholder`
	`94`	`+ * Display preview placeholder`
`95`	`95`	`*`
`96`	`96`	`* @param {DataObject} data`
`97`	`97`	`* @param {string} identifierName`