Skip to content

Commit 32489ed

Browse files
committed
MC-3146: Add new row appearances to configuration
- Resolve CR comments
1 parent 2df7b2f commit 32489ed

File tree

6 files changed

+22
-22
lines changed

6 files changed

+22
-22
lines changed
Binary file not shown.
Binary file not shown.

app/code/Magento/PageBuilder/docs/master-format.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ PageBuilder uses XHTML with inline styles and data attributes as the master form
6060

6161
## Row
6262

63-
#### Contained:
63+
Contained:
6464
```
6565
<div class="row-contained-wrapper" data-element="wrapper" data-role="row" data-appearance="contained">
6666
<div style="..."></div>
@@ -75,21 +75,21 @@ PageBuilder uses XHTML with inline styles and data attributes as the master form
7575
### main element
7676

7777
Attributes
78-
4. data-enable-parallax [1, 0]
79-
5. data-parallax-speed [0-1]
80-
6. data-background-color-format [hex, rgb, hsl, hsv, name, none]
81-
7. class
78+
1. data-enable-parallax [1, 0]
79+
2. data-parallax-speed [0-1]
80+
3. data-background-color-format [hex, rgb, hsl, hsv, name, none]
81+
4. class
8282

83-
#### Full Width:
83+
Full Width:
8484
```
8585
<div data-element="main" data-role="row" data-appearance="contained" style="...">
8686
<div data-element="inner" class="row-full-width-inner"></div>
8787
</div>
8888
```
8989

90-
#### Full Bleed:
90+
Full Bleed:
9191
```
92-
<div data-element="main" data-role="row" data-appearance="contained" style="..."></div>
92+
<div data-element="main" data-role="row" data-appearance="full-bleed" style="..."></div>
9393
```
9494

9595
### main element

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/row/contained/master.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
*/
66
-->
77

8-
<div attr="data.wrapper.attributes"
9-
ko-style="data.wrapper.style"
10-
css="data.wrapper.css">
11-
<div attr="data.main.attributes"
12-
ko-style="Object.assign(data.container.style(), data.main.style())"
13-
css="data.main.css">
8+
<div attr="data.main.attributes"
9+
ko-style="data.main.style"
10+
css="data.main.css">
11+
<div attr="data.inner.attributes"
12+
ko-style="Object.assign(data.container.style(), data.inner.style())"
13+
css="data.inner.css">
1414
<render args="renderChildTemplate"/>
1515
</div>
1616
</div>

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/row/contained/preview.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@
55
*/
66
-->
77

8-
<div attr="data.wrapper.attributes"
9-
ko-style="data.wrapper.style"
10-
css="data.wrapper.css">
8+
<div attr="data.main.attributes"
9+
ko-style="data.main.style"
10+
css="data.main.css">
1111
<div class="pagebuilder-content-type type-container pagebuilder-row children-min-height"
12-
attr="data.main.attributes"
13-
ko-style="data.main.style"
14-
css="Object.assign(data.main.css(), {'empty-container': parent.children().length == 0, 'jarallax': data.main.attributes()['data-enable-parallax'] == 1})"
12+
attr="data.inner.attributes"
13+
ko-style="data.inner.style"
14+
css="Object.assign(data.inner.css(), {'empty-container': parent.children().length == 0, 'jarallax': data.inner.attributes()['data-enable-parallax'] == 1})"
1515
event="{ mouseover: onMouseOver, mouseout: onMouseOut }, mouseoverBubble: false"
1616
afterRender="initParallax">
1717
<render args="getOptions().template"/>

app/code/Magento/PageBuilder/view/base/pagebuilder/content_type/row.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@
3131
reader="Magento_PageBuilder/js/master-format/read/configurable">
3232
<data_mapping>
3333
<elements>
34-
<element name="wrapper">
34+
<element name="main">
3535
<attributes>
3636
<attribute name="name" source="data-role"/>
3737
<attribute name="appearance" source="data-appearance"/>
3838
</attributes>
3939
</element>
40-
<element name="main">
40+
<element name="inner">
4141
<style_properties>
4242
<property name="background_color" source="background_color" converter="Magento_PageBuilder/js/converter/style/color"/>
4343
<property name="background_image" source="background_image" converter="Magento_PageBuilder/js/converter/style/background-image" preview_converter="Magento_PageBuilder/js/converter/style/preview/background-image"/>

0 commit comments

Comments
 (0)