Skip to content

Commit 31e2d94

Browse files
authored
Merge branch 'develop' into 2.4-develop-prs-fast-lane
2 parents 1524b0d + 42a9e6e commit 31e2d94

File tree

128 files changed

+770
-413
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

128 files changed

+770
-413
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,4 +66,5 @@ https://github.com/magento/magento2ce/pull/<related_pr>
6666
- [ ] Pull request has a meaningful description of its purpose
6767
- [ ] All commits are accompanied by meaningful commit messages
6868
- [ ] All new or changed code is covered with unit/integration tests (if applicable)
69+
- [ ] README.md files for modified modules are updated and included in the pull request if any [README.md predefined sections](https://github.com/magento/devdocs/wiki/Magento-module-README.md) require an update
6970
- [ ] All automated tests passed successfully (all builds are green)

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,18 @@ https://github.com/magento/magento2-page-builder-docs/wiki.
1414

1515
The wiki provides more information on the Page Builder project, such as:
1616

17+
- [Installation Guide](https://github.com/magento/magento2-page-builder-docs/wiki/Installation-Guide)
18+
- [Community Projects](https://github.com/magento/magento2-page-builder/projects)
1719
- [Links to User Guide tutorials](https://github.com/magento/magento2-page-builder-docs/wiki#page-builder-tutorials)
1820
- [Page Builder roadmaps](https://github.com/magento/magento2-page-builder-docs/wiki#roadmap)
1921
- [MFTF best practices](https://github.com/magento/magento2-page-builder-docs/wiki/%5BRough-Draft%5D-MFTF-Best-Practices)
20-
- [Partners Acceleration Program](https://github.com/magento/magento2-page-builder-docs/wiki/Partners-Acceleration-Program-Team)
2122

2223
## Documentation
23-
Complete documentation located on the [Magento DevDocs](https://devdocs.magento.com/page-builder/docs/), including what you need to know to start local development as described in the [installation guide](https://devdocs.magento.com/page-builder/docs/getting-started/install-pagebuilder.html).
24+
Complete documentation located on the [Magento DevDocs](https://devdocs.magento.com/page-builder/docs/), including what you need to know to start local development as described in the [installation guide](https://github.com/magento/magento2-page-builder-docs/wiki/Installation-Guide).
2425

2526
## Community Engineering Slack
2627

2728
To connect with Magento team and the Community, join us on the [Magento Community Engineering Slack](https://magentocommeng.slack.com).
2829
If you are interested in joining Slack, or a specific channel, use our [self signup](https://opensource.magento.com/slack) link.
2930

30-
Magento 2 Page Builder project slack channel: [#pagebuilder](https://magentocommeng.slack.com/archives/CHB455HPF)
31+
Magento 2 Page Builder project slack channel: [#pagebuilder](https://magentocommeng.slack.com/archives/CHB455HPF)

app/code/Magento/AwsS3PageBuilder/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"description": "Aws S3 Page Builder module",
44
"require": {
55
"magento/framework": "*",
6-
"php": "~7.3.0||~7.4.0"
6+
"php": "~7.4.0||~8.0.0"
77
},
88
"suggest": {
99
"magento/module-page-builder": "*",

app/code/Magento/CatalogPageBuilderAnalytics/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"magento/module-page-builder-analytics": "*",
99
"magento/module-catalog": "*",
1010
"magento/framework": "*",
11-
"php": "~7.3.0||~7.4.0"
11+
"php": "~7.4.0||~8.0.0"
1212
},
1313
"type": "magento2-module",
1414
"license": [

app/code/Magento/CmsPageBuilderAnalytics/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"magento/module-page-builder-analytics": "*",
99
"magento/module-cms": "*",
1010
"magento/framework": "*",
11-
"php": "~7.3.0||~7.4.0"
11+
"php": "~7.4.0||~8.0.0"
1212
},
1313
"type": "magento2-module",
1414
"license": [

app/code/Magento/PageBuilder/Controller/Adminhtml/Form/Element/ProductTotals.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,16 @@
99
namespace Magento\PageBuilder\Controller\Adminhtml\Form\Element;
1010

1111
use Exception;
12-
use Magento\Backend\App\Action;
1312
use Magento\Backend\App\Action\Context;
13+
use Magento\CatalogWidget\Controller\Adminhtml\Product\Widget;
1414
use Magento\Framework\App\Action\HttpPostActionInterface;
1515
use Magento\Framework\Controller\Result\JsonFactory;
1616

1717
/**
1818
* Returns the number of products that match the provided conditions
1919
*/
20-
class ProductTotals extends Action implements HttpPostActionInterface
20+
class ProductTotals extends Widget implements HttpPostActionInterface
2121
{
22-
const ADMIN_RESOURCE = 'Magento_Catalog::products';
2322

2423
/**
2524
* @var \Magento\PageBuilder\Model\Catalog\ProductTotals

app/code/Magento/PageBuilder/Model/Stage/Renderer/CmsStaticBlock.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public function render(array $params): array
9292
->load();
9393

9494
if ($blocks->count() === 0) {
95-
$result['error'] = sprintf(__('Block with ID: %s doesn\'t exist'), $params['block_id']);
95+
$result['error'] = sprintf(__('Block with ID: %s doesn\'t exist')->render(), $params['block_id']);
9696

9797
return $result;
9898
}

app/code/Magento/PageBuilder/Model/Wysiwyg/DefaultConfigProvider.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public function getConfig(\Magento\Framework\DataObject $config): \Magento\Frame
4242
$config->addData(
4343
[
4444
'tinymce' => [
45-
'toolbar' => 'undo redo | styleselect | fontsizeselect | lineheightselect | forecolor backcolor ' .
45+
'toolbar' => 'undo redo | styleselect | fontsizeselect | lineheight | forecolor backcolor ' .
4646
'| bold italic underline | alignleft aligncenter alignright | numlist bullist ' .
4747
'| link image table charmap',
4848

@@ -57,15 +57,11 @@ public function getConfig(\Magento\Framework\DataObject $config): \Magento\Frame
5757
'media',
5858
'noneditable',
5959
'table',
60-
'contextmenu',
6160
'paste',
6261
'code',
6362
'help',
6463
'table',
65-
'textcolor',
66-
'image',
67-
'colorpicker',
68-
'lineheight'
64+
'image'
6965
]
7066
),
7167
'content_css' => [

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/WYSIWYGActionGroup/InsertLinkInWYSIWYGActionGroup.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,10 @@
1313
<argument name="url" type="string"/>
1414
<argument name="textToDisplay" type="string"/>
1515
<argument name="title" type="string" defaultValue=""/>
16-
<argument name="wysiwygArea" defaultValue="{{WYSIWYGOnPageBuilderInline.notCss}}" type="string"/>
1716
</arguments>
1817
<comment userInput="insertLinkInWYSIWYG" stepKey="comment"/>
19-
<waitForElementVisible selector="{{wysiwygArea}} {{section.InsertLink}}" stepKey="waitForInsertLinkButton"/>
20-
<click selector="{{wysiwygArea}} {{section.InsertLink}}" stepKey="clickInsertLinkButton"/>
18+
<waitForElementVisible selector="{{section.InsertLink}}" stepKey="waitForInsertLinkButton"/>
19+
<click selector="{{section.InsertLink}}" stepKey="clickInsertLinkButton"/>
2120
<waitForPageLoad stepKey="waitForPageLoad"/>
2221
<waitForElementVisible selector="{{WYSIWYGInsertLinkModal.modal}}" stepKey="waitForInsertLinkModal"/>
2322
<fillField selector="{{WYSIWYGInsertLinkModal.urlInput}}" userInput="{{url}}" stepKey="insertUrl"/>

app/code/Magento/PageBuilder/Test/Mftf/Data/BackgroundFormData.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,7 @@
211211
<data key="rgb">rgb(64, 127, 128)</data>
212212
<data key="hex">#407f80</data>
213213
<data key="rgbaCenterOfLightDarkSlider">rgba(64, 127, 128, 0.5)</data>
214+
<data key="rgbaCenterOfLightDarkSliderRegex">^rgba\(64,\s*127,\s*128,\s*0.49(\d+)\)</data>
214215
</entity>
215216
<entity name="PageBuilderBackgroundColor_Invalid" type="pagebuilder_background_color_property">
216217
<data key="name">Background Color</data>

0 commit comments

Comments
 (0)