Skip to content

Commit 31da63b

Browse files
committed
MC-3155: Create/Update tests
- Add section to action group
1 parent 24b0331 commit 31da63b

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/CatalogProductActionGroup.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,15 @@
88

99
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
1010
xsi:noNamespaceSchemaLocation="../../../../../../../../dev/tests/acceptance/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Test/etc/actionGroupSchema.xsd">
11-
<actionGroup name="openPageBuilderForProductAttribute">
11+
<actionGroup name="openPageBuilderForAttribute">
1212
<arguments>
1313
<argument name="attributeCode" type="string"/>
14+
<argument name="section" defaultValue="PageBuilderProductAttribute"/>
1415
</arguments>
1516
<!-- Opening Page Builder for attribute -->
1617
<comment userInput="Opening Page Builder for attribute" stepKey="commentOpeningPageBuilder"/>
17-
<waitForElementVisible selector="{{PageBuilderProductAttribute.PageBuilderBtn(attributeCode)}}" stepKey="seePagebuilderBtn"/>
18-
<click selector="{{PageBuilderProductAttribute.PageBuilderBtn(attributeCode)}}" stepKey="enablePageBuilder"/>
18+
<waitForElementVisible selector="{{section.PageBuilderBtn(attributeCode)}}" stepKey="seePagebuilderBtn"/>
19+
<click selector="{{section.PageBuilderBtn(attributeCode)}}" stepKey="enablePageBuilder"/>
1920
<waitForElementVisible selector="{{PageBuilderPanel.generalGroup}}" stepKey="waiForPageBuilderVisible" />
2021
</actionGroup>
2122
</actionGroups>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCreateProductTest.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@
200200
<waitForPageLoad stepKey="waitForProductPage"/>
201201
<!-- Set background colour of row for custom attribute -->
202202
<comment userInput="Set background colour of row for custom attribute" stepKey="commentSetBackgroundColor"/>
203-
<actionGroup ref="openPageBuilderForProductAttribute" stepKey="openPageBuilderForProductAttribute">
203+
<actionGroup ref="openPageBuilderForAttribute" stepKey="openPageBuilderForAttribute">
204204
<argument name="attributeCode" value="$$createWysiwygAttribute.attribute_code$$"/>
205205
</actionGroup>
206206
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
@@ -215,7 +215,7 @@
215215
<!-- Set background colour of row for description -->
216216
<comment userInput="Set background colour of row for description" stepKey="commentSetDescriptionRowBackgroundColor"/>
217217
<click selector="{{AdminProductContentSection.sectionHeader}}" stepKey="openContentSection"/>
218-
<actionGroup ref="openPageBuilderForProductAttribute" stepKey="openPageBuilderForDescription">
218+
<actionGroup ref="openPageBuilderForAttribute" stepKey="openPageBuilderForDescription">
219219
<argument name="attributeCode" value="description"/>
220220
</actionGroup>
221221
<actionGroup ref="openPageBuilderEditPanel" stepKey="openDescriptionEditMenuOnStage">
@@ -346,7 +346,7 @@
346346
<waitForPageLoad stepKey="waitForProductPage"/>
347347
<!-- Set background colour of row for our first custom attribute -->
348348
<comment userInput="Set background colour of row for our first custom attribute" stepKey="commentSetBackgroundColor"/>
349-
<actionGroup ref="openPageBuilderForProductAttribute" stepKey="openPageBuilderForProductAttribute1">
349+
<actionGroup ref="openPageBuilderForAttribute" stepKey="openPageBuilderForAttribute1">
350350
<argument name="attributeCode" value="$$createPageBuilderAttribute1.attribute_code$$"/>
351351
</actionGroup>
352352
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
@@ -360,7 +360,7 @@
360360
<waitForPageLoad stepKey="waitForPageLoadExitFullScreen"/>
361361
<!-- Set background colour of row for our second custom attribute -->
362362
<comment userInput="Set background colour of row for our second custom attribute" stepKey="commentSetBackgroundColor1"/>
363-
<actionGroup ref="openPageBuilderForProductAttribute" stepKey="openPageBuilderForProductAttribute2">
363+
<actionGroup ref="openPageBuilderForAttribute" stepKey="openPageBuilderForAttribute2">
364364
<argument name="attributeCode" value="$$createPageBuilderAttribute2.attribute_code$$"/>
365365
</actionGroup>
366366
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage1">

0 commit comments

Comments
 (0)