Skip to content

Commit 2efc546

Browse files
committed
#421: Setting Empty Border Radius on Tab Item Errors and Breaks Tab Item Content
- Code Review Feedback/Amends
1 parent 189c0e8 commit 2efc546

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabItemConfigurationTest/TabItemUpdateAdvancedConfigurationValuesTest.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
7474
<comment userInput="Add and Customize Tab 2" stepKey="AC2"/>
7575
<waitForElementVisible selector="{{TabOnStage.tabHeader('1')}}" stepKey="seeTabHeader1"/>
76-
<actionGroup ref="addChildContentTypeFromOptionMenu" stepKey="addChildContentType2">
76+
<actionGroup ref="addChildContentTypeFromOptionMenu" stepKey="addChildContentType">
7777
<argument name="contentType" value="PageBuilderTabsContentType"/>
7878
</actionGroup>
7979
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openEditPanel2">
@@ -90,7 +90,7 @@
9090
<dontSeeJsError stepKey="doNotSeeJSErrorInConsole"/>
9191
<!-- Add and Customize Tab 3 -->
9292
<waitForElementVisible selector="{{TabOnStage.tabHeader('2')}}" stepKey="seeTabHeader2"/>
93-
<actionGroup ref="addChildContentTypeFromOptionMenu" stepKey="addChildContentType3">
93+
<actionGroup ref="addChildContentTypeFromOptionMenu" stepKey="addChildContentType2">
9494
<argument name="contentType" value="PageBuilderTabsContentType"/>
9595
</actionGroup>
9696
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openEditPanel3">
@@ -147,16 +147,16 @@
147147
<!-- Verify in Storefront -->
148148
<amOnPage url="{{PageBuilderTabsContentType.name}}{{PageBuilderPageTitle.pageName}}" stepKey="amOnPageBuilderPage"/>
149149
<waitForPageLoad stepKey="waitForPageLoadStoreFront" time="30"/>
150-
<!-- Verify Tab 1 on Storefront -->
150+
<comment userInput="Verify Tab 1 on Storefront" stepKey="AC5"/>
151151
<waitForElementVisible selector="{{TabOnStorefront.tabContentAdvancedStyles('1', PageBuilderAdvancedAlignmentPropertyCenter.value, PageBuilderAdvancedMarginsAndPaddingProperty.marginLeft, PageBuilderAdvancedMarginsAndPaddingProperty.paddingLeft)}}" stepKey="seeTabContentAdvancedStylesInStorefront1"/>
152152
<waitForElementVisible selector="{{TabOnStorefront.tabContentAdvancedStylesBorder('1', PageBuilderAdvancedBorderPropertySolid.value, PageBuilderAdvancedBorderColorProperty.rgb, PageBuilderAdvancedBorderWidthProperty10.value, PageBuilderAdvancedBorderRadiusProperty12.value)}}" stepKey="seeTabContentAdvancedStylesBorderInStorefront1"/>
153153
<waitForElementVisible selector="{{TabOnStorefront.tabContentAdvancedClass('1', PageBuilderAdvancedCssClassesPropertyThreeClasses.value)}}" stepKey="seeTabContentClassInStorefront1"/>
154-
<click selector="{{TabOnStorefront.tabHeader('2')}}" stepKey="switchToTab2"/>
154+
<click selector="{{TabOnStorefront.tabHeader('2')}}" stepKey="switchToTab"/>
155155
<waitForPageLoad stepKey="waitForTabChangeAnimationStorefront" time="30"/>
156156
<scrollToTopOfPage stepKey="scrollToTopOfPage"/>
157157
<waitForElementVisible selector="{{TabOnStorefront.container('2')}}" stepKey="seeNewTabContent2"/>
158158
<!-- Verify Tab 2 on Storefront -->
159-
<click selector="{{TabOnStorefront.tabHeader('3')}}" stepKey="switchToTab3"/>
159+
<click selector="{{TabOnStorefront.tabHeader('3')}}" stepKey="switchToTab2"/>
160160
<waitForPageLoad stepKey="waitForTabChangeAnimationStorefront2" time="30"/>
161161
<scrollToTopOfPage stepKey="scrollToTopOfPage2"/>
162162
<waitForElementVisible selector="{{TabOnStorefront.container('3')}}" stepKey="seeNewTabContent3"/>

0 commit comments

Comments
 (0)