Skip to content

Commit 2ee70da

Browse files
Merge branch 'viewport-switcher' of github.com:magento/magento2-page-builder into 637-form-field-viewport-scope
Conflicts: app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/observable-updater.js
2 parents 8c93159 + 5aac3f3 commit 2ee70da

File tree

10 files changed

+27
-26
lines changed

10 files changed

+27
-26
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/block/preview.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slide/preview.js

Lines changed: 0 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slider/preview.js

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/page-builder.js

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/block/preview.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ export default class Preview extends BasePreview {
235235

236236
if (elements.length && styleBlock.innerText.length) {
237237
document.body.append(styleBlock);
238-
content = document.body.innerHTML;
238+
content = document.head.innerHTML + document.body.innerHTML;
239239
}
240240

241241
return content;

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slide/preview.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -101,18 +101,7 @@ export default class Preview extends BasePreview {
101101
private buildJarallax = _.debounce(() => {
102102
// Destroy all instances of the plugin prior
103103
try {
104-
// store/apply correct style after destroying, as jarallax incorrectly overrides it with stale value
105-
const style = this.wrapper.getAttribute("style") ||
106-
this.wrapper.getAttribute("data-jarallax-original-styles");
107-
const backgroundImage = this.getBackgroundImage();
108104
jarallax(this.wrapper, "destroy");
109-
this.wrapper.setAttribute("style", style);
110-
if (this.contentType.dataStore.get("background_type") as string !== "video" &&
111-
this.wrapper.style.backgroundImage !== backgroundImage &&
112-
backgroundImage !== "none"
113-
) {
114-
this.wrapper.style.backgroundImage = backgroundImage;
115-
}
116105
} catch (e) {
117106
// Failure of destroying is acceptable
118107
}

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slider/preview.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,12 @@ export default class Preview extends PreviewCollection {
126126
`stage:${this.contentType.stageId}:fullScreenModeChangeAfter`,
127127
this.onColumnResize.bind(this, [true]),
128128
);
129+
events.on(`stage:${this.contentType.stageId}:viewportChangeAfter`, () => {
130+
if (this.element) {
131+
$(this.element).slick("setPosition");
132+
this.checkWidth();
133+
}
134+
});
129135
},
130136
() => $(element).find(".pagebuilder-slide").length === expectedChildren,
131137
);

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/page-builder.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,10 @@ export default class PageBuilder implements PageBuilderInterface {
267267
viewport,
268268
previousViewport,
269269
});
270+
events.trigger(`stage:viewportChangeAfter`, {
271+
viewport,
272+
previousViewport,
273+
});
270274
}
271275

272276
/**

app/code/Magento/PageBuilder/view/base/web/js/content-type/products/appearance/carousel/widget.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ define([
6464
return function (config, element) {
6565
var $element = $(element),
6666
$carouselElement = $($element.children()),
67-
stageId = $($element).parents('[data-role="pagebuilder-stage"]').attr('id'),
6867
currentViewport = config.currentViewport,
6968
currentBreakpoint = config.breakpoints[currentViewport],
7069
slickConfig = {
@@ -97,7 +96,7 @@ define([
9796
}
9897
});
9998

100-
events.on('stage:' + stageId + ':viewportChangeAfter', function (args) {
99+
events.on('stage:viewportChangeAfter', function (args) {
101100
var breakpoint = config.breakpoints[args.viewport];
102101

103102
initSlider($element, slickConfig, breakpoint);

app/code/Magento/PageBuilder/view/base/web/js/content-type/slider/appearance/default/widget.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,6 @@ define([
3535
$element.slick('setPosition');
3636
}
3737
});
38+
events.on('stage:viewportChangeAfter', $element.slick.bind($element, 'setPosition'));
3839
};
3940
});

0 commit comments

Comments
 (0)