Skip to content

Commit 2eb5243

Browse files
committed
MC-5710: Beta docs tutorial
Fixed contributing link and TOC capitalization inconsistencies
1 parent bca84dc commit 2eb5243

File tree

3 files changed

+53
-11
lines changed

3 files changed

+53
-11
lines changed

docs/CONTRIBUTING.md

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
# Contributing to Magento 2 code
2+
3+
## Overview
4+
5+
Contributions to the Magento 2 codebase are done using the fork & pull model.
6+
This contribution model has contributors maintaining their own copy of the forked codebase (which can easily be synced with the main copy). The forked repository is then used to submit a request to the base repository to “pull” a set of changes (hence the phrase “pull request”).
7+
8+
Contributions can take the form of new components/features, changes to existing features, tests, documentation (such as developer guides, user guides, examples, or specifications), bug fixes, optimizations or just good suggestions.
9+
10+
The Magento 2 development team will review all issues and contributions submitted by the community of developers in the first in, first out order. During the review we might require clarifications from the contributor. If there is no response from the contributor for two weeks, the issue is closed.
11+
12+
## Contribution requirements
13+
14+
1. Contributions must adhere to [Magento coding standards](http://devdocs.magento.com/guides/v2.0/coding-standards/bk-coding-standards.html).
15+
2. Pull requests (PRs) must be accompanied by a meaningful description of their purpose. Comprehensive descriptions increase the chances of a pull request to be merged quickly and without additional clarification requests.
16+
3. Commits must be accompanied by meaningful commit messages.
17+
4. PRs which include bug fixing, must be accompanied with step-by-step description of how to reproduce the bug.
18+
5. PRs which include new logic or new features must be submitted along with:
19+
* Unit/integration test coverage where applicable.
20+
* Updated documentation in the `docs` directory at the root level.
21+
6. For large features or changes, please [open an issue](https://github.com/magento/magento2/issues) and discuss first. This may prevent duplicate or unnecessary effort, and it may gain you some additional contributors.
22+
7. All automated tests are passed successfully locally. After PR submitted Magento team will run builds on continuous integration environment.
23+
24+
## Contribution process
25+
26+
If you are a new GitHub user, we recommend that you create your own [free github account](https://github.com/signup/free). By doing that, you will be able to collaborate with the Magento 2 development team, “fork” the Magento 2 project and be able to easily send “pull requests”.
27+
28+
1. Search current [listed issues](https://github.com/magento/magento2-page-builder/issues) on GitHub (open or closed) before starting work on a new contribution.
29+
2. Review the [Contributor License Agreement](https://magento.com/legaldocuments/mca) if this is your first time contributing.
30+
3. Create and test your work.
31+
4. Fork the Magento 2 repository according to [Fork a repository instructions](http://devdocs.magento.com/guides/v2.0/contributor-guide/contributing.html#fork) and when you are ready to send us a pull request – follow [Create a pull request instructions](http://devdocs.magento.com/guides/v2.0/contributor-guide/contributing.html#pull_request). Instructions written for `https://github.com/magento/magento2` repository, but they also apply to `https://github.com/magento/magento2-page-builder`.
32+
5. Once your contribution is received, Magento 2 development team will review the contribution and collaborate with you as needed to improve the quality of the contribution.
33+
34+
## Code of Conduct
35+
36+
Please note that this project is released with a Contributor Code of Conduct. We expect you to agree to its terms when participating in this project.
37+
The full text is available in the repository [Wiki](https://github.com/magento/magento2/wiki/Magento-Code-of-Conduct).

docs/_pagebuilder.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
label: Page Builder
22
pages:
3-
- label: Getting Started
3+
- label: Getting started
44
url: /page-builder/getting-started/introduction.html
55
versionless: true
66
children:
@@ -35,16 +35,16 @@ pages:
3535
url: /page-builder/create-basic-content-type/step-3-add-components.html
3636
versionless: true
3737

38-
- label: Step 4. Add editor
38+
- label: Step 4. Add form editor
3939
url: /page-builder/create-basic-content-type/step-4-add-editor.html
4040
versionless: true
4141

4242
- label: Step 5. Add styles
43-
url: /page-builder/create-basic-content-type/step-6-add-styles.html
43+
url: /page-builder/create-basic-content-type/step-5-add-styles.html
4444
versionless: true
4545

4646
- label: Step 6. Add frontend widget
47-
url: /page-builder/create-basic-content-type/step-7-add-frontend-widget.html
47+
url: /page-builder/create-basic-content-type/step-6-add-frontend-widget.html
4848
versionless: true
4949

5050
- label: What's next?
@@ -102,7 +102,7 @@ pages:
102102
url: /page-builder/configurations/server-side-rendered-previews.html
103103
versionless: true
104104

105-
- label: How Tos
105+
- label: How tos
106106
versionless: true
107107
children:
108108
- label: How to develop a new content type
@@ -167,6 +167,10 @@ pages:
167167
url: /page-builder/component-status.html
168168
versionless: true
169169

170-
- label: Known Issues
170+
- label: Known issues
171171
url: /page-builder/known-issues.html
172172
versionless: true
173+
174+
- label: Contribution guide
175+
url: /page-builder/known-issues.html
176+
versionless: true

docs/getting-started/introduction.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ See [Install Page Builder](install-pagebuilder.md)
1414

1515
## Developer documentation
1616

17-
### Getting Started
17+
### Getting started
1818

1919
* [Install Page Builder](install-pagebuilder.md)
2020
* [Activate Page Builder](activate-pagebuilder.md)
@@ -46,7 +46,7 @@ See [Install Page Builder](install-pagebuilder.md)
4646
* [Product conditions configuration](../configurations/product-conditions-configuration.md)
4747
* [Server-side rendered previews](../configurations/server-side-rendered-previews.md)
4848

49-
### How Tos
49+
### How tos
5050

5151
* [How to develop a new content type](../how-to/how-to-develop-new-content-type.md)
5252
* [How to develop a container content type](../how-to/how-to-develop-container-content-type.md)
@@ -73,14 +73,15 @@ See [Install Page Builder](install-pagebuilder.md)
7373

7474
* [Component status](../component-status.md)
7575
* [Known issues](../known-issues.md)
76+
* [Contribution guide](../CONTRIBUTING.md)
7677

7778
<!-- {% endcomment %} -->
7879

79-
## Contribute to PageBuilder
80+
## Contribute to Page Builder
8081

8182
We appreciate any and all contributions to PageBuilder. If you are interested in contributing to this repository, please see our [Contribution Guide].
8283

83-
## PageBuilder updates from the Magento core team
84+
## Page Builder updates from the Magento core team
8485

8586
We will push new beta releases once a week, including work from the backlog. We don't expect any large breaking changes, but we will communicate them to you if the need arises.
8687

@@ -89,5 +90,5 @@ We will push new beta releases once a week, including work from the backlog. We
8990
To participate in technical discussions and ask questions, join us in [Slack], where a number of Page Builder team members are present.
9091

9192

92-
[Contribution Guide]: ../../CONTRIBUTING.md
93+
[Contribution Guide]: ../CONTRIBUTING.md
9394
[Slack]: https://magentocommeng.slack.com/messages/GANS1R4C9

0 commit comments

Comments
 (0)