MC-401: Advanced Attributes Not Removing From Preview

tjwiebell · tjwiebell · commit 2dff02b0ee22 · 2018-06-26T15:55:01.000-05:00
- Add missing radix parameter to pass tslint
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/row/converter/style/margins-and-paddings.ts b/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/row/converter/style/margins-and-paddings.ts
@@ -31,7 +31,7 @@ export default class MarginsAndPaddings implements ConverterInterface {
             result.marginLeft = value.margin.left ? value.margin.left + "px" : "";
             result.marginTop = value.margin.top ? value.margin.top + "px" : "";
             result.marginRight = value.margin.right ? value.margin.right + "px" : "";
-            result.marginBottom = (parseInt(value.margin.bottom) > 0 ? value.margin.bottom : 1) + "px";
+            result.marginBottom = (parseInt(value.margin.bottom, 10) > 0 ? value.margin.bottom : 1) + "px";
         }
         if (undefined !== value && undefined !== value.padding) {
             result.paddingLeft = value.padding.left ? value.padding.left + "px" : "";

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ export default class MarginsAndPaddings implements ConverterInterface {`
`31`	`31`	`result.marginLeft = value.margin.left ? value.margin.left + "px" : "";`
`32`	`32`	`result.marginTop = value.margin.top ? value.margin.top + "px" : "";`
`33`	`33`	`result.marginRight = value.margin.right ? value.margin.right + "px" : "";`
`34`		`- result.marginBottom = (parseInt(value.margin.bottom) > 0 ? value.margin.bottom : 1) + "px";`
	`34`	`+ result.marginBottom = (parseInt(value.margin.bottom, 10) > 0 ? value.margin.bottom : 1) + "px";`
`35`	`35`	`}`
`36`	`36`	`if (undefined !== value && undefined !== value.padding) {`
`37`	`37`	`result.paddingLeft = value.padding.left ? value.padding.left + "px" : "";`