Skip to content

Commit 2d11ce7

Browse files
omiroshnichenkoomiroshnichenko
committed
MC-3735: Allow inline WYSIWYG editing of slides
- Add test disabled WYSIWYG
1 parent 447e0df commit 2d11ce7

File tree

6 files changed

+62
-4
lines changed

6 files changed

+62
-4
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderSliderSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@
165165
<element name="editFormBackgroundMobileImagePreview" type="button" selector="//input[@name='mobile_image']/ancestor::div[@class='admin__field-control']/descendant::img"/>
166166
<element name="tinymce" type="button" selector="(//div[contains(@class,'pagebuilder-slide')])[{{arg1}}]//div[contains(@class, 'inline-wysiwyg')]" parameterized="true"/>
167167
<element name="tinymcePanel" type="button" selector="(//div[contains(@class,'pagebuilder-slide')])[{{arg1}}]//div[contains(@class, 'mce-tinymce-inline')]" parameterized="true"/>
168+
<element name="textareaPlaceholder" type="text" selector="(//div[contains(@class,'pagebuilder-slide')])[{{arg1}}]//textarea[contains(@class, 'inline-wysiwyg-textarea') and contains(@placeholder,'Edit Slide Text')]" parameterized="true"/>
168169
</section>
169170
<section name="SlideOnConfigurationPanel">
170171
<element name="tinyMCEIFrame" type="text" selector="pagebuilder_slide_form_content_ifr"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideCommonTest.xml

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2179,6 +2179,63 @@
21792179
</actionGroup>
21802180
<see userInput="{{PageBuilderSlideItemContent1.value}}" stepKey="seeTextOnStorefront"/>
21812181
</test>
2182+
<test name="SlideInlineTextEditingWithDisabledWYSIWYG">
2183+
<annotations>
2184+
<features value="PageBuilder"/>
2185+
<stories value="Slider"/>
2186+
<title value="Edit slide text inline in textarea and see on storefront"/>
2187+
<description value="Verify that user are able to add text into Slide Content Type and see it on storefront"/>
2188+
<severity value="MAJOR"/>
2189+
<useCaseId value="MC-937"/>
2190+
<testCaseId value="MC-3813"/>
2191+
<group value="pagebuilder"/>
2192+
<group value="pagebuilder-slide"/>
2193+
</annotations>
2194+
<before>
2195+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2196+
<actionGroup ref="DisabledWYSIWYG" stepKey="disableWYSIWYG"/>
2197+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
2198+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
2199+
</before>
2200+
<after>
2201+
<actionGroup ref="logout" stepKey="logout"/>
2202+
</after>
2203+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
2204+
<argument name="contentType" value="PageBuilderSliderContentType"/>
2205+
</actionGroup>
2206+
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
2207+
<argument name="group" value="PageBuilderSliderContentType"/>
2208+
</actionGroup>
2209+
<actionGroup ref="dragContentTypeToStageAndExpectEditPanel" stepKey="dragSliderIntoStage">
2210+
<argument name="contentType" value="PageBuilderSliderContentType"/>
2211+
</actionGroup>
2212+
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings"/>
2213+
<!--Input text into stage-->
2214+
<comment userInput="Input text into stage" stepKey="commentInputTextIntoStage"/>
2215+
<click selector="{{SlideOnBackend.textareaPlaceholder('1')}}" stepKey="focusOnEditorArea"/>
2216+
<fillField selector="{{SlideOnBackend.textareaPlaceholder('1')}}" userInput="{{PageBuilderSlideItemContent1.value}}" stepKey="fillTextToTextArea"/>
2217+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="lostFocusFromWYSIWYG1"/>
2218+
<!--Verify inserted text on edit panel -->
2219+
<comment userInput="Verify inserted text on edit panel" stepKey="commentVerifyTextOnSlideout"/>
2220+
<actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openEditPanel1">
2221+
<argument name="section" value="SlideOnBackend"/>
2222+
</actionGroup>
2223+
<waitForElementVisible selector="{{SlideOnBackend.textareaPlaceholder('1')}}" stepKey="textareaVisible"/>
2224+
<seeInField selector="{{SlideOnBackend.textareaPlaceholder('1')}}" userInput="{{PageBuilderSlideItemContent1.value}}" stepKey="seeInField"/>
2225+
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings2"/>
2226+
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage2"/>
2227+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
2228+
<!--Verify Slide Content Type on stage after saving cms page-->
2229+
<comment userInput="Verify text in slide content type on stage" stepKey="commentVerifySlideOnStage"/>
2230+
<waitForElementVisible selector="{{SlideOnBackend.textareaPlaceholder('1')}}" stepKey="textareaVisible1"/>
2231+
<seeInField selector="{{SlideOnBackend.textareaPlaceholder('1')}}" userInput="{{PageBuilderSlideItemContent1.value}}" stepKey="seeInField1"/>
2232+
<!--Verify Slide Content Type on storefront-->
2233+
<comment userInput="Verify text in Slide Content Type on storefront" stepKey="commentVerifySlideContenTypeOnStorefront"/>
2234+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
2235+
<argument name="contentType" value="PageBuilderSliderContentType"/>
2236+
</actionGroup>
2237+
<see userInput="{{PageBuilderSlideItemContent1.value}}" stepKey="seeTextOnStorefront"/>
2238+
</test>
21822239
<test name="SlideInlineTextEditingAvailability">
21832240
<annotations>
21842241
<features value="PageBuilder"/>

‎app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/slide/collage-centered/preview.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<textarea class="inline-wysiwyg-textarea"
3737
afterRender="initTextarea"
3838
event="{keyup: onTextareaKeyUp, focus: onTextareaFocus, blur: onTextareaBlur}"
39-
data-bind="attr: { placeholder: $t('Edit Text') }" />
39+
data-bind="attr: { placeholder: $t('Edit Slide Text') }" />
4040
</div>
4141
<a if="data.main.attributes()['data-show-button'] !== 'never'"
4242
type="button"

‎app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/slide/collage-left/preview.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
<textarea class="inline-wysiwyg-textarea"
3939
afterRender="initTextarea"
4040
event="{keyup: onTextareaKeyUp, focus: onTextareaFocus, blur: onTextareaBlur}"
41-
data-bind="attr: { placeholder: $t('Edit Text') }" />
41+
data-bind="attr: { placeholder: $t('Edit Slide Text') }" />
4242
</div>
4343
<a if="data.main.attributes()['data-show-button'] !== 'never'"
4444
type="button"

‎app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/slide/collage-right/preview.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<textarea class="inline-wysiwyg-textarea"
3737
afterRender="initTextarea"
3838
event="{keyup: onTextareaKeyUp, focus: onTextareaFocus, blur: onTextareaBlur}"
39-
data-bind="attr: { placeholder: $t('Edit Text') }" />
39+
data-bind="attr: { placeholder: $t('Edit Slide Text') }" />
4040
</div>
4141
<a if="data.main.attributes()['data-show-button'] !== 'never'"
4242
type="button"

‎app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/slide/poster/preview.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
<textarea class="inline-wysiwyg-textarea"
4141
afterRender="initTextarea"
4242
event="{keyup: onTextareaKeyUp, focus: onTextareaFocus, blur: onTextareaBlur}"
43-
data-bind="attr: { placeholder: $t('Edit Text') }" />
43+
data-bind="attr: { placeholder: $t('Edit Slide Text') }" />
4444
</div>
4545
<a if="data.main.attributes()['data-show-button'] !== 'never'"
4646
type="button"

0 commit comments

Comments
 (0)