Skip to content

Commit 2ce807a

Browse files
committed
MAGETWO-91375: Refactor drag & drop code
- Fix some issues with buttons
1 parent d85088d commit 2ce807a

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ButtonActionGroup.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
<expectedResult type="variable">initialNumberOfButtonsPlusOne</expectedResult>
2626
<actualResult type="variable">numberOfButtonsAfterAdd</actualResult>
2727
</assertEquals>
28+
<click selector="{{PageBuilderActionsSection.searchPanel}}" stepKey="unfocusButtonLiveEdit"/>
2829
</actionGroup>
2930
<actionGroup name="validateButtonItemContent">
3031
<arguments>

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/buttons/_default.less

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,11 @@
1212

1313
.pagebuilder-content-type-wrapper {
1414
display: inline-block;
15-
vertical-align: baseline;
15+
vertical-align: middle;
1616
width: initial;
1717
}
18+
19+
> .element-children {
20+
width: 100%;
21+
}
1822
}

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/buttons/inline/preview.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
<div class="pagebuilder-content-type pagebuilder-entity pagebuilder-entity-preview pagebuilder-no-blur pagebuilder-live-edit pagebuilder-buttons" event="{ mouseover: onMouseOver, mouseout: onMouseOut }, mouseoverBubble: false">
99
<render args="getOptions().template" />
10-
<div class="element-children buttons-container" each="parent.getChildren()" attr="Object.assign({}, data.main.attributes(), { id: parent.id + '-children' })" ko-style="data.main.style" css="data.main.css" data-bind="sortableChildren: { tolerance: 'pointer', handle: '.move-structural', items: '.pagebuilder-content-type-wrapper', connectWith: '.buttons-container', forceRefresh: true }">
10+
<div class="element-children buttons-container" each="parent.getChildren()" attr="Object.assign({}, data.main.attributes(), { id: parent.id + '-children' })" ko-style="data.main.style" css="data.main.css" data-bind="sortableChildren: { handle: '.move-structural', items: '.pagebuilder-content-type-wrapper', connectWith: '.buttons-container', appendTo: 'body' }">
1111
<div class="pagebuilder-content-type-wrapper" template="{ name: preview.previewTemplate, data: preview }" attr="{ id: id }"></div>
1212
</div>
1313
</div>

0 commit comments

Comments
 (0)