Skip to content

Commit 2b1a336

Browse files
committed
MC-42779: Error on page builder when adding products for users not having admin access
1 parent 2058e3e commit 2b1a336

File tree

2 files changed

+11
-28
lines changed

2 files changed

+11
-28
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/TemplateData.xml

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -84,25 +84,6 @@
8484
<item name="Magento_PageBuilder::templates">Magento_PageBuilder::templates</item>
8585
</array>
8686
</entity>
87-
<entity name="rolePageBuilderProductWidgetEdit" type="user_role" extends="adminRestrictedProductRole">
88-
<data key="name" unique="suffix">Role_Page_Builder_Product_Widget_</data>
89-
<data key="rolename" unique="suffix">Role_Page_Builder_Product_Widget_</data>
90-
<data key="current_password">{{_ENV.MAGENTO_ADMIN_PASSWORD}}</data>
91-
<data key="all">0</data>
92-
<data key="gws_is_all">0</data>
93-
<array key="gws_websites">
94-
<item>1</item>
95-
</array>
96-
<array key="resource">
97-
<item name="Magento_Backend::dashboard">Magento_Backend::dashboard</item>
98-
<item name="Magento_Backend::content">Magento_Backend::content</item>
99-
<item name="Magento_Backend::content_elements">Magento_Backend::content_elements</item>
100-
<item name="Magento_Cms::page">Magento_Cms::page</item>
101-
<item name="Magento_Cms::save">Magento_Cms::save</item>
102-
<item name="Magento_Cms::save_design">Magento_Cms::save_design</item>
103-
<item name="Magento_Widget::widget_instance">Magento_Widget::widget_instance</item>
104-
</array>
105-
</entity>
10687
<entity name="rolePageBuilderSaveTemplates" type="user_role" extends="adminRestrictedProductRole">
10788
<data key="name" unique="suffix">Role_Page_Builder_Save_Templates_</data>
10889
<data key="rolename" unique="suffix">Role_Page_Builder_Save_Templates_</data>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsCarouselTest/AdminPageBuilderProductsCarouselDisplayProductCountForRestrictedAdminTest.xml

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,23 @@
2323

2424
<before>
2525
<!-- Create a restricted role with access only to CMS and Widgets -->
26-
<createData entity="rolePageBuilderProductWidgetEdit" after="createCMSPage" stepKey="createRestrictedRole"/>
26+
<actionGroup ref="AdminCreateRoleActionGroup" after="loginAsAdmin" stepKey="createRestrictedRole">
27+
<argument name="restrictedRole" value="Content"/>
28+
<argument name="User" value="adminRole"/>
29+
</actionGroup>
2730

2831
<!-- Create an restricted admin user assigned to role -->
29-
<actionGroup ref="AdminCreateUserWithApiRoleActionGroup" after="loginAsAdmin" stepKey="adminCreateUser">
30-
<argument name="user" value="NewAdminUser"/>
31-
<argument name="role" value="rolePageBuilderProductWidgetEdit"/>
32+
<actionGroup ref="AdminCreateUserActionGroup" after="createRestrictedRole" stepKey="adminCreateUser">
33+
<argument name="role" value="adminRole"/>
3234
</actionGroup>
3335

3436
<!-- Log out main Admin user -->
3537
<actionGroup ref="AdminLogoutActionGroup" after="adminCreateUser" stepKey="adminLogout"/>
3638

3739
<!-- Log in restricted Admin user -->
3840
<actionGroup ref="AdminLoginActionGroup" after="adminLogout" stepKey="loginAsRestrictedAdmin">
39-
<argument name="username" value="{{NewAdminUser.username}}"/>
40-
<argument name="password" value="{{NewAdminUser.password}}"/>
41+
<argument name="username" value="{{newAdmin.username}}"/>
42+
<argument name="password" value="{{newAdmin.password}}"/>
4143
</actionGroup>
4244
</before>
4345

@@ -47,12 +49,12 @@
4749

4850
<!-- Delete restricted Admin user -->
4951
<actionGroup ref="AdminDeleteCustomUserActionGroup" after="loginAsAdmin" stepKey="deleteUser">
50-
<argument name="user" value="NewAdminUser"/>
52+
<argument name="user" value="newAdmin"/>
5153
</actionGroup>
5254

5355
<!-- Delete restricted role -->
54-
<actionGroup ref="AdminDeleteRoleByRoleNameActionGroup" after="deleteUser" stepKey="deleteRestrictedRole">
55-
<argument name="role" value="rolePageBuilderProductWidgetEdit"/>
56+
<actionGroup ref="AdminDeleteUserRoleActionGroup" after="deleteUser" stepKey="deleteRestrictedRole">
57+
<argument name="roleName" value="{{adminRole.name}}"/>
5658
</actionGroup>
5759

5860
<!-- Log out the restricted Admin User -->

0 commit comments

Comments
 (0)