Skip to content

Commit 2b10a04

Browse files
committed
#511: Content Snapshot on Product Page in Admin Panel
- Code Review Feedback/Amends
1 parent c2391eb commit 2b10a04

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

app/code/Magento/PageBuilder/Plugin/Catalog/Ui/DataProvider/Product/Form/Modifier/EavPlugin.php

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,14 @@
1010

1111
use Magento\Catalog\Api\Data\ProductAttributeInterface;
1212
use Magento\Catalog\Ui\DataProvider\Product\Form\Modifier\Eav as EavModifier;
13-
use Magento\Framework\Exception\NoSuchEntityException;
14-
use Magento\Framework\Exception\NotFoundException;
1513
use Magento\Framework\Stdlib\ArrayManager;
1614

15+
/**
16+
* Data Provider for EAV Attributes on Product Page
17+
*/
1718
class EavPlugin
1819
{
19-
const META_ATTRIBUTE_CONFIG_PATH = 'arguments/data/config';
20+
public const META_ATTRIBUTE_CONFIG_PATH = 'arguments/data/config';
2021

2122
/**
2223
* @var ArrayManager
@@ -32,6 +33,8 @@ public function __construct(ArrayManager $arrayManager)
3233
}
3334

3435
/**
36+
* Setup Attribute Meta
37+
*
3538
* @param EavModifier $subject
3639
* @param array $result
3740
* @param ProductAttributeInterface $attribute
@@ -63,6 +66,8 @@ public function afterSetupAttributeMeta(
6366
}
6467

6568
/**
69+
* Setup Attribute Container Meta
70+
*
6671
* @param EavModifier $subject
6772
* @param array $result
6873
* @param ProductAttributeInterface $attribute

app/code/Magento/PageBuilder/etc/adminhtml/di.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -623,4 +623,7 @@
623623
<type name="Magento\Framework\Filter\Template">
624624
<plugin name="convertBackgroundImages" type="Magento\PageBuilder\Plugin\Filter\TemplatePlugin"/>
625625
</type>
626+
<type name="Magento\Catalog\Ui\DataProvider\Product\Form\Modifier\Eav">
627+
<plugin name="pagebuilder_product_form_eav" type="Magento\PageBuilder\Plugin\Catalog\Ui\DataProvider\Product\Form\Modifier\EavPlugin" sortOrder="20"/>
628+
</type>
626629
</config>

app/code/Magento/PageBuilder/etc/di.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,4 @@
338338
<argument name="instanceName" xsi:type="string">Magento\PageBuilder\Model\Dom\HtmlDocument</argument>
339339
</arguments>
340340
</virtualType>
341-
<type name="Magento\Catalog\Ui\DataProvider\Product\Form\Modifier\Eav">
342-
<plugin name="pagebuilder_product_form_eav" type="Magento\PageBuilder\Plugin\Catalog\Ui\DataProvider\Product\Form\Modifier\EavPlugin" sortOrder="20"/>
343-
</type>
344341
</config>

0 commit comments

Comments
 (0)