Skip to content

Commit 2a150a0

Browse files
committed
MC-5079: Add Box Sizing to Storefront Styles (Border & Height Storefront Issues)
- more descriptive titles - remove unnecessary row argument
1 parent 359bbe5 commit 2a150a0

9 files changed

+9
-10
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageLeftAppearanceTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -920,7 +920,7 @@
920920
<annotations>
921921
<features value="PageBuilder"/>
922922
<stories value="Banner"/>
923-
<title value="Collage Left - Banner height is equal to min height"/>
923+
<title value="Collage Left - Banner with borders and padding is equal to min height"/>
924924
<description value="A user can see Banner collage left height with borders and padding is equal to min height"/>
925925
<severity value="CRITICAL"/>
926926
<useCaseId value="MC-5079"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerPosterAppearanceTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1614,7 +1614,7 @@
16141614
<annotations>
16151615
<features value="PageBuilder"/>
16161616
<stories value="Banner"/>
1617-
<title value="Poster - Height is equal to min height"/>
1617+
<title value="Poster - Banner with borders and padding is equal to min height"/>
16181618
<description value="A user can see Banner poster height with borders and padding is equal to min height"/>
16191619
<severity value="CRITICAL"/>
16201620
<useCaseId value="MC-5079"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@
181181
<annotations>
182182
<features value="PageBuilder"/>
183183
<stories value="Column"/>
184-
<title value="Column height is equal to minimum height"/>
184+
<title value="Column with borders and padding is equal to min height"/>
185185
<description value="A user can see Column height with borders and padding is equal to min height"/>
186186
<severity value="CRITICAL"/>
187187
<useCaseId value="MC-5079"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowLayoutTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@
153153
<annotations>
154154
<features value="PageBuilder"/>
155155
<stories value="Row"/>
156-
<title value="Row height is equal to min height"/>
156+
<title value="Row with borders and padding is equal to min height"/>
157157
<description value="A user can see Row height with borders and padding is equal to min height"/>
158158
<severity value="CRITICAL"/>
159159
<useCaseId value="MC-5079"/>
@@ -177,7 +177,6 @@
177177
<comment userInput="Configure content type" stepKey="commentConfigureContentType"/>
178178
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditPanel">
179179
<argument name="contentType" value="PageBuilderRowContentType"/>
180-
<argument name="contentTypeIndex" value="1"/>
181180
</actionGroup>
182181
<actionGroup ref="fillSlideOutPanelField" stepKey="enterMinHeightProperty">
183182
<argument name="property" value="PageBuilderMinHeightProperty_300"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageLeftTests.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,7 @@
506506
<annotations>
507507
<features value="PageBuilder"/>
508508
<stories value="Slider"/>
509-
<title value="Collage Left - Slide height is equal to min height"/>
509+
<title value="Collage Left - Slide with borders and padding is equal to min height"/>
510510
<description value="A user can see collage left Slide height with borders and padding is equal to min height"/>
511511
<severity value="CRITICAL"/>
512512
<useCaseId value="MC-5079"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearancePosterTests.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1370,7 +1370,7 @@
13701370
<annotations>
13711371
<features value="PageBuilder"/>
13721372
<stories value="Slider"/>
1373-
<title value="Poster - Height is equal to min height"/>
1373+
<title value="Poster - Slide with borders and padding is equal to min height"/>
13741374
<description value="A user can see poster Slide height with borders and padding is equal to min height"/>
13751375
<severity value="CRITICAL"/>
13761376
<useCaseId value="MC-5079"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSliderCommonTests.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -560,7 +560,7 @@
560560
<annotations>
561561
<features value="PageBuilder"/>
562562
<stories value="Slider"/>
563-
<title value="Slider - Height is equal to min height"/>
563+
<title value="Slider - Slider with borders and padding is equal to min height"/>
564564
<description value="A user can see Slider height with borders and padding is equal to min height"/>
565565
<severity value="CRITICAL"/>
566566
<useCaseId value="MC-5079"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabGroupTests.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@
306306
<annotations>
307307
<features value="PageBuilder"/>
308308
<stories value="Tab"/>
309-
<title value="Tabs Group - Height is equal to min height"/>
309+
<title value="Tabs Group - Tabs with borders and padding is equal to min height"/>
310310
<description value="A user can see Tab group height with borders and padding is equal to min height"/>
311311
<severity value="CRITICAL"/>
312312
<useCaseId value="MC-5079"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabItemLayoutTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@
172172
<annotations>
173173
<features value="PageBuilder"/>
174174
<stories value="Tab"/>
175-
<title value="Tab Item - Height is equal to min height"/>
175+
<title value="Tab Item - Tab with borders and padding is equal to min height"/>
176176
<description value="A user can see Tab Item height with borders and padding is equal to min height"/>
177177
<severity value="CRITICAL"/>
178178
<useCaseId value="MC-5079"/>

0 commit comments

Comments
 (0)