Skip to content

Commit 28ed1ca

Browse files
hannahnidahannahnida
committed
#436: Cannot Drag and Drop Image to Upload Area in Banner, Slide in Safari, IE11 - Added new MFTF Tests for Slider and Banner
1 parent a7a6e33 commit 28ed1ca

File tree

4 files changed

+139
-68
lines changed

4 files changed

+139
-68
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest/BannerBackgroundImageInvalidFileTypeValidationTest.xml

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
10+
<test name="BannerBackgroundImageInvalidFileTypeTest">
11+
<annotations>
12+
<features value="PageBuilder"/>
13+
<stories value="Banner"/>
14+
<title value="Banner Background Image - Invalid File Type"/>
15+
<description value="Tests that the Background Image Validation functions as expected for invalid file type"/>
16+
<severity value="AVERAGE"/>
17+
<group value="pagebuilder"/>
18+
<group value="pagebuilder-banner"/>
19+
<group value="pagebuilder-bannerCommon"/>
20+
</annotations>
21+
<before>
22+
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
23+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
24+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
25+
</before>
26+
<after>
27+
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
28+
</after>
29+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
30+
<argument name="contentType" value="PageBuilderBannerContentType"/>
31+
</actionGroup>
32+
<comment userInput="Add Banner Background Image to Stage" stepKey="commentAddBannerToStage"/>
33+
<actionGroup ref="expandPageBuilderPanelMenuSection" stepKey="expandPageBuilderPanelMenuSection">
34+
<argument name="contentType" value="PageBuilderBannerContentType"/>
35+
</actionGroup>
36+
<actionGroup ref="dragContentTypeToStage" stepKey="dragBannerContentTypeToStage">
37+
<argument name="contentType" value="PageBuilderBannerContentType"/>
38+
</actionGroup>
39+
<actionGroup ref="addInvalidBannerBackgroundToStage" stepKey="addInvalidBannerBackgroundToStage">
40+
<argument name="property" value="PageBuilderImage_InvalidFileType"/>
41+
<argument name="section" value="BannerOnBackend"/>
42+
<argument name="sectionArea" value="BannerOnBackend.base('1')"/>
43+
<argument name="attachInput" value="BannerOnBackend.uploadImageInput"/>
44+
<argument name="imagePreview" value="BannerOnBackend.backgroundImage('1', PageBuilderImage_InvalidFileType.fileName)"/>
45+
<argument name="imageSource" value="BannerOnBackend.imageSourceByIndex('1', PageBuilderImage_InvalidFileType.fileName)"/>
46+
</actionGroup>
47+
</test>
48+
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderImageTest/ImageInvalidFileTypeValidationTest.xml

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
10+
<test name="ImageInvalidFileTypeValidationTest">
11+
<annotations>
12+
<features value="PageBuilder"/>
13+
<stories value="Image"/>
14+
<title value="Image Invalid File Type Validation"/>
15+
<description value="Tests that the Image Validation functions as expected for invalid file type"/>
16+
<severity value="AVERAGE"/>
17+
<group value="pagebuilder"/>
18+
<group value="pagebuilder-image"/>
19+
</annotations>
20+
<before>
21+
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
22+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
23+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
24+
</before>
25+
<after>
26+
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
27+
</after>
28+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
29+
<argument name="contentType" value="PageBuilderImageContentType"/>
30+
</actionGroup>
31+
<comment userInput="Add Image to Stage" stepKey="commentAddImageToStage"/>
32+
<actionGroup ref="expandPageBuilderPanelMenuSection" stepKey="expandPageBuilderPanelMenuSection">
33+
<argument name="contentType" value="PageBuilderImageContentType"/>
34+
</actionGroup>
35+
<actionGroup ref="dragContentTypeToStage" stepKey="dragImageContentTypeToStage">
36+
<argument name="contentType" value="PageBuilderImageContentType"/>
37+
</actionGroup>
38+
<actionGroup ref="addInvalidImageToStage" stepKey="addInvalidImageToStage">
39+
<argument name="property" value="PageBuilderImage_InvalidFileType"/>
40+
<argument name="imageSource" value="ImageOnStageWithoutImageUploaded.imageSource(PageBuilderImage_InvalidFileType.fileName)"/>
41+
</actionGroup>
42+
</test>
43+
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderImageTest/ImageInvalidTypeValidationTest.xml

Lines changed: 0 additions & 68 deletions
This file was deleted.

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemCommonTest/SlideItemBackgroundImageInvalidFileTypeValidationTest.xml

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
10+
<test name="SlideItemBackgroundImageInvalidFileTypeValidationTest">
11+
<annotations>
12+
<features value="PageBuilder"/>
13+
<stories value="Slider"/>
14+
<title value="Slide Item Background Image - Invalid File Type"/>
15+
<description value="Tests that the Slide Item Background Image Validation functions as expected for invalid file type"/>
16+
<severity value="AVERAGE"/>
17+
<group value="pagebuilder"/>
18+
<group value="pagebuilder-slide"/>
19+
<group value="pagebuilder-slideItemCommon"/>
20+
</annotations>
21+
<before>
22+
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
23+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
24+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
25+
</before>
26+
<after>
27+
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
28+
</after>
29+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
30+
<argument name="contentType" value="PageBuilderSliderContentType"/>
31+
</actionGroup>
32+
<comment userInput="Add Slide Item Background Image to Stage" stepKey="commentAddBannerToStage"/>
33+
<actionGroup ref="expandPageBuilderPanelMenuSection" stepKey="expandPageBuilderPanelMenuSection">
34+
<argument name="contentType" value="PageBuilderSliderContentType"/>
35+
</actionGroup>
36+
<actionGroup ref="dragContentTypeToStage" stepKey="dragBannerContentTypeToStage">
37+
<argument name="contentType" value="PageBuilderSliderContentType"/>
38+
</actionGroup>
39+
<actionGroup ref="addInvalidSliderBackgroundToStage" stepKey="addInvalidSliderBackgroundToStage">
40+
<argument name="property" value="PageBuilderImage_InvalidFileType"/>
41+
<argument name="section" value="SlideOnBackend"/>
42+
<argument name="sectionArea" value="SlideOnBackend.base('1')"/>
43+
<argument name="attachInput" value="SlideOnBackend.uploadImageInput"/>
44+
<argument name="imagePreview" value="SlideOnBackend.backgroundImage('1', PageBuilderImage_InvalidFileType.fileName)"/>
45+
<argument name="imageSource" value="SlideOnBackend.imageSourceByIndex('1', PageBuilderImage_InvalidFileType.fileName)"/>
46+
</actionGroup>
47+
</test>
48+
</tests>

0 commit comments

Comments
 (0)