MC-15022: HTML Content type does not render self closing html tags on storefront

danmooney2 · danmooney2 · commit 25f798c629bb · 2019-02-26T08:30:57.000-06:00
Use single quote concat
diff --git a/app/code/Magento/PageBuilder/Plugin/Filter/TemplatePlugin.php b/app/code/Magento/PageBuilder/Plugin/Filter/TemplatePlugin.php
@@ -88,7 +88,11 @@ public function afterFilter(\Magento\Framework\Filter\Template $subject, string
 
                 if (isset($uniqueNodeNameToDecodedOuterHtmlMap)) {
                     foreach ($uniqueNodeNameToDecodedOuterHtmlMap as $uniqueNodeName => $decodedOuterHtml) {
-                        $docHtml = str_replace("<$uniqueNodeName></$uniqueNodeName>", $decodedOuterHtml, $docHtml);
+                        $docHtml = str_replace(
+                            '<' . $uniqueNodeName . '>' . '</' . $uniqueNodeName . '>',
+                            $decodedOuterHtml,
+                            $docHtml
+                        );
                     }
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,11 @@ public function afterFilter(\Magento\Framework\Filter\Template $subject, string`
`88`	`88`
`89`	`89`	`if (isset($uniqueNodeNameToDecodedOuterHtmlMap)) {`
`90`	`90`	`foreach ($uniqueNodeNameToDecodedOuterHtmlMap as $uniqueNodeName => $decodedOuterHtml) {`
`91`		`- $docHtml = str_replace("<$uniqueNodeName></$uniqueNodeName>", $decodedOuterHtml, $docHtml);`
	`91`	`+ $docHtml = str_replace(`
	`92`	`+ '<' . $uniqueNodeName . '>' . '</' . $uniqueNodeName . '>',`
	`93`	`+ $decodedOuterHtml,`
	`94`	`+ $docHtml`
	`95`	`+ );`
`92`	`96`	`}`
`93`	`97`	`}`
`94`	`98`