Skip to content

Commit 25c6fd3

Browse files
committed
Merge remote-tracking branch 'remotes/origin/MAGETWO-92324' into team3-delivery-tech-debt
2 parents 68388a7 + 8a71853 commit 25c6fd3

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderImageSection.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@
4646
<element name="base" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]" parameterized="true"/>
4747
<element name="attachImageBtn" type="button" selector="//div[@class='pagebuilder-image-uploader-container']//input[@name='image']" />
4848
<element name="imageContentTypeByIndex" type="button" selector="//div[contains(@class, 'pagebuilder-content-type') and contains(@class, 'pagebuilder-image')][1]//img[contains(@src,'{{var1}}')]" parameterized="true"/>
49-
<element name="imagePreview" type="button" selector="//div[@class='preview-image-container']" />
49+
<element name="imageEmptyPreview" type="text" selector="//div[contains(concat(' ', normalize-space(@class), ' '), ' pagebuilder-image-empty-preview ')]" />
50+
<element name="imagePreview" type="text" selector="//img[contains(concat(' ', normalize-space(@class), ' '), ' preview-image ')]" />
5051
<element name="imageSourceOnStage" type="text" selector="//img[contains(@src,'{{var1}}')]" parameterized="true" />
5152
<element name="selectFromGalleryBtn" type="button" selector="//figure//div[@class='file-uploader-area']//label[text()='Select from Gallery']"/>
5253
<element name="selectFromGalleryImageBtn" type="button" selector="//ul[@class='pagebuilder-options-links']//label[text()='Select from Gallery']"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderImageTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -593,7 +593,7 @@
593593
</actionGroup>
594594
<!-- Validate Stage -->
595595
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
596-
<seeElement selector="{{ImageOnStage.imagePreview}}" stepKey="seeImagePreview"/>
596+
<seeElement selector="{{ImageOnStage.imageEmptyPreview}}" stepKey="seeImageEmptyPreview"/>
597597
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
598598
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
599599
<argument name="contentType" value="PageBuilderImageContentType"/>

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/image/full-width/preview.html

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,15 @@
77

88
<div class="pagebuilder-content-type pagebuilder-image type-nested" event="{ mouseover: onMouseOver, mouseout: onMouseOut }, mouseoverBubble: false">
99
<render args="getOptions().template" />
10-
<figure ko-style="data.main.style" attr="data.main.attributes" css="data.main.css">
10+
<figure attr="data.main.attributes" ko-style="data.main.style" css="data.main.css">
1111
<scope args="getUploader().getUiComponent()">
1212
<render />
1313
</scope>
14-
<div class="preview-image-container">
15-
<img if="data.desktop_image.attributes().src"
16-
attr="data.desktop_image.attributes"
17-
class="preview-image"
18-
css="data.desktop_image.css"
19-
ko-style="data.desktop_image.style" />
20-
</div>
14+
<img if="data.desktop_image.attributes().src"
15+
attr="data.desktop_image.attributes"
16+
class="preview-image"
17+
css="data.desktop_image.css"
18+
ko-style="data.desktop_image.style" />
2119
<figcaption if="data.caption.html()"
2220
attr="data.caption.attributes"
2321
css="data.caption.css"

0 commit comments

Comments
 (0)