Skip to content

Commit 25ba357

Browse files
Merge branch 'develop' into Arrows_platform_health_Extjs
2 parents 84815af + 36a0256 commit 25ba357

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

.github/CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ For more detailed information on contribution please read our [beginners guide](
2121
1. PRs which include bug fixes must be accompanied with a step-by-step description of how to reproduce the bug.
2222
1. PRs which include new logic or new features must be submitted along with:
2323
* Unit/integration test coverage
24-
* Proposed [documentation](https://devdocs.magento.com) updates. Documentation contributions can be submitted via the [devdocs GitHub](https://github.com/magento/devdocs).
24+
* Proposed [documentation](https://developer.adobe.com/commerce) updates. Use feedback buttons __Edit in GitHub__ and __Log an issue__ at the top of a relevant topic.
2525
1. For larger features or changes, please [open an issue](https://github.com/magento/magento2-page-builder/issues) to discuss the proposed changes prior to development. This may prevent duplicate or unnecessary effort and allow other contributors to provide input.
2626

2727
## Contribution process

app/code/Magento/PageBuilder/Test/Mftf/Test/StorefrontReviewWithProductFullWidthLayoutTest.xml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
<severity value="BLOCKER"/>
1818
<useCaseId value="MC-18071"/>
1919
<testCaseId value="MC-19606"/>
20-
<skip>
21-
<issueId value="MQE-3442"/>
22-
</skip>
2320
<group value="pagebuilder"/>
2421
<group value="pagebuilder-layout"/>
2522
<group value="pagebuilder-fullwidth"/>
@@ -72,12 +69,10 @@
7269
<actionGroup ref="StorefrontOpenProductPageActionGroup" stepKey="openCreatedProductPage">
7370
<argument name="productUrl" value="$$createProduct.custom_attributes[url_key]$$"/>
7471
</actionGroup>
75-
<!-- Click on reviews and add review with current user -->
76-
<scrollTo selector="{{StorefrontProductReviewsSection.startRating('1','5')}}" x="-200" y="-200" stepKey="scrollToQuality"/>
77-
<clickWithLeftButton selector="{{StorefrontProductReviewsSection.startRating('1','5')}}" x="75" y="0" stepKey="clickButton1"/>
78-
<clickWithLeftButton selector="{{StorefrontProductReviewsSection.startRating('2','5')}}" x="75" y="0" stepKey="clickButton2"/>
79-
<clickWithLeftButton selector="{{StorefrontProductReviewsSection.startRating('3','5')}}" x="75" y="0" stepKey="clickButton3"/>
80-
72+
<comment userInput="BIC workaround" stepKey="scrollToQuality"/>
73+
<comment userInput="BIC workaround" stepKey="clickButton1"/>
74+
<comment userInput="BIC workaround" stepKey="clickButton2"/>
75+
<comment userInput="BIC workaround" stepKey="clickButton3"/>
8176
<actionGroup ref="StorefrontAddProductReviewProductFullWidthLayoutActionGroup" stepKey="addReview"/>
8277
<!-- Go to "Pending reviews" page and clear filters -->
8378
<actionGroup ref="AdminOpenPendingReviewsPageActionGroup" stepKey="openReviewsPage"/>

0 commit comments

Comments
 (0)