PB-166: Page Builder doesn't implement destroy method

Author: omiroshnichenko

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/column-group/preview.js

@@ -108,7 +108,7 @@ export default class Preview extends PreviewCollection {
         }, "grid_size");
 
         events.on("contentType:removeAfter", (args: ContentTypeRemovedEventParamsInterface) => {
-            if (args.parentContentType.id === this.contentType.id) {
+            if (args.parentContentType && args.parentContentType.id === this.contentType.id) {
                 _.defer(() => {
                     this.spreadWidth(args.index);
                 });

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slider/preview.js

@@ -46,6 +46,7 @@ export default class Preview extends PreviewCollection {
     private navigationElement: HTMLElement;
     private ready: boolean = false;
     private childSubscribe: KnockoutSubscription;
+    private focusedSlideSubscriber: KnockoutSubscription;
     private contentTypeHeightReset: boolean;
     private mountAfterDeferred: DeferredInterface = deferred();
     private afterChildrenRenderDeferred: DeferredInterface = deferred();
@@ -114,7 +115,7 @@ export default class Preview extends PreviewCollection {
                     });
 
                     // Set the stage to interacting when a slide is focused
-                    this.focusedSlide.subscribe((value: number) => {
+                    this.focusedSlideSubscriber = this.focusedSlide.subscribe((value: number) => {
                         if (value !== null) {
                             events.trigger("stage:interactionStart");
                         } else {
@@ -334,6 +335,15 @@ export default class Preview extends PreviewCollection {
         this.setFocusedSlide(index);
     }
 
+    /**
+     * @inheritdoc
+     */
+    public destroy(): void {
+        super.destroy();
+        this.setFocusedSlide(null);
+        this.focusedSlideSubscriber.dispose();
+    }
+
     /**
      * Bind events
      */
@@ -360,7 +370,7 @@ export default class Preview extends PreviewCollection {
         // we need to force update the content of the slider due to KO rendering issues
         let newItemIndex: number;
         events.on("slide:removeAfter", (args: ContentTypeRemovedEventParamsInterface) => {
-            if (args.contentType.parentContentType.id === this.contentType.id) {
+            if (args.parentContentType && args.parentContentType.id === this.contentType.id) {
                 // Mark the previous slide as active
                 newItemIndex = (args.index - 1 >= 0 ? args.index - 1 : 0);
 

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/tabs/preview.js

@@ -94,7 +94,7 @@ export default class Preview extends PreviewCollection {
         });
         // Set the active tab to the new position of the sorted tab
         events.on("tab-item:removeAfter", (args: ContentTypeRemovedEventParamsInterface) => {
-            if (args.parentContentType.id === this.contentType.id) {
+            if (args.parentContentType && args.parentContentType.id === this.contentType.id) {
                 this.refreshTabs();
 
                 // We need to wait for the tabs to refresh before executing the focus
@@ -394,7 +394,7 @@ export default class Preview extends PreviewCollection {
         });
         // ContentType being removed from container
         events.on("tab-item:removeAfter", (args: ContentTypeRemovedParamsInterface) => {
-            if (args.parentContentType.id === this.contentType.id) {
+            if (args.parentContentType && args.parentContentType.id === this.contentType.id) {
                 // Mark the previous tab as active
                 const newIndex = (args.index - 1 >= 0 ? args.index - 1 : 0);
                 this.refreshTabs(newIndex, true);