Skip to content

Commit 2326325

Browse files
committed
ACP2E-2957: refresh image thumbnail when an image with same name is re-uploaded
1 parent 4a2795e commit 2326325

File tree

5 files changed

+40
-49
lines changed

5 files changed

+40
-49
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/ImageData.xml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,16 @@
6464
<data key="extension">jpg</data>
6565
<data key="path">wysiwyg</data>
6666
</entity>
67+
<entity name="PageBuilderImagePropertyJpgCopyOtherFolder" type="pagebuilder_image_property">
68+
<data key="name">Image</data>
69+
<data key="section">general</data>
70+
<data key="fieldName">image</data>
71+
<data key="value">magento.jpg</data>
72+
<data key="file">duplicatesamename/magento.jpg</data>
73+
<data key="fileName">magento</data>
74+
<data key="extension">jpg</data>
75+
<data key="path">wysiwyg</data>
76+
</entity>
6777
<entity name="PageBuilderBackgroundImagePropertyJpg" type="pagebuilder_image_property">
6878
<data key="name">Image</data>
6979
<data key="section">background</data>

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/image/preview.js

Lines changed: 16 additions & 33 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/utils/image.js

Lines changed: 8 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/image/preview.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,12 @@ export default class Preview extends BasePreview {
5959
public getViewportImageData() {
6060
const desktopImageData = this.data.desktop_image;
6161
const mobileImageData = this.data.mobile_image;
62-
return this.viewport() === "mobile" && typeof mobileImageData !== "undefined"
62+
const result = this.viewport() === "mobile" && typeof mobileImageData !== "undefined"
6363
? mobileImageData : desktopImageData;
64+
if (result && result.attributes() && result.attributes().src.length > 0 && result.attributes().src.indexOf("?rand") === -1) {
65+
result.attributes().src += "?rand=" + Date.now();
66+
}
67+
return result;
6468
}
6569

6670
/**

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/utils/image.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import {convertUrlToPathIfOtherUrlIsOnlyAPath} from "./url";
1717
export function decodeUrl(value: string): string | [object] {
1818
let result: any = "";
1919
value = decodeURIComponent((value).replace(window.location.href, ""));
20-
const regexp = /{{.*\s*url="?(.*\.([a-z|A-Z]*))"?\s*}}/;
20+
const regexp = /{{.*\s*url="?(.*\.([a-z|A-Z|0-9?=]*))\"?\s*}}/;
2121
if (regexp.test(value)) {
2222
const [, url, type] = regexp.exec(value);
2323
const image = {

0 commit comments

Comments
 (0)