Skip to content

Commit 22b27aa

Browse files
davemacaulaydavemacaulay
committed
MC-3895: Banner and Slide has an overlay transparency field that needs to be removed in favor of transparent color
- Update banner tests to use new field
1 parent 0d5643f commit 22b27aa

File tree

4 files changed

+22
-57
lines changed

4 files changed

+22
-57
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Data/BannerData.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -242,12 +242,4 @@
242242
<data key="value">rgba(174, 198, 207, 0.7)</data>
243243
<data key="rgb">rgba(174, 198, 207, 0.7)</data>
244244
</entity>
245-
<!-- Overlay Transparency -->
246-
<entity name="PageBuilderBannerOverlayTransparencyProperty" type="pagebuilder_banner_overlayTransparency_property">
247-
<data key="name">Overlay Transparency</data>
248-
<data key="section">contents</data>
249-
<data key="fieldName">overlay_transparency</data>
250-
<data key="value">70</data>
251-
<data key="decimal">0.7</data>
252-
</entity>
253245
</entities>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageLeftAppearanceTest.xml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -640,10 +640,7 @@
640640
<argument name="property" value="PageBuilderBannerShowContentOverlayAlwaysProperty"/>
641641
</actionGroup>
642642
<actionGroup ref="fillSlideOutPanelField" stepKey="enterOverlayColor">
643-
<argument name="property" value="PageBuilderBannerOverlayColor_FF0000"/>
644-
</actionGroup>
645-
<actionGroup ref="fillSlideOutPanelField" stepKey="enterOverlayTransparency">
646-
<argument name="property" value="PageBuilderBannerOverlayTransparencyProperty"/>
643+
<argument name="property" value="PageBuilderBannerOverlayColor_Blue_Opaque"/>
647644
</actionGroup>
648645
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
649646
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest.xml

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1527,10 +1527,7 @@
15271527
<argument name="property" value="PageBuilderBannerShowContentOverlayAlwaysProperty"/>
15281528
</actionGroup>
15291529
<actionGroup ref="fillSlideOutPanelField" stepKey="enterOverlayColor">
1530-
<argument name="property" value="PageBuilderBannerOverlayColor_FF0000"/>
1531-
</actionGroup>
1532-
<actionGroup ref="fillSlideOutPanelField" stepKey="enterOverlayTransparency">
1533-
<argument name="property" value="PageBuilderBannerOverlayTransparencyProperty"/>
1530+
<argument name="property" value="PageBuilderBannerOverlayColor_Blue_Opaque"/>
15341531
</actionGroup>
15351532
<!-- Update Advanced Section -->
15361533
<comment userInput="Update Advanced Section" stepKey="commentUpdateAdvancedSection"/>
@@ -1605,7 +1602,7 @@
16051602
<seeElement selector="{{BannerOnBackend.buttonType('2', PageBuilderBannerButtonTypeSecondaryProperty.value)}}" stepKey="seeButtonTypeStage"/>
16061603
<seeElement selector="{{BannerOnBackend.buttonText('2', PageBuilderBannerButtonTextProperty2.value)}}" stepKey="seeButtonTextStage"/>
16071604
<seeElement selector="{{BannerOnBackend.showOverlay('2', PageBuilderBannerShowContentOverlayAlwaysProperty.value)}}" stepKey="seeOverlayStateStage"/>
1608-
<seeElement selector="{{BannerOnBackend.overlayColorAndTransparency('2', PageBuilderBannerOverlayColor_FF0000.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayColorAndTransparencyStage"/>
1605+
<seeElement selector="{{BannerOnBackend.overlayBackgroundColor('2', PageBuilderBannerOverlayColor_Blue_Opaque.value)}}" stepKey="seeOverlayBackgroundStage"/>
16091606
<seeElement selector="{{BannerOnBackend.alignment('2', PageBuilderAdvancedAlignmentPropertyCenter.value)}}" stepKey="seeAlignmentStage"/>
16101607
<seeElement selector="{{BannerOnBackend.border('2', PageBuilderAdvancedBorderPropertyDouble.value)}}" stepKey="seeBorderStage"/>
16111608
<seeElement selector="{{BannerOnBackend.borderColor('2', PageBuilderAdvancedBorderColorProperty_green.rgb)}}" stepKey="seeBorderColorStage"/>
@@ -1643,7 +1640,7 @@
16431640
<seeElement selector="{{BannerOnBackend.buttonType('2', PageBuilderBannerButtonTypeSecondaryProperty.value)}}" stepKey="seeButtonTypeStage2"/>
16441641
<seeElement selector="{{BannerOnBackend.buttonText('2', PageBuilderBannerButtonTextProperty2.value)}}" stepKey="seeButtonTextStage2"/>
16451642
<seeElement selector="{{BannerOnBackend.showOverlay('2', PageBuilderBannerShowContentOverlayAlwaysProperty.value)}}" stepKey="seeOverlayStateStage2"/>
1646-
<seeElement selector="{{BannerOnBackend.overlayColorAndTransparency('2', PageBuilderBannerOverlayColor_FF0000.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayColorAndTransparencyStage2"/>
1643+
<seeElement selector="{{BannerOnBackend.overlayBackgroundColor('2', PageBuilderBannerOverlayColor_Blue_Opaque.value)}}" stepKey="seeOverlayBackgroundStorefront2"/>
16471644
<seeElement selector="{{BannerOnBackend.alignment('2', PageBuilderAdvancedAlignmentPropertyCenter.value)}}" stepKey="seeAlignmentStage2"/>
16481645
<seeElement selector="{{BannerOnBackend.border('2', PageBuilderAdvancedBorderPropertyDouble.value)}}" stepKey="seeBorderStage2"/>
16491646
<seeElement selector="{{BannerOnBackend.borderColor('2', PageBuilderAdvancedBorderColorProperty_green.rgb)}}" stepKey="seeBorderColorStage2"/>
@@ -1707,10 +1704,7 @@
17071704
<argument name="property" value="PageBuilderBannerShowContentOverlayAlwaysProperty"/>
17081705
</actionGroup>
17091706
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeOverlayColor">
1710-
<argument name="property" value="PageBuilderBannerOverlayColor_FF0000"/>
1711-
</actionGroup>
1712-
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeOverlayTransparency">
1713-
<argument name="property" value="PageBuilderBannerOverlayTransparencyProperty"/>
1707+
<argument name="property" value="PageBuilderBannerOverlayColor_Blue_Opaque"/>
17141708
</actionGroup>
17151709
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateAlignment">
17161710
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyCenter"/>
@@ -1768,7 +1762,7 @@
17681762
<seeElement selector="{{BannerOnFrontend.buttonType('2', PageBuilderBannerButtonTypeSecondaryProperty.value)}}" stepKey="seeButtonTypeStorefront"/>
17691763
<seeElement selector="{{BannerOnFrontend.buttonText('2', PageBuilderBannerButtonTextProperty2.value)}}" stepKey="seeButtonTextStorefront"/>
17701764
<seeElement selector="{{BannerOnFrontend.showOverlay('2', PageBuilderBannerShowContentOverlayAlwaysProperty.value)}}" stepKey="seeOverlayStateStorefront"/>
1771-
<seeElement selector="{{BannerOnFrontend.overlayColorAndTransparency('2', PageBuilderBannerOverlayColor_FF0000.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeOverlayColorAndTransparencyStorefront"/>
1765+
<seeElement selector="{{BannerOnFrontend.overlayBackgroundColor('2', PageBuilderBannerOverlayColor_Blue_Opaque.value)}}" stepKey="seeOverlayBackgroundStorefront"/>
17721766
<seeElement selector="{{BannerOnFrontend.alignment('2', PageBuilderAdvancedAlignmentPropertyCenter.value)}}" stepKey="seeAlignmentStorefront"/>
17731767
<seeElement selector="{{BannerOnFrontend.border('2', PageBuilderAdvancedBorderPropertyDouble.value)}}" stepKey="seeBorderStorefront"/>
17741768
<seeElement selector="{{BannerOnFrontend.borderColor('2', PageBuilderAdvancedBorderColorProperty_green.rgb)}}" stepKey="seeBorderColorStorefront"/>
@@ -1796,7 +1790,7 @@
17961790
<seeElement selector="{{BannerOnFrontend.buttonType('2', PageBuilderBannerButtonTypeSecondaryProperty.value)}}" stepKey="seeMobileButtonTypeStorefront"/>
17971791
<seeElement selector="{{BannerOnFrontend.buttonText('2', PageBuilderBannerButtonTextProperty2.value)}}" stepKey="seeMobileButtonTextStorefront"/>
17981792
<seeElement selector="{{BannerOnFrontend.showOverlay('2', PageBuilderBannerShowContentOverlayAlwaysProperty.value)}}" stepKey="seeMobileOverlayStateStorefront"/>
1799-
<seeElement selector="{{BannerOnFrontend.overlayColorAndTransparency('2', PageBuilderBannerOverlayColor_FF0000.rgb, PageBuilderBannerOverlayTransparencyProperty.decimal)}}" stepKey="seeMobileOverlayColorAndTransparencyStorefront"/>
1793+
<seeElement selector="{{BannerOnFrontend.overlayBackgroundColor('2', PageBuilderBannerOverlayColor_Blue_Opaque.value)}}" stepKey="seeMobileOverlayBackgroundStorefront"/>
18001794
<seeElement selector="{{BannerOnFrontend.alignment('2', PageBuilderAdvancedAlignmentPropertyCenter.value)}}" stepKey="seeMobileAlignmentStorefront"/>
18011795
<seeElement selector="{{BannerOnFrontend.border('2', PageBuilderAdvancedBorderPropertyDouble.value)}}" stepKey="seeMobileBorderStorefront"/>
18021796
<seeElement selector="{{BannerOnFrontend.borderColor('2', PageBuilderAdvancedBorderColorProperty_green.rgb)}}" stepKey="seeMobileBorderColorStorefront"/>

0 commit comments

Comments
 (0)