MC-3095: Display TypeScript errors within local build process

- Resolve further errors

Author: davemacaulay

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type-toolbar.ts

@@ -7,7 +7,7 @@ import $ from "jquery";
 import ko from "knockout";
 import events from "uiEvents";
 import {OptionInterface} from "./content-type-toolbar/option";
-import {ValueInterface} from "./content-type-toolbar/value";
+import ValueInterface from "./content-type-toolbar/value";
 import Preview from "./content-type/preview";
 
 /**
@@ -45,7 +45,7 @@ export default class Toolbar {
      * @param {ValueInterface} value
      */
     public onOptionClick(option: OptionInterface, value: ValueInterface) {
-        const defaultValue: string = this.preview.config.fields[option.key].default;
+        const defaultValue: string = this.preview.config.fields[option.key].default as string;
         const currentValue: string = this.preview.parent.dataStore.get(option.key) as string;
         this.preview.updateData(option.key, currentValue === value.value ? defaultValue : value.value);
     }

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/block/preview.ts

@@ -10,6 +10,7 @@ import events from "uiEvents";
 import Config from "../../config";
 import ContentTypeInterface from "../../content-type";
 import ContentTypeConfigInterface from "../../content-type-config";
+import {DataObject} from "../../data-store";
 import ContentTypeDroppedCreateEventParamsInterface from "../content-type-dropped-create-event-params";
 import ObservableUpdater from "../observable-updater";
 import BasePreview from "../preview";
@@ -62,7 +63,7 @@ export default class Preview extends BasePreview {
     protected afterObservablesUpdated(): void {
         super.afterObservablesUpdated();
 
-        const data = this.parent.dataStore.get();
+        const data = this.parent.dataStore.get() as DataObject;
 
         // Only load if something changed
         if (this.lastBlockId === data.block_id && this.lastTemplate === data.template) {
@@ -119,8 +120,8 @@ export default class Preview extends BasePreview {
                     this.placeholderText(response.data.error);
                 }
 
-                this.lastBlockId = data.block_id;
-                this.lastTemplate = data.template;
+                this.lastBlockId = parseInt(data.block_id.toString(), 10);
+                this.lastTemplate = data.template.toString();
                 this.lastRenderedHtml = response.data.content;
             })
             .fail(() => {

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/map/converter/attribute/locations.ts

@@ -3,7 +3,8 @@
  * See COPYING.txt for license details.
  */
 
-import {ConverterInterface} from "../../../../converter/converter-interface";
+import ConverterInterface from "../../../../converter/converter-interface";
+import {DataObject} from "../../../../data-store";
 
 export default class Locations implements ConverterInterface {
 
@@ -27,7 +28,7 @@ export default class Locations implements ConverterInterface {
      * @param data Object
      * @returns {string | object}
      */
-    public toDom(name: string, data: object): string | object {
+    public toDom(name: string, data: DataObject): string | object {
         let content = data[name];
         if (typeof content === "string" && content !== "") {
             content = JSON.parse(content);

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slide/converter/style/margins.ts

@@ -3,7 +3,8 @@
  * See COPYING.txt for license details.
  */
 
-import {ConverterInterface} from "../../../../converter/converter-interface";
+import ConverterInterface from "../../../../converter/converter-interface";
+import {DataObject} from "../../../../data-store";
 
 export default class Margins implements ConverterInterface {
     /**
@@ -29,12 +30,14 @@ export default class Margins implements ConverterInterface {
     /**
      * Convert value to knockout format
      *
-     * @param name string
-     * @param data Object
+     * @param {string} name
+     * @param {DataObject} data
      * @returns {string | object}
      */
-    public toDom(name: string, data: object): string | object {
-        const result = {};
+    public toDom(name: string, data: DataObject): string | object {
+        const result: {
+            [key: string]: string;
+        } = {};
         let value = data[name];
         if (value && typeof value === "string") {
             value = JSON.parse(value);

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/slide/converter/style/paddings.ts

@@ -3,7 +3,8 @@
  * See COPYING.txt for license details.
  */
 
-import {ConverterInterface} from "../../../../converter/converter-interface";
+import ConverterInterface from "../../../../converter/converter-interface";
+import {DataObject} from "../../../../data-store";
 
 export default class Paddings implements ConverterInterface {
     /**
@@ -36,12 +37,14 @@ export default class Paddings implements ConverterInterface {
     /**
      * Convert value to knockout format
      *
-     * @param name string
-     * @param data Object
+     * @param {string} name
+     * @param {DataObject} data
      * @returns {string | object}
      */
-    public toDom(name: string, data: object): string | object {
-        const result = {};
+    public toDom(name: string, data: DataObject): string | object {
+        const result: {
+            [key: string]: string;
+        } = {};
         let value = data[name];
         if (value && typeof value === "string") {
             value = JSON.parse(value);

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/converter/style/paddings.ts

@@ -52,4 +52,4 @@ export default class Paddings implements ConverterInterface {
         }
         return result;
     }
-}
+}