Skip to content

Commit 1d36426

Browse files
paras89paras89
committed
PB-500 MFTF coverage
1 parent f09350b commit 1d36426

File tree

6 files changed

+123
-9
lines changed

6 files changed

+123
-9
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Data/AdvancedData.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,14 +167,14 @@
167167
<data key="section">advanced</data>
168168
<data key="fieldName">border_color</data>
169169
<data key="value">#82bb6a</data>
170-
<data key="rgb">rgb(240, 192, 194)</data>
170+
<data key="rgb">rgb(130, 187, 106)</data>
171171
</entity>
172172
<entity name="PageBuilderAdvancedBorderColorProperty_f0c0c2" type="pagebuilder_advanced_border_color_property">
173173
<data key="name">Border Color</data>
174174
<data key="section">advanced</data>
175175
<data key="fieldName">border_color</data>
176176
<data key="value">#f0c0c2"</data>
177-
<data key="rgb">rgb(130, 187, 106)</data>
177+
<data key="rgb">rgb(240, 192, 194)</data>
178178
</entity>
179179
<entity name="PageBuilderAdvancedBorderColorProperty_FF0000_rgb" type="pagebuilder_advanced_border_color_property">
180180
<data key="name">Border Color</data>

‎app/code/Magento/PageBuilder/Test/Mftf/Data/ColumnData.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,14 @@
5757
<data key="section">background</data>
5858
<data key="fieldName">background_color</data>
5959
<data key="value">#fc0009</data>
60-
<data key="rgb">rgb(252,0,9)</data>
60+
<data key="rgb">rgb(252, 0, 9)</data>
6161
</entity>
6262
<entity name="PageBuilderBackgroundColorProperty_21FFFF" type="pagebuilder_column_background_color_property">
6363
<data key="name">Background Color</data>
6464
<data key="section">background</data>
6565
<data key="fieldName">background_color</data>
6666
<data key="value">#21ffff</data>
67-
<data key="rgb">rgb(33,255,255)</data>
67+
<data key="rgb">rgb(33, 255, 255)</data>
6868
</entity>
6969
<entity name="PageBuilderBackgroundColorProperty_FF5A5F" type="pagebuilder_column_background_color_property">
7070
<data key="name">Background Color</data>
@@ -133,7 +133,7 @@
133133
<data key="name">Background Attachment</data>
134134
<data key="section">background</data>
135135
<data key="fieldName">background_attachment</data>
136-
<data key="value">Fixed</data>
136+
<data key="value">fixed</data>
137137
</entity>
138138
<!-- Column Styles -->
139139
<entity name="PageBuilderColumnStyles" type="pagebuilder_column_styles">

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderColumnGroupSection/ColumnGroupOnFrontendSection.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,10 @@
1111
<element name="base" type="block" selector="(//div[@data-content-type=&quot;column-group&quot;])[{{arg1}}]" parameterized="true"/>
1212
<element name="baseJS" type="text" selector="document.querySelectorAll('[data-content-type=column-group]')[{{arg1}} - 1]" parameterized="true"/>
1313
<element name="baseCSS" type="text" selector="[data-content-type=column-group]"/>
14-
1514
<!-- Background Configuration -->
1615
<element name="backgroundPath" type="button" selector="(//div[@data-content-type=&quot;column-group&quot;])[{{arg1}}]" parameterized="true"/>
16+
<!-- Advanced Configuration -->
17+
<element name="advancedConfigurationPath" type="text" selector="(//div[@data-content-type=&quot;column-group&quot;])[{{arg1}}]" parameterized="true"/>
18+
<element name="cssClasses" type="text" selector="(//div[@data-content-type='column-group'])[{{arg1}}]/div[contains(@class,'{{arg2}}')]" parameterized="true"/>
1719
</section>
1820
</sections>

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderColumnSection/ColumnOnFrontendSection.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<element name="baseCSS" type="text" selector="[data-content-type=column]"/>
1414
<element name="elementChildren" type="text" selector="(//div[@data-content-type=&quot;column&quot;])[{{arg1}}]" parameterized="true"/>
1515
<element name="columnGroup" type="text" selector="(//div[contains(@class, 'pagebuilder-column-group')])[{{arg1}}]" parameterized="true"/>
16-
<element name="columnGroupWithGridSize" type="text" selector="(//div[contains(@class, 'pagebuilder-column-group') and @data-grid-size={{arg1}}])[{{arg2}}]" parameterized="true"/>
16+
<element name="columnGroupWithGridSize" type="text" selector="(//div[contains(@class, 'pagebuilder-column-group') and @data-grid-size='{{arg1}}'])[{{arg2}}]" parameterized="true"/>
1717
<element name="allColumnGroups" type="block" selector=".pagebuilder-column-group"/>
1818
<element name="allColumns" type="block" selector="(//div[@data-content-type='column'])"/>
1919
<element name="columnX" type="block" selector="[data-content-type=column]:nth-child({{arg1}})" parameterized="true"/>
@@ -68,5 +68,8 @@
6868
<element name="backgroundImage" type="button" selector="(//div[@data-content-type='column'])[{{arg1}}][contains(@style,'background-image: url(') and contains(@style,'{{arg2}}')]" parameterized="true" deprecated="Styles are not inline"/>
6969
<element name="noBackgroundImage" type="button" selector="(//div[@data-content-type='column'])[{{arg1}}][not(contains(@style,'background-image:'))]" parameterized="true" deprecated="Styles are not inline"/>
7070
<element name="backgroundMobileImage" type="button" selector="(//div[@data-content-type='column'])[{{arg1}}][contains(@style,'background-image: url(') and contains(@style,'{{arg2}}')]" parameterized="true" deprecated="Styles are not inline"/>
71+
<!-- Advanced Configuration -->
72+
<element name="advancedConfigurationPath" type="text" selector="(//div[@data-content-type=&quot;column&quot;])[{{arg1}}]" parameterized="true"/>
73+
<element name="cssClasses" type="text" selector="(//div[@data-content-type='column'])[{{arg1}}][contains(@class, '{{arg2}}')]" parameterized="true"/>
7174
</section>
7275
</sections>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnGroupTest/ColumnGroupSettingsFrontendTest.xml

Lines changed: 109 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,109 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
10+
<test name="ColumnGroupSettingsFrontendTest" extends="ColumnGroupSettingsTest" >
11+
<annotations>
12+
<features value="PageBuilder"/>
13+
<stories value="Columns"/>
14+
<title value="Test Column groups and Column content type settings on the front-end"/>
15+
<description value="A user should be able to see column group settings changes on the front-end"/>
16+
<severity value="MAJOR"/>
17+
<useCaseId value=""/>
18+
<testCaseId value=""/>
19+
<group value="pagebuilder"/>
20+
<group value="pagebuilder-column"/>
21+
<group value="pagebuilder-column-group"/>
22+
</annotations>
23+
<!-- Verify Storefront -->
24+
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
25+
<argument name="contentType" value="PageBuilderColumnGroupContentType"/>
26+
</actionGroup>
27+
<!-- Verify Column Group -->
28+
<seeNumberOfElements selector="{{ColumnOnFrontend.allColumns}}" userInput="2" stepKey="seeNumberOfColumns2"/>
29+
<executeJS function="return document.querySelector('{{ColumnOnFrontend.columnX('1')}}').clientWidth" stepKey="columnOneWidthFrontend"/>
30+
<executeJS function="return document.querySelector('{{ColumnOnFrontend.columnX('2')}}').clientWidth" stepKey="columnTwoWidthFrontend"/>
31+
<executeJS function="return Math.round({$columnOneWidthFrontend}/{$columnTwoWidthFrontend})" stepKey="columnRatioFrontend"/>
32+
<assertEquals stepKey="assertFrontendRatioIsCorrect">
33+
<expectedResult type="int">1</expectedResult>
34+
<actualResult type="variable">columnRatioFrontend</actualResult>
35+
</assertEquals>
36+
<seeNumberOfElements selector="{{ColumnOnFrontend.columnGroupWithGridSize('6','1')}}" userInput="1" stepKey="seeColumnGroupWithGridSize6"/>
37+
<actionGroup ref="ValidateAllBackgroundAttributesActionGroup" stepKey="validateBackgroundOnStorefront">
38+
<argument name="section" value="ColumnGroupOnFrontend"/>
39+
<argument name="backgroundColor" value="PageBuilderBackgroundColorProperty_FC0009"/>
40+
<argument name="backgroundImage" value="PageBuilderColumnGroupDesktopImage_PNG"/>
41+
<argument name="backgroundPosition" value="PageBuilderBackgroundPosition_TopCenter"/>
42+
<argument name="backgroundSize" value="PageBuilderBackgroundSize_Contain"/>
43+
<argument name="backgroundRepeat" value="PageBuilderBackgroundRepeat_Enabled"/>
44+
<argument name="backgroundAttachment" value="PageBuilderBackgroundAttachmentProperty"/>
45+
</actionGroup>
46+
<!-- <actionGroup ref="validateBackgroundMobileImage" stepKey="validateBackgroundMobileImage">
47+
<argument name="section" value="ColumnGroupOnFrontend"/>
48+
<argument name="backgroundMobileImage" value="PageBuilderColumnGroupMobileImage_PNG"/>
49+
</actionGroup> -->
50+
<actionGroup ref="ValidateAdvancedConfigurationAllOptionsActionGroup" stepKey="validateAllAdvancedStorefront">
51+
<argument name="page" value="ColumnGroupOnFrontend"/>
52+
<argument name="alignment" value="PageBuilderAdvancedAlignmentPropertyLeft"/>
53+
<argument name="border" value="PageBuilderAdvancedBorderPropertyDotted"/>
54+
<argument name="borderColor" value="PageBuilderAdvancedBorderColorProperty_FF0000"/>
55+
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthProperty50"/>
56+
<argument name="borderRadius" value="PageBuilderAdvancedBorderRadiusProperty60"/>
57+
<argument name="cssClasses" value="PageBuilderAdvancedCssClassesPropertyOneClass"/>
58+
<argument name="margin" value="PageBuilderMarginsPropertyUnique"/>
59+
<argument name="padding" value="PageBuilderPaddingPropertyUnique"/>
60+
</actionGroup>
61+
<!-- Verify Column One -->
62+
<actionGroup ref="ValidateAllBackgroundAttributesActionGroup" stepKey="validateColumnOneBackgroundOnStorefront">
63+
<argument name="section" value="ColumnOnFrontend"/>
64+
<argument name="backgroundColor" value="PageBuilderBackgroundColorProperty_21FFFF"/>
65+
<argument name="backgroundImage" value="PageBuilderColumnOneDesktopImage_PNG"/>
66+
<argument name="backgroundPosition" value="PageBuilderBackgroundPosition_TopRight"/>
67+
<argument name="backgroundSize" value="PageBuilderBackgroundSize_Auto"/>
68+
<argument name="backgroundRepeat" value="PageBuilderBackgroundRepeat_Disabled"/>
69+
<argument name="backgroundAttachment" value="PageBuilderBackgroundAttachment_Scroll"/>
70+
</actionGroup>
71+
<actionGroup ref="ValidateAdvancedConfigurationAllOptionsActionGroup" stepKey="validateColumnOneAllAdvancedStorefront">
72+
<argument name="page" value="ColumnOnFrontend"/>
73+
<argument name="alignment" value="PageBuilderAdvancedAlignmentPropertyCenter"/>
74+
<argument name="border" value="PageBuilderAdvancedBorderPropertyDouble"/>
75+
<argument name="borderColor" value="PageBuilderAdvancedBorderColorProperty_82BB6A"/>
76+
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthProperty10"/>
77+
<argument name="borderRadius" value="PageBuilderAdvancedBorderRadiusProperty12"/>
78+
<argument name="cssClasses" value="PageBuilderAdvancedCssClassesPropertyOneClass"/>
79+
<argument name="margin" value="PageBuilderMarginsPropertyUnique"/>
80+
<argument name="padding" value="PageBuilderPaddingPropertyUnique"/>
81+
</actionGroup>
82+
<!-- Verify Column Two -->
83+
<actionGroup ref="ValidateAllBackgroundAttributesActionGroup" stepKey="validateColumnTwoBackgroundOnStorefront">
84+
<argument name="section" value="ColumnOnFrontend"/>
85+
<argument name="backgroundColor" value="PageBuilderBackgroundColorProperty_21FFFF"/>
86+
<argument name="backgroundPosition" value="PageBuilderBackgroundPosition_BottomLeft"/>
87+
<argument name="backgroundSize" value="PageBuilderBackgroundSize_Cover"/>
88+
<argument name="backgroundRepeat" value="PageBuilderBackgroundRepeat_Enabled"/>
89+
<argument name="backgroundAttachment" value="PageBuilderBackgroundAttachment_Fixed"/>
90+
<argument name="index" value="2"/>
91+
</actionGroup>
92+
<!-- <actionGroup ref="validateBackgroundMobileImage" stepKey="validateColumnTwoBackgroundMobileImage">
93+
<argument name="section" value="ColumnOnFrontend"/>
94+
<argument name="backgroundMobileImage" value="PageBuilderColumnTwoMobileImage_PNG"/>
95+
</actionGroup> -->
96+
<actionGroup ref="ValidateAdvancedConfigurationAllOptionsActionGroup" stepKey="validateColumnTwoAllAdvancedStorefront">
97+
<argument name="page" value="ColumnOnFrontend"/>
98+
<argument name="alignment" value="PageBuilderAdvancedAlignmentPropertyRight"/>
99+
<argument name="border" value="PageBuilderAdvancedBorderPropertyRidge"/>
100+
<argument name="borderColor" value="PageBuilderAdvancedBorderColorProperty_82BB6A"/>
101+
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthProperty10"/>
102+
<argument name="borderRadius" value="PageBuilderAdvancedBorderRadiusProperty1"/>
103+
<argument name="cssClasses" value="PageBuilderAdvancedCssClassesPropertyOneClass"/>
104+
<argument name="margin" value="PageBuilderMarginsPropertyUnique"/>
105+
<argument name="padding" value="PageBuilderPaddingPropertyUnique"/>
106+
<argument name="index" value="2"/>
107+
</actionGroup>
108+
</test>
109+
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnGroupTest/ColumnGroupSettingsTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
<argument name="property" value="PageBuilderBackgroundAttachmentProperty"/>
6363
</actionGroup>
6464
<actionGroup ref="clickSlideOutPanelFieldGeneral" stepKey="enterBackgroundRepeatYes">
65-
<argument name="property" value="PageBuilderBackgroundRepeatProperty"/>
65+
<argument name="property" value="PageBuilderBackgroundRepeat_Enabled"/>
6666
</actionGroup>
6767
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAlignmentLeft">
6868
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyLeft"/>
@@ -224,7 +224,7 @@
224224
<argument name="property" value="PageBuilderBackgroundAttachmentProperty"/>
225225
</actionGroup>
226226
<actionGroup ref="seeOptionIsCheckedSlideOutProperty" stepKey="seeColumnGroupBackgroundRepeatYes">
227-
<argument name="property" value="PageBuilderBackgroundRepeatProperty"/>
227+
<argument name="property" value="PageBuilderBackgroundRepeat_Enabled"/>
228228
</actionGroup>
229229
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="seeColumnGroupAlignment">
230230
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyLeft"/>

0 commit comments

Comments
 (0)