Skip to content

Commit 1c66029

Browse files
committed
Merge from 559_no-predefined-gutters--products
2 parents 863478a + dd53738 commit 1c66029

File tree

3 files changed

+53
-8
lines changed

3 files changed

+53
-8
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
9+
<test name="AdminPageBuilderProductsCarouselValidateAdvancedConfigurationDefaultValuesTest" extends="ProductsValidateAdvancedConfigurationDefaultValuesTest">
10+
<annotations>
11+
<features value="PageBuilder"/>
12+
<stories value="Products"/>
13+
<title value="Validate Advanced Configuration Default Values for Product (Carousel)"/>
14+
<description value="Validates the default values for every attribute in the Advanced form and on Stage for Product Carousel."/>
15+
<severity value="BLOCKER"/>
16+
<group value="pagebuilder"/>
17+
<group value="pagebuilder-products"/>
18+
<group value="pagebuilder-productsCarousel"/>
19+
</annotations>
20+
<!-- Select Product Carousel Appearance -->
21+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAppearance" after="openEditAfterDrop">
22+
<argument name="property" value="PageBuilderProductsProductCarouselAppearance"/>
23+
</actionGroup>
24+
<actionGroup ref="ValidateAdvancedConfigurationWithNoAlignmentActionGroup" stepKey="validateStage">
25+
<argument name="page" value="ProductsCarouselOnStage"/>
26+
<argument name="index" value="1"/>
27+
</actionGroup>
28+
<actionGroup ref="ValidateAdvancedConfigurationWithNoAlignmentActionGroup" stepKey="validateStage2">
29+
<argument name="page" value="ProductsCarouselOnStage"/>
30+
<argument name="index" value="1"/>
31+
</actionGroup>
32+
</test>
33+
</tests>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsCommonTest/ProductsValidateAdvancedConfigurationDefaultValuesTest.xml

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,13 @@
55
* See COPYING.txt for license details.
66
*/
77
-->
8-
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9-
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
8+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
109
<test name="ProductsValidateAdvancedConfigurationDefaultValuesTest">
1110
<annotations>
1211
<features value="PageBuilder"/>
1312
<stories value="Products"/>
14-
<title value="Validate Advanced Configuration Default Values"/>
15-
<description value="Validate the default values for every attribute in the Advanced Configuration form and on Stage for Product List."/>
13+
<title value="Validate Advanced Configuration Default Values for Product (List)"/>
14+
<description value="Validates the default values for every attribute in the Advanced form and on Stage for Product List."/>
1615
<severity value="BLOCKER"/>
1716
<useCaseId value="MAGETWO-71425"/>
1817
<testCaseId value="MC-2500"/>
@@ -77,10 +76,12 @@
7776
<comment userInput="removing step" stepKey="getCssClasses"/>
7877
<comment userInput="removing step" stepKey="assertCssClasses"/>
7978
<actionGroup ref="seeInMarginFieldsSlideOutPanel" stepKey="validateMargins">
80-
<argument name="property" value="PageBuilderMarginsPropertyDefault"/>
79+
<!-- @todo: Update `PageBuilderMarginsPropertyDefault` with (Default) Empty Values -->
80+
<argument name="property" value="PageBuilderMarginsProperty_Empty"/>
8181
</actionGroup>
8282
<actionGroup ref="seeInPaddingFieldsSlideOutPanel" stepKey="validatePadding">
83-
<argument name="property" value="PageBuilderPaddingPropertyDefault"/>
83+
<!-- @todo: Update `PageBuilderPaddingPropertyDefault` with (Default) Empty Values -->
84+
<argument name="property" value="PageBuilderPaddingProperty_Empty"/>
8485
</actionGroup>
8586
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
8687
<!-- Validate Stage -->
@@ -126,10 +127,12 @@
126127
<comment userInput="removing step" stepKey="getCssClasses2"/>
127128
<comment userInput="removing step" stepKey="assertCssClasses2"/>
128129
<actionGroup ref="seeInMarginFieldsSlideOutPanel" stepKey="validateMargins2">
129-
<argument name="property" value="PageBuilderMarginsPropertyDefault"/>
130+
<!-- @todo: Update `PageBuilderMarginsPropertyDefault` with (Default) Empty Values -->
131+
<argument name="property" value="PageBuilderMarginsProperty_Empty"/>
130132
</actionGroup>
131133
<actionGroup ref="seeInPaddingFieldsSlideOutPanel" stepKey="validatePadding2">
132-
<argument name="property" value="PageBuilderPaddingPropertyDefault"/>
134+
<!-- @todo: Update `PageBuilderPaddingPropertyDefault` with (Default) Empty Values -->
135+
<argument name="property" value="PageBuilderPaddingProperty_Empty"/>
133136
</actionGroup>
134137
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
135138
<argument name="contentType" value="PageBuilderProductsContentType"/>

app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_products_form.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,15 @@
3232
</settings>
3333
</dataProvider>
3434
</dataSource>
35+
<fieldset name="advanced">
36+
<field name="margins_and_padding">
37+
<argument name="data" xsi:type="array">
38+
<item name="config" xsi:type="array">
39+
<item name="default" xsi:type="null" />
40+
</item>
41+
</argument>
42+
</field>
43+
</fieldset>
3544
<fieldset name="appearance_fieldset" sortOrder="10" component="Magento_PageBuilder/js/form/element/dependent-fieldset">
3645
<settings>
3746
<label translate="true">Appearance</label>

0 commit comments

Comments
 (0)