Skip to content

Commit 1bf941b

Browse files
author
Lukasz Borowiec
committed
#514: User sees content snapshot on Category page in Admin Panel #3 - Code Review fixes
1 parent e9ca915 commit 1bf941b

File tree

3 files changed

+17
-26
lines changed

3 files changed

+17
-26
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/video/default/preview.html

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,6 @@
1313
<iframe frameborder="0" allowfullscreen attr="data.video.attributes" if="isHosted(data.video.attributes().src)"/>
1414
<video frameborder="0" controls attr="data.video.attributes()" ifnot="isHosted(data.video.attributes().src)" afterRender="onAfterRender"/>
1515
<i class="icon-pagebuilder-video pagebuilder-video-placeholder" ifnot="data.video.attributes().src"/>
16-
17-
<ifnot args="$parent.accessibility() && data.video.attributes().src">
18-
<div class="image-uploader-preview-information">
19-
<h4 class="title" translate="'Preview Mode'"></h4>
20-
<p class="description" translate="'If you want to upload an image, run the full-screen mode'"></p>
21-
</div>
22-
</ifnot>
2316
</div>
2417
</div>
2518
</div>

app/code/Magento/PageBuilder/view/adminhtml/web/template/form/element/uploader/preview/image.html

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,20 @@
1010
<ul class="pagebuilder-options-links">
1111
<li class="pagebuilder-options-link">
1212
<label
13-
data-bind="event: {mousedown: stopEvent}"
14-
class="file-uploader-button action-default"
15-
attr="for: uid"
16-
disable="disabled"
17-
translate="translations.uploadNewImage"/>
13+
data-bind="event: {mousedown: stopEvent}"
14+
class="file-uploader-button action-default"
15+
attr="for: uid"
16+
disable="disabled"
17+
translate="translations.uploadNewImage"/>
1818
</li>
1919
<li class="pagebuilder-options-link">
2020
<label
21-
data-bind="event: {change: addFileFromMediaGallery, click: openMediaBrowserDialog, mousedown: stopEvent}"
22-
class="file-uploader-button action-default"
23-
attr="id: mediaGalleryUid, 'data-id': getFileId()"
24-
disable="disabled"
25-
data-force_static_path="1"
26-
translate="translations.selectFromGallery"/>
21+
data-bind="event: {change: addFileFromMediaGallery, click: openMediaBrowserDialog, mousedown: stopEvent}"
22+
class="file-uploader-button action-default"
23+
attr="id: mediaGalleryUid, 'data-id': getFileId()"
24+
disable="disabled"
25+
data-force_static_path="1"
26+
translate="translations.selectFromGallery"/>
2727
</li>
2828
</ul>
2929
</div>
@@ -45,12 +45,12 @@
4545
<label class="file-uploader-button action-default" attr="for: uid" disable="disabled" translate="translations.uploadImage"/>
4646
<span translate="translations.or"></span>
4747
<label
48-
data-bind="event: {change: addFileFromMediaGallery, click: openMediaBrowserDialog}"
49-
class="file-uploader-button action-default"
50-
attr="id: mediaGalleryUid, 'data-id': getFileId()"
51-
disable="disabled"
52-
data-force_static_path="1"
53-
translate="translations.selectFromGallery"/>
48+
data-bind="event: {change: addFileFromMediaGallery, click: openMediaBrowserDialog}"
49+
class="file-uploader-button action-default"
50+
attr="id: mediaGalleryUid, 'data-id': getFileId()"
51+
disable="disabled"
52+
data-force_static_path="1"
53+
translate="translations.selectFromGallery"/>
5454
<render args="fallbackResetTpl" if="$data.showFallbackReset && $data.isDifferedFromDefault"/>
5555
<p class="image-upload-requirements">
5656
<span if="$data.maxFileSize">

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/page-builder.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ export default class PageBuilder implements PageBuilderInterface {
4444
Config.setConfig(config);
4545
Config.setMode("Preview");
4646
Config.setContentSnapshot({pageBuilderId: this.id, contentSnapshotMode: contentSnapshot});
47-
4847
this.preloadTemplates(config);
4948
this.initialValue = initialValue;
5049
this.isFullScreen(config.isFullScreen);
@@ -103,7 +102,6 @@ export default class PageBuilder implements PageBuilderInterface {
103102
const panel = stageWrapper.find(".pagebuilder-panel");
104103
if (!this.isFullScreen()) {
105104
pageBuilderWrapper.css("height", pageBuilderWrapper.outerHeight());
106-
107105
this.previousPanelHeight = panel.outerHeight();
108106
panel.css("height", this.previousPanelHeight + "px");
109107
/**

0 commit comments

Comments
 (0)