Skip to content

Commit 1b5ab34

Browse files
committed
MC-5232: Prefix field names with section name to avoid field name collision
- Update usages of accessing data on the data object
1 parent 8d68cc3 commit 1b5ab34

File tree

18 files changed

+95
-74
lines changed

18 files changed

+95
-74
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/block/mass-converter/widget-directive.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/block/preview.js

Lines changed: 6 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/master.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/preview.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/products/mass-converter/widget-directive.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/tabs/mass-converter/header-alignment.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/mass-converter/background-images.js

Lines changed: 15 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/mass-converter/empty-mobile-image.js

Lines changed: 7 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/mass-converter/widget-directive-abstract.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/block/mass-converter/widget-directive.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
import {ConverterConfigInterface, ConverterDataInterface} from "../../../mass-converter/converter-interface";
77
import BaseWidgetDirective from "../../../mass-converter/widget-directive-abstract";
8+
import {set} from "../../../utils/object";
89

910
/**
1011
* Enables the settings of the content type to be stored as a widget directive.
@@ -46,7 +47,7 @@ export default class WidgetDirective extends BaseWidgetDirective {
4647
return data;
4748
}
4849

49-
data[config.html_variable] = this.buildDirective(attributes);
50+
set(data, config.html_variable, this.buildDirective(attributes));
5051
return data;
5152
}
5253
}

0 commit comments

Comments
 (0)