Skip to content

Commit 1b27fcb

Browse files
MC-2337: [Architecture] Fix Formatting of Attributes
- fix formatting for appearance attributes
1 parent 1743a29 commit 1b27fcb

24 files changed

+183
-42
lines changed

app/code/Magento/PageBuilder/docs/content-type-configuration.md

Lines changed: 22 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,11 @@ The following is an example of a content type configuration in `view/adminhtml/p
8686
<parent name="column"/>
8787
</allowed_parents>
8888
<appearances>
89-
<appearance default="true" name="poster" preview_template="Magento_PageBuilder/content-type/banner/poster/preview" render_template="Magento_PageBuilder/content-type/banner/poster/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
89+
<appearance default="true"
90+
name="poster"
91+
preview_template="Magento_PageBuilder/content-type/banner/poster/preview"
92+
render_template="Magento_PageBuilder/content-type/banner/poster/master"
93+
reader="Magento_PageBuilder/js/master-format/read/configurable">
9094
<data_mapping>
9195
<elements>
9296
<element name="main" path=".">
@@ -173,13 +177,22 @@ The following is an example of a content type configuration in `view/adminhtml/p
173177
</converters>
174178
</data_mapping>
175179
</appearance>
176-
<appearance name="collage-left" preview_template="Magento_PageBuilder/content-type/banner/collage-left/preview" render_template="Magento_PageBuilder/content-type/banner/collage-left/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
180+
<appearance name="collage-left"
181+
preview_template="Magento_PageBuilder/content-type/banner/collage-left/preview"
182+
render_template="Magento_PageBuilder/content-type/banner/collage-left/master"
183+
reader="Magento_PageBuilder/js/master-format/read/configurable">
177184
<!-- Collage left appearance configuration -->
178185
</appearance>
179-
<appearance name="collage-centered" preview_template="Magento_PageBuilder/content-type/banner/collage-centered/preview" render_template="Magento_PageBuilder/content-type/banner/collage-centered/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
186+
<appearance name="collage-centered"
187+
preview_template="Magento_PageBuilder/content-type/banner/collage-centered/preview"
188+
render_template="Magento_PageBuilder/content-type/banner/collage-centered/master"
189+
reader="Magento_PageBuilder/js/master-format/read/configurable">
180190
<!-- Collage centered appearance configuration -->
181191
</appearance>
182-
<appearance name="collage-right" preview_template="Magento_PageBuilder/content-type/banner/collage-right/preview" render_template="Magento_PageBuilder/content-type/banner/collage-right/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
192+
<appearance name="collage-right"
193+
preview_template="Magento_PageBuilder/content-type/banner/collage-right/preview"
194+
render_template="Magento_PageBuilder/content-type/banner/collage-right/master"
195+
reader="Magento_PageBuilder/js/master-format/read/configurable">
183196
<!-- Collage right appearance configuration -->
184197
</appearance>
185198
</appearances>
@@ -250,7 +263,11 @@ It reads data based on the configuration specified in `data_mapping`.
250263

251264
**Example:**
252265
``` xml
253-
<appearance default="true" name="poster" preview_template="Magento_PageBuilder/content-type/banner/poster/preview" render_template="Magento_PageBuilder/content-type/banner/poster/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
266+
<appearance default="true"
267+
name="poster"
268+
preview_template="Magento_PageBuilder/content-type/banner/poster/preview"
269+
render_template="Magento_PageBuilder/content-type/banner/poster/master"
270+
reader="Magento_PageBuilder/js/master-format/read/configurable">
254271
<data_mapping/>
255272
</appearance>
256273
```

app/code/Magento/PageBuilder/docs/how-to-add-new-content-type.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,11 @@ To add configuration for a new content type, create a file under the following l
6464
<parent name="row"/>
6565
</allowed_parents>
6666
<appearances>
67-
<appearance default="true" name="default" preview_template="Vendor_ModuleNameCustom/content-type/simple/default/preview" render_template="Vendor_ModuleNameCustom/content-type/simple/default/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
67+
<appearance default="true"
68+
name="default"
69+
preview_template="Vendor_ModuleNameCustom/content-type/simple/default/preview"
70+
render_template="Vendor_ModuleNameCustom/content-type/simple/default/master"
71+
reader="Magento_PageBuilder/js/master-format/read/configurable">
6872
<data_mapping>
6973
<elements>
7074
<element name="main" path=".">
@@ -250,7 +254,7 @@ Now, let's add content type that can contain other content types. Create configu
250254
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_PageBuilder:etc/content_type.xsd">
251255
<content_types>
252256
<type name="complex"
253-
labe="Complex"
257+
label="Complex"
254258
component="Magento_PageBuilder/js/content-type-collection"
255259
preview_component="Magento_PageBuilder/js/content-type/preview-collection"
256260
master_component="Magento_PageBuilder/js/content-type/content-collection"
@@ -264,7 +268,11 @@ Now, let's add content type that can contain other content types. Create configu
264268
<parent name="column"/>
265269
</allowed_parents>
266270
<appearances>
267-
<appearance default="true" name="default" preview_template="Vendor_ModuleName/content-type/complex/default/preview" render_template="Vendor_ModuleName/content-type/complex/default/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
271+
<appearance default="true"
272+
name="default"
273+
preview_template="Vendor_ModuleName/content-type/complex/default/preview"
274+
render_template="Vendor_ModuleName/content-type/complex/default/master"
275+
reader="Magento_PageBuilder/js/master-format/read/configurable">
268276
<data_mapping>
269277
<elements>
270278
<element name="main" path=".">

app/code/Magento/PageBuilder/view/base/pagebuilder/content_type/accordion.xml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
* See COPYING.txt for license details.
66
*/
77
-->
8-
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9-
xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_PageBuilder:etc/content_type.xsd">
8+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_PageBuilder:etc/content_type.xsd">
109
<content_types>
1110
<type name="accordion"
1211
label="Accordion"
@@ -24,7 +23,10 @@
2423
<parent name="tab-item"/>
2524
</allowed_parents>
2625
<appearances>
27-
<appearance default="true" name="default" preview_template="Magento_PageBuilder/content-type/accordion/default/preview" render_template="Magento_PageBuilder/content-type/accordion/default/master">
26+
<appearance default="true"
27+
name="default"
28+
preview_template="Magento_PageBuilder/content-type/accordion/default/preview"
29+
render_template="Magento_PageBuilder/content-type/accordion/default/master">
2830
<readers>
2931
<reader component="Magento_PageBuilder/js/master-format/read/default" name="default"/>
3032
<reader component="Magento_PageBuilder/js/master-format/read/accordion" name="accordion"/>

app/code/Magento/PageBuilder/view/base/pagebuilder/content_type/anchor.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,11 @@
2121
<parent name="tab-item"/>
2222
</allowed_parents>
2323
<appearances>
24-
<appearance default="true" name="default" preview_template="Magento_PageBuilder/content-type/anchor/default/preview" render_template="Magento_PageBuilder/content-type/anchor/default/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
24+
<appearance default="true"
25+
name="default"
26+
preview_template="Magento_PageBuilder/content-type/anchor/default/preview"
27+
render_template="Magento_PageBuilder/content-type/anchor/default/master"
28+
reader="Magento_PageBuilder/js/master-format/read/configurable">
2529
<data_mapping>
2630
<elements>
2731
<element name="main" path=".">

app/code/Magento/PageBuilder/view/base/pagebuilder/content_type/banner.xml

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@
2222
<parent name="tab-item"/>
2323
</allowed_parents>
2424
<appearances>
25-
<appearance name="collage-left" preview_template="Magento_PageBuilder/content-type/banner/collage-left/preview" render_template="Magento_PageBuilder/content-type/banner/collage-left/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
25+
<appearance name="collage-left"
26+
preview_template="Magento_PageBuilder/content-type/banner/collage-left/preview"
27+
render_template="Magento_PageBuilder/content-type/banner/collage-left/master"
28+
reader="Magento_PageBuilder/js/master-format/read/configurable">
2629
<data_mapping>
2730
<elements>
2831
<element name="main" path=".">
@@ -111,7 +114,10 @@
111114
</converters>
112115
</data_mapping>
113116
</appearance>
114-
<appearance name="collage-centered" preview_template="Magento_PageBuilder/content-type/banner/collage-centered/preview" render_template="Magento_PageBuilder/content-type/banner/collage-centered/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
117+
<appearance name="collage-centered"
118+
preview_template="Magento_PageBuilder/content-type/banner/collage-centered/preview"
119+
render_template="Magento_PageBuilder/content-type/banner/collage-centered/master"
120+
reader="Magento_PageBuilder/js/master-format/read/configurable">
115121
<data_mapping>
116122
<elements>
117123
<element name="main" path=".">
@@ -200,7 +206,10 @@
200206
</converters>
201207
</data_mapping>
202208
</appearance>
203-
<appearance name="collage-right" preview_template="Magento_PageBuilder/content-type/banner/collage-right/preview" render_template="Magento_PageBuilder/content-type/banner/collage-right/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
209+
<appearance name="collage-right"
210+
preview_template="Magento_PageBuilder/content-type/banner/collage-right/preview"
211+
render_template="Magento_PageBuilder/content-type/banner/collage-right/master"
212+
reader="Magento_PageBuilder/js/master-format/read/configurable">
204213
<data_mapping>
205214
<elements>
206215
<element name="main" path=".">
@@ -289,7 +298,11 @@
289298
</converters>
290299
</data_mapping>
291300
</appearance>
292-
<appearance default="true" name="poster" preview_template="Magento_PageBuilder/content-type/banner/poster/preview" render_template="Magento_PageBuilder/content-type/banner/poster/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
301+
<appearance default="true"
302+
name="poster"
303+
preview_template="Magento_PageBuilder/content-type/banner/poster/preview"
304+
render_template="Magento_PageBuilder/content-type/banner/poster/master"
305+
reader="Magento_PageBuilder/js/master-format/read/configurable">
293306
<data_mapping>
294307
<elements>
295308
<element name="main" path=".">

app/code/Magento/PageBuilder/view/base/pagebuilder/content_type/block.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@
2323
<parent name="tab-item"/>
2424
</allowed_parents>
2525
<appearances>
26-
<appearance default="true" name="default" preview_template="Magento_PageBuilder/content-type/block/default/preview" render_template="Magento_PageBuilder/content-type/block/default/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
26+
<appearance default="true"
27+
name="default"
28+
preview_template="Magento_PageBuilder/content-type/block/default/preview"
29+
render_template="Magento_PageBuilder/content-type/block/default/master"
30+
reader="Magento_PageBuilder/js/master-format/read/configurable">
2731
<data_mapping>
2832
<elements>
2933
<element name="main" path=".">

app/code/Magento/PageBuilder/view/base/pagebuilder/content_type/button_item.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,11 @@
2121
</allowed_parents>
2222
<is_visible>false</is_visible>
2323
<appearances>
24-
<appearance default="true" name="default" preview_template="Magento_PageBuilder/content-type/button-item/default/preview" render_template="Magento_PageBuilder/content-type/button-item/default/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
24+
<appearance default="true"
25+
name="default"
26+
preview_template="Magento_PageBuilder/content-type/button-item/default/preview"
27+
render_template="Magento_PageBuilder/content-type/button-item/default/master"
28+
reader="Magento_PageBuilder/js/master-format/read/configurable">
2529
<data_mapping>
2630
<elements>
2731
<element name="main" path=".">

app/code/Magento/PageBuilder/view/base/pagebuilder/content_type/buttons.xml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@
2323
<parent name="tab-item"/>
2424
</allowed_parents>
2525
<appearances>
26-
<appearance default="true" name="inline" preview_template="Magento_PageBuilder/content-type/buttons/inline/preview" render_template="Magento_PageBuilder/content-type/buttons/inline/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
26+
<appearance default="true"
27+
name="inline"
28+
preview_template="Magento_PageBuilder/content-type/buttons/inline/preview"
29+
render_template="Magento_PageBuilder/content-type/buttons/inline/master"
30+
reader="Magento_PageBuilder/js/master-format/read/configurable">
2731
<data_mapping>
2832
<elements>
2933
<element name="main" path=".">
@@ -45,7 +49,10 @@
4549
</elements>
4650
</data_mapping>
4751
</appearance>
48-
<appearance name="stacked" preview_template="Magento_PageBuilder/content-type/buttons/inline/preview" render_template="Magento_PageBuilder/content-type/buttons/inline/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
52+
<appearance name="stacked"
53+
preview_template="Magento_PageBuilder/content-type/buttons/inline/preview"
54+
render_template="Magento_PageBuilder/content-type/buttons/inline/master"
55+
reader="Magento_PageBuilder/js/master-format/read/configurable">
4956
<data_mapping>
5057
<elements>
5158
<element name="main" path=".">

app/code/Magento/PageBuilder/view/base/pagebuilder/content_type/column.xml

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@
2323
<parent name="tab-item"/>
2424
</allowed_parents>
2525
<appearances>
26-
<appearance default="true" name="full-height" preview_template="Magento_PageBuilder/content-type/column/full-height/preview" render_template="Magento_PageBuilder/content-type/column/full-height/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
26+
<appearance default="true"
27+
name="full-height"
28+
preview_template="Magento_PageBuilder/content-type/column/full-height/preview"
29+
render_template="Magento_PageBuilder/content-type/column/full-height/master"
30+
reader="Magento_PageBuilder/js/master-format/read/configurable">
2731
<data_mapping>
2832
<elements>
2933
<element name="main" path=".">
@@ -64,7 +68,10 @@
6468
</converters>
6569
</data_mapping>
6670
</appearance>
67-
<appearance name="align-top" preview_template="Magento_PageBuilder/content-type/column/full-height/preview" render_template="Magento_PageBuilder/content-type/column/full-height/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
71+
<appearance name="align-top"
72+
preview_template="Magento_PageBuilder/content-type/column/full-height/preview"
73+
render_template="Magento_PageBuilder/content-type/column/full-height/master"
74+
reader="Magento_PageBuilder/js/master-format/read/configurable">
6875
<data_mapping>
6976
<elements>
7077
<element name="main" path=".">
@@ -105,7 +112,10 @@
105112
</converters>
106113
</data_mapping>
107114
</appearance>
108-
<appearance name="align-center" preview_template="Magento_PageBuilder/content-type/column/full-height/preview" render_template="Magento_PageBuilder/content-type/column/full-height/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
115+
<appearance name="align-center"
116+
preview_template="Magento_PageBuilder/content-type/column/full-height/preview"
117+
render_template="Magento_PageBuilder/content-type/column/full-height/master"
118+
reader="Magento_PageBuilder/js/master-format/read/configurable">
109119
<data_mapping>
110120
<elements>
111121
<element name="main" path=".">
@@ -146,7 +156,10 @@
146156
</converters>
147157
</data_mapping>
148158
</appearance>
149-
<appearance name="align-bottom" preview_template="Magento_PageBuilder/content-type/column/full-height/preview" render_template="Magento_PageBuilder/content-type/column/full-height/master" reader="Magento_PageBuilder/js/master-format/read/configurable">
159+
<appearance name="align-bottom"
160+
preview_template="Magento_PageBuilder/content-type/column/full-height/preview"
161+
render_template="Magento_PageBuilder/content-type/column/full-height/master"
162+
reader="Magento_PageBuilder/js/master-format/read/configurable">
150163
<data_mapping>
151164
<elements>
152165
<element name="main" path=".">

0 commit comments

Comments
 (0)