Skip to content

Commit 1a8db07

Browse files
committed
MC-13917: Content types mark up within Text content type causes whole stage to become HTML
- Add test to validate text will load correctly
1 parent 50a0904 commit 1a8db07

File tree

2 files changed

+37
-0
lines changed

2 files changed

+37
-0
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/TextData.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,4 +67,13 @@
6767
<data key="widgetType">Magento\Cms\Block\Widget\Page\Link</data>
6868
<data key="editPanelValue">{{widget type="Magento\Cms\Block\Widget\Page\Link" template="widget/link/link_block.phtml" page_id="2" type_name="CMS Page Link"}}</data>
6969
</entity>
70+
<!-- CMS Page -->
71+
<entity name="PageBuilderTextTestString" type="pagebuilder_text_property">
72+
<data key="value">TestString</data>
73+
</entity>
74+
<entity name="_cmsPageWithNestedText" type="cms_page">
75+
<data key="title" unique="suffix">Test Text Page Builder CMS Page</data>
76+
<data key="identifier" unique="suffix">test-page-builder-text-</data>
77+
<data key="content">&lt;div data-role=&quot;row&quot; data-appearance=&quot;&quot; data-element=&quot;main&quot;&gt;&lt;div data-enable-parallax=&quot;&quot; data-parallax-speed=&quot;&quot; data-background-images=&quot;{}&quot; data-element=&quot;inner&quot;&gt;&lt;div data-role=&quot;text&quot; data-appearance=&quot;default&quot; data-element=&quot;main&quot;&gt;&lt;div data-role=&quot;text&quot; data-appearance=&quot;default&quot; data-element=&quot;main&quot;&gt;TestString&lt;/div&gt;&lt;/div&gt;&lt;/div&gt;&lt;/div&gt;</data>
78+
</entity>
7079
</entities>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2647,4 +2647,32 @@
26472647
<actualResult type="variable">grabComputedTextAlignStoreFront</actualResult>
26482648
</assertEquals>
26492649
</test>
2650+
<test name="TextNestedTextWontBreakStage">
2651+
<annotations>
2652+
<features value="PageBuilder"/>
2653+
<stories value="Text"/>
2654+
<title value="Text - Nested Text"/>
2655+
<description value="Nested text content types shouldn't cause the whole stage to break"/>
2656+
<severity value="MAJOR"/>
2657+
<useCaseId value="MC-13917"/>
2658+
<testCaseId value="MC-13920"/>
2659+
<group value="pagebuilder"/>
2660+
<group value="pagebuilder-text"/>
2661+
</annotations>
2662+
<before>
2663+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2664+
<createData entity="_cmsPageWithNestedText" stepKey="createCMSPage"/>
2665+
<actionGroup ref="navigateToCreatedCMSPage" stepKey="navigateToContentCreatedCMSPage">
2666+
<argument name="CMSPage" value="$$createCMSPage$$"/>
2667+
</actionGroup>
2668+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
2669+
</before>
2670+
<after>
2671+
<actionGroup ref="logout" stepKey="logout"/>
2672+
</after>
2673+
<dontSeeElement selector="{{HtmlOnStage.base('1')}}" stepKey="dontSeeHtmlCode" />
2674+
<waitForElementVisible selector="{{TextOnStage.base('1')}}" stepKey="waitForTextVisible" />
2675+
<seeElement selector="{{TextOnStage.base('1')}}" stepKey="seeText" />
2676+
<seeElement selector="{{TextOnStage.text('1', PageBuilderTextTestString.value)}}" stepKey="seeTestStringInText"/>
2677+
</test>
26502678
</tests>

0 commit comments

Comments
 (0)