Skip to content

Commit 19385ae

Browse files
committed
MC-1438: Editing Text Content Block from the Stage with WYSIWYG turned off completely or by default
1 parent 7c68a18 commit 19385ae

File tree

2 files changed

+19
-17
lines changed

2 files changed

+19
-17
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderTextSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
<element name="textAreaText" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]//div[.='{{arg2}}']" parameterized="true"/>
1313
<element name="textAreaTextContains" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]//textarea[contains(@value,'{{arg2}}')]" parameterized="true"/>
1414
<element name="text" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]/div//*[contains(.,'{{arg2}}')]" parameterized="true"/>
15+
<element name="textString" type="text" selector="//*[contains(@class, 'pagebuilder-text')]//*[text()='{{agr}}']" parameterized="true"/>
1516
<element name="mcePlaceholder" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]/div//*[starts-with(@id, '{{arg2}}')]" parameterized="true"/>
1617
<element name="variablePlaceholder" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg}}]//*[@data-bind='html: data.main.html']//*[contains(@class, 'magento-variable magento-placeholder')]" parameterized="true"/>
1718
<element name="widgetPlaceholder" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg}}]//*[@data-bind='html: data.main.html']//*[contains(@class, 'magento-placeholder magento-widget')]" parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -57,16 +57,16 @@
5757
<argument name="contentType" value="PageBuilderTextContentType"/>
5858
</actionGroup>
5959
<!-- Add image to TextArea -->
60-
<comment userInput="Add image to TextArea" stepKey="comment1"/>
61-
<waitForElementVisible selector="{{TextOnConfiguration.insertImageButton}}" stepKey="waitForInsertImage"/>
62-
<click selector="{{TextOnConfiguration.insertImageButton}}" stepKey="clickInsertImage"/>
63-
<actionGroup ref="CreateImageFolder" stepKey="CreateImageFolder">
64-
<argument name="ImageFolder" value="ImageFolder"/>
65-
</actionGroup>
66-
<actionGroup ref="attachImage" stepKey="attachImage1">
67-
<argument name="Image" value="ImageUpload3"/>
68-
</actionGroup>
69-
<actionGroup ref="saveImage" stepKey="insertImage"/>
60+
<!--<comment userInput="Add image to TextArea" stepKey="comment1"/>-->
61+
<!--<waitForElementVisible selector="{{TextOnConfiguration.insertImageButton}}" stepKey="waitForInsertImage"/>-->
62+
<!--<click selector="{{TextOnConfiguration.insertImageButton}}" stepKey="clickInsertImage"/>-->
63+
<!--<actionGroup ref="CreateImageFolder" stepKey="CreateImageFolder">-->
64+
<!--<argument name="ImageFolder" value="ImageFolder"/>-->
65+
<!--</actionGroup>-->
66+
<!--<actionGroup ref="attachImage" stepKey="attachImage1">-->
67+
<!--<argument name="Image" value="ImageUpload3"/>-->
68+
<!--</actionGroup>-->
69+
<!--<actionGroup ref="saveImage" stepKey="insertImage"/>-->
7070
<!-- Add widget to TextArea -->
7171
<comment userInput="Add widget to TextArea" stepKey="comment2"/>
7272
<actionGroup ref="addPageLinkWidgetWYSIWYGDisabled" stepKey="addPageLinkWidgetWYSIWYGDisabled">
@@ -78,6 +78,7 @@
7878
<actionGroup ref="addPageLinkVariableWYSIWYGDisabled" stepKey="addPageLinkVariableWYSIWYGDisabled">
7979
<argument name="variable" value="PageBuilderTextArea_VariableBaseURL"/>
8080
</actionGroup>
81+
<executeJS function="return document.getElementById('{{TextOnConfiguration.textAreaId}}').value;" stepKey="expectedData"/>
8182
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
8283
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage3"/>
8384
<!-- Switch to TinyMCE4 -->
@@ -89,24 +90,24 @@
8990
<reloadPage stepKey="reloadPage"/>
9091
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage3"/>
9192
<waitForElementVisible selector="{{TextOnStage.tinymce('1')}}" stepKey="waitforTinyMCE4"/>
92-
<waitForElementVisible selector="//*[contains(@class, 'pagebuilder-text')]//*[text()='{{PageBuilderTextProperty.value}}']" stepKey="waitForText"/>
93-
<waitForElementVisible selector="{{TextOnStage.tinymce('1')}}{{CmsWYSIWYGSection.imageSource(ImageUpload3.fileName)}}" stepKey="assertMediaSourceOnStage2"/>
93+
<!--<waitForElementVisible selector="//*[contains(@class, 'pagebuilder-text')]//*[text()='{{PageBuilderTextProperty.value}}']" stepKey="waitForText"/>-->
94+
<waitForElementVisible selector="{{TextOnStage.textString('1', PageBuilderTextProperty.value})}}" stepKey="waitForText"/>
95+
<!--<waitForElementVisible selector="{{TextOnStage.tinymce('1')}}{{CmsWYSIWYGSection.imageSource(ImageUpload3.fileName)}}" stepKey="assertMediaSourceOnStage2"/>-->
9496
<waitForElementVisible selector="{{TextOnStage.text('1', TinyMCEVariableBaseURL.editPanelValue)}}" stepKey="waitForVariabBaseURL"/>
9597
<waitForElementVisible selector="{{TextOnStage.variablePlaceholder('1')}}" stepKey="waitForVariablePlaceholder"/>
9698
<waitForElementVisible selector="{{TextOnStage.text('1', TinyMCEWidgetCMSPageLink.editPanelValue)}}" stepKey="waitForWidgetValue"/>
9799
<waitForElementVisible selector="{{TextOnStage.widgetPlaceholder('1')}}" stepKey="waitForWidgetPlaceholder"/>
98-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings1"/>
100+
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage4"/>
99101
<!-- Switch to TinyMCE3 -->
100102
<comment userInput="Switch to TinyMCE3" stepKey="comment6"/>
101103
<magentoCLI command="config:set cms/wysiwyg/editor Magento_Tinymce3/tinymce3Adapter" stepKey="enableTinyMCE3"/>
102104
<reloadPage stepKey="reloadPage1"/>
103105
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage4"/>
104-
<executeJS function="return document.evaluate(&quot;{{TextOnStage.textArea('1')}}&quot;, document.body).iterateNext().value" stepKey="textareaValue"/>
106+
<executeJS function="return document.evaluate(&quot;{{TextOnStage.textArea('1')}}&quot;, document.body).iterateNext().value" stepKey="actualData"/>
105107
<assertEquals stepKey="assertTextValue">
106-
<expectedResult type="string">{{PageBuilderTextProperty.value}}{{CmsWYSIWYGSection.imageSource(ImageUpload3.fileName)}}{{TinyMCEVariableBaseURL.editPanelValue}}{{TinyMCEWidgetCMSPageLink.editPanelValue}}</expectedResult>
107-
<actualResult type="variable">textareaValue</actualResult>
108+
<expectedResult type="variable">expectedData</expectedResult>
109+
<actualResult type="variable">actualData</actualResult>
108110
</assertEquals>
109-
110111
</test>
111112
<test name="TextAreaInitalStatus">
112113
<annotations>

0 commit comments

Comments
 (0)