Skip to content

Commit 1767521

Browse files
committed
MC-3513: Empty Products Condition Results In 1px Height Products Content Type Wrapper On Stage
- Changed message for conditions that don't match products
1 parent a0caa35 commit 1767521

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

app/code/Magento/PageBuilder/i18n/en_US.csv

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -285,3 +285,4 @@ Add,Add
285285
"Elements","Elements"
286286
"Media","Media"
287287
"Add Content","Add Content"
288+
"No products were found matching your condition","No products were found matching your condition"

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/products/preview.js

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/products/preview.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ export default class Preview extends BasePreview {
2323
public placeholderText: KnockoutObservable<string>;
2424
private messages = {
2525
EMPTY: $t("Empty Products"),
26+
NO_RESULTS: $t("No products were found matching your condition"),
2627
LOADING: $t("Loading..."),
2728
UNKNOWN_ERROR: $t("An unknown error occurred. Please try again."),
2829
};
@@ -85,7 +86,7 @@ export default class Preview extends BasePreview {
8586
$.ajax(url, requestConfig)
8687
.done((response) => {
8788
if (typeof response.data !== "object" || !Boolean(response.data.content)) {
88-
this.placeholderText(this.messages.EMPTY);
89+
this.placeholderText(this.messages.NO_RESULTS);
8990

9091
return;
9192
}

0 commit comments

Comments
 (0)