Skip to content

Commit 1763742

Browse files
author
Hwashiang Yu
committed
MC-5383: Option Menus, Heading Inline Editor & tinyMCE Inline Editor Are Cut Off on Full Screen View
- Resolved static failures - Resolved incorrect test reference
1 parent 9dd640c commit 1763742

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderPanelTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -757,7 +757,7 @@
757757
</actionGroup>
758758
<executeJS function="return document.evaluate(`{{PageBuilderContentTypeOptionsMenu.contentTypeEditByIndex(PageBuilderHeadingContentType.role, '1')}}`, document.body).iterateNext().getBoundingClientRect().right" stepKey="getHeadingOptionMenuBoundingClientRectRightFullScreen"/>
759759
<assertLessThanOrEqual stepKey="assertHeadingOptionMenuNotOverflowFullScreen">
760-
<expectedResult type="variable">$getWindowWidthFullScreen</expectedResult>
760+
<expectedResult type="variable">$getWindowWidth</expectedResult>
761761
<actualResult type="variable">$getHeadingOptionMenuBoundingClientRectRightFullScreen</actualResult>
762762
</assertLessThanOrEqual>
763763
<!-- Assert text options menu did not overflow -->
@@ -768,7 +768,7 @@
768768
</actionGroup>
769769
<executeJS function="return document.evaluate(`{{PageBuilderContentTypeOptionsMenu.contentTypeEditByIndex(PageBuilderTextContentType.role, '1')}}`, document.body).iterateNext().getBoundingClientRect().right" stepKey="getTextOptionMenuBoundingClientRectRightFullScreen"/>
770770
<assertLessThanOrEqual stepKey="assertTextOptionMenuNotOverflowFullScreen">
771-
<expectedResult type="variable">$getWindowWidthFullScreen</expectedResult>
771+
<expectedResult type="variable">$getWindowWidth</expectedResult>
772772
<actualResult type="variable">$getTextOptionMenuBoundingClientRectRightFullScreen</actualResult>
773773
</assertLessThanOrEqual>
774774
</test>

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/_preview.less

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -323,16 +323,16 @@
323323
}
324324

325325
.pagebuilder-options {
326+
-moz-transition: opacity 200ms, visibility 200ms;
327+
-o-transition: opacity 200ms, visibility 200ms;
328+
-webkit-transition: opacity 200ms, visibility 200ms;
326329
height: 40px;
327330
opacity: 0;
328331
position: absolute;
329332
right: 0;
330333
text-align: center;
331334
top: 0;
332335
transform: translate(0, -50%);
333-
-moz-transition: opacity 200ms, visibility 200ms;
334-
-o-transition: opacity 200ms, visibility 200ms;
335-
-webkit-transition: opacity 200ms, visibility 200ms;
336336
transition: opacity 200ms, visibility 200ms;
337337
visibility: hidden;
338338
z-index: 105;
@@ -461,12 +461,12 @@
461461

462462
.focus-options {
463463
.pagebuilder-options {
464-
right: 50%;
465-
top: -20px;
466-
transform: translate(50%, -50%);
467464
-moz-transition: opacity 200ms, visibility 200ms, transform 200ms;
468465
-o-transition: opacity 200ms, visibility 200ms, transform 200ms;
469466
-webkit-transition: opacity 200ms, visibility 200ms, transform 200ms;
467+
right: 50%;
468+
top: -20px;
469+
transform: translate(50%, -50%);
470470
transition: opacity 200ms, visibility 200ms, transform 200ms;
471471
transition-delay: 0ms !important; // Arrow options have no delay in transitioning out
472472

0 commit comments

Comments
 (0)